Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-03 Thread schmidts
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3093/#review10512 --- i have found a bug but i am not sure if this only depends on

Re: [asterisk-dev] [svn-commits] kharwell: branch 12 r404663 - in /branches/12: ./ channels/ configs/ include/...

2014-01-03 Thread Olle E. Johansson
On 02 Jan 2014, at 20:06, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: res_pjsip: add 'set_var' support on endpoints Coming in late... In sip.conf, skinny.conf and other places, it's setvar without underscore. Why change the syntax already used? /O --

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-03 Thread Joshua Colp
On Jan. 3, 2014, 9:24 a.m., schmidts wrote: i have found a bug but i am not sure if this only depends on this patch or on pjsip itself. I have a subscribe sipp scenario which works fine with chan_sip but broke down pjsip completly. i have found that in my scenario i have a wrong

Re: [asterisk-dev] [svn-commits] kharwell: branch 12 r404663 - in /branches/12: ./ channels/ configs/ include/...

2014-01-03 Thread Matthew Jordan
On Fri, Jan 3, 2014 at 4:25 AM, Olle E. Johansson o...@edvina.net wrote: On 02 Jan 2014, at 20:06, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: res_pjsip: add 'set_var' support on endpoints Coming in late... In sip.conf, skinny.conf and other places, it's

Re: [asterisk-dev] [svn-commits] kharwell: branch 12 r404663 - in /branches/12: ./ channels/ configs/ include/...

2014-01-03 Thread Olle E. Johansson
On 03 Jan 2014, at 16:50, Matthew Jordan mjor...@digium.com wrote: In sip.conf, skinny.conf and other places, it's setvar without underscore. Why change the syntax already used? Hey Olle - The syntax here is strictly snake case for two reasons: (1) It keeps it in line with the

Re: [asterisk-dev] [svn-commits] kharwell: branch 12 r404663 - in /branches/12: ./ channels/ configs/ include/...

2014-01-03 Thread Matthew Jordan
On Fri, Jan 3, 2014 at 9:57 AM, Olle E. Johansson o...@edvina.net wrote: On 03 Jan 2014, at 16:50, Matthew Jordan mjor...@digium.com wrote: In sip.conf, skinny.conf and other places, it's setvar without underscore. Why change the syntax already used? Hey Olle - The syntax here is

Re: [asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

2014-01-03 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3089/#review10515 --- So...I just don't really like this. 1) Making a macro like

Re: [asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

2014-01-03 Thread rmudgett
On Jan. 3, 2014, 11:12 a.m., Mark Michelson wrote: So...I just don't really like this. 1) Making a macro like this makes the code more esoteric than it previously was. 2) The fact that the loop_obj has to be NULLed out before breaking or returning from the loop if no reference

Re: [asterisk-dev] [Code Review] 3098: compiler warnings

2014-01-03 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3098/ --- (Updated Jan. 3, 2014, 12:31 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3101: rasterisk needlessly prints the AST-2013-007 warning

2014-01-03 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3101/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23084

Re: [asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

2014-01-03 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3089/ --- (Updated Jan. 3, 2014, 1:15 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3101: rasterisk needlessly prints the AST-2013-007 warning

2014-01-03 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3101/#review10517 --- Ship it! Ship It! - Paul Belanger On Jan. 3, 2014, 7:14

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2014-01-03 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/#review10518 --- Ship it! Ship It! - Mark Michelson On Dec. 20, 2013, 4:37

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3093/ --- (Updated Jan. 3, 2014, 8:18 p.m.) Review request for Asterisk Developers.

[asterisk-dev] how to send ast_frames?

2014-01-03 Thread Alessandro Carminati
Hello everybody, I'm trying writing an app for transmit an FSK message over the line. I'm having troubles basically because I have no idea of how a voice frame should be sent using asterisk's api. If I use this piece of code toward a phone, I can indeed hear the FSK tone. But if I send it to the