Re: [asterisk-dev] [Code Review] 3101: rasterisk needlessly prints the AST-2013-007 warning

2014-01-06 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3101/ --- (Updated Jan. 6, 2014, 10:38 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3101: rasterisk needlessly prints the AST-2013-007 warning

2014-01-06 Thread Sean Darcy
On 01/05/2014 04:03 PM, Tzafrir Cohen wrote: On Sun, Jan 05, 2014 at 02:34:35PM -0500, Sean Darcy wrote: I agree on asterisk -rx, but as someone who just recently stopped living dangerously I suggest you keep it for a remote login. I never see asterisk start up. It's part of the systemd proces

Re: [asterisk-dev] no ast_channel_varshead in 1.8 [was: Re: [svn-commits] sgriepentrog: branch 1.8 r404674 - /branches/1.8/funcs/func_strings.c]

2014-01-06 Thread Scott Griepentrog
Thanks for catching that. I've updated my build script to set TEST_FRAMEWORK so I don't miss that in the future. Patched in r404941, and double checked to insure tests pass. On Sat, Jan 4, 2014 at 9:46 AM, Tzafrir Cohen wrote: > On Thu, Jan 02, 2014 at 07:32:24PM -, SVN commits to the Digi

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2014-01-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/ --- (Updated Jan. 6, 2014, 11:50 a.m.) Status -- This change has been mar

[asterisk-dev] Asterisk Media Performance

2014-01-06 Thread Joshua Colp
Greetings everyone, I've been doing some profiling over the past few days on Asterisk 12 with a focus on media. I've uncovered some stuff but before I get into things let's go back in time a bit... to when things were simpler. In the old times media formats were represented using a bit field.

Re: [asterisk-dev] Asterisk Media Performance

2014-01-06 Thread David Lee (digium)
On Jan 6, 2014, at 11:54 AM, Joshua Colp wrote: > 1. Make ast_format an ao2 object > > I think what needs to happen is that ast_format becomes an immutable ao2 > reference counted object. Copying becomes bumping the reference count and > returning it. > > Additional related stuff can be atta

Re: [asterisk-dev] Asterisk Media Performance

2014-01-06 Thread Joshua Colp
David Lee (digium) wrote: Synchronizing the notifications with the format change may be tricky. If we’re not careful, we could end up in the situation where 1) the format changes but some bit of code gets the notification about the change too late or 2) we end up with extra locks/contention in t

Re: [asterisk-dev] [Code Review] 3094: res_pjsip_messaging: potential for field values in from/to headers to be missing

2014-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3094/ --- (Updated Jan. 6, 2014, 12:49 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23020 https://i

[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-06 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/ --- (Updated Jan. 6, 2014, 3:52 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-06 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/ --- (Updated Jan. 6, 2014, 3:53 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3105: Testsuite: Test PJSIP hold and unhold for various conditions for INVITE SDPs

2014-01-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3105/ --- Review request for Asterisk Developers, Joshua Colp, Matt Jordan, and Mark

[asterisk-dev] [Code Review] 3106: res_pjsip_session: If a reinvite without an SDP is received, unhold the call.

2014-01-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3106/ --- Review request for Asterisk Developers, Joshua Colp and Mark Michelson. Re

Re: [asterisk-dev] Asterisk Media Performance

2014-01-06 Thread David Lee (digium)
On Jan 6, 2014, at 12:20 PM, Joshua Colp wrote: > David Lee (digium) wrote: >> >> Synchronizing the notifications with the format change may be tricky. If >> we’re not careful, we could end up in the situation where 1) the format >> changes but some bit of code gets the notification about the c