Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3135/ --- (Updated Jan. 18, 2014, 12:58 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

> On Jan. 17, 2014, 11:50 p.m., rmudgett wrote: > > /branches/1.8/main/channel.c, lines 3576-3579 > > > > > > This should not be done at all. > > > > You are dropping a reference when timingdata doesn't re

Re: [asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3134/#review10633 --- Only the corryfarrel patch is needed. The other patch is not c

Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3135/#review10631 --- /branches/1.8/main/channel.c

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3136/#review10632 --- Not sure this is a good idea. First, I wouldn't hardcode a tes

[asterisk-dev] res_pjsip: MWI subscription missing name

Greetings, When a subscription to MWI comes into the res_pjsip_mwi module it will attempt to extract an "aor_name" from the URI on the request. Currently a warning message is logged and the request is rejected if a suitable AoR cannot be found by the given name. But what should happen if the req

[asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3136/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23092 https://i

Re: [asterisk-dev] [Code Review] 2723: Add pass through support for both VP8 and Opus

> On Jan. 16, 2014, 5:16 p.m., Sean Bright wrote: > > /trunk/channels/chan_sip.c, lines 13419-13421 > > > > > > Shouldn't this be &a_audio instead of &a_text, or does it matter? > > Matt Jordan wrote: > Good

[asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3135/ --- Review request for Asterisk Developers and leifmadsen. Repository: Asteris

Re: [asterisk-dev] [Code Review] 2723: Add pass through support for both VP8 and Opus

> On Jan. 16, 2014, 11:16 a.m., Sean Bright wrote: > > /trunk/channels/chan_sip.c, lines 13419-13421 > > > > > > Shouldn't this be &a_audio instead of &a_text, or does it matter? Good catch - feel free to patch a

Re: [asterisk-dev] [Code Review] 3131: PJSIP: support 'allow=all'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3131/ --- (Updated Jan. 17, 2014, 3:53 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3122: ARI: Add support for specifying channel variables during originate

> On Jan. 17, 2014, 12:38 p.m., Kevin Harwell wrote: > > branches/12/res/ari/resource_channels.c, lines 753-756 > > > > > > I'm sure you looked into this, but is there no way to have this block > > of code in the a

Re: [asterisk-dev] [Code Review] 3126: testsuite: check chunked Transfer-Encoding operation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3126/ --- (Updated Jan. 17, 2014, 2:58 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3125/ --- (Updated Jan. 17, 2014, 2:51 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3125/#review10627 --- Ship it! The chunked decode looks good according to the RFC!

Re: [asterisk-dev] [Code Review] 3130: testsuite: Update hold test to monitor device state of PJSIP channels

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3130/#review10626 --- Ship it! Ship It! - Mark Michelson On Jan. 16, 2014, 6:33 p

[asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3134/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22861 https://i

Re: [asterisk-dev] [Code Review] 3122: ARI: Add support for specifying channel variables during originate

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3122/#review10625 --- branches/12/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/#review10624 --- Ship it! Ship It! - Mark Michelson On Jan. 16, 2014, 8:26 p

Re: [asterisk-dev] [Code Review] 3131: PJSIP: support 'allow=all'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3131/#review10623 --- Ship it! Because my comments are so minor, I'm going ahead wit

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/#review10619 --- Without going into the functionality of the patch, a few notes:

Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- (Updated Jan. 17, 2014, 9:46 a.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3129: chan_pjsip: Provide a means for updating device state when going on/off hold

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3129/#review10622 --- Ship it! Ship It! - Mark Michelson On Jan. 16, 2014, 8:56 p

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

> On Jan. 16, 2014, 5 p.m., Mark Michelson wrote: > > /branches/12/main/http.c, line 813 > > > > > > chunked_atoh shouldn't be necessary. You should be able to just use: > > > > sscanf(chunk_header, %x, &ch

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3125/#review10621 --- Ship it! Ship It! - Mark Michelson On Jan. 13, 2014, 11:26