Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- (Updated Jan. 22, 2014, 3:30 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] Bounty for regular beep in Monitor() and MixMonitor()

2014-01-21 Thread Igor Goncharovsky
Andrey, As far as I know it is still actual. I have made some work based on how L() option warning played to bridge. This implementation have number of issues, but work well in all cases when channels bridged. Also Matthew's thoughts seems very helpfull. 2014/1/21 Andrey Utkin > 2013/9/26 Alis

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10655 --- 18<X-Rob> mjordan: if you could update https://reviewboa

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-21 Thread Russell Bryant
> On Jan. 22, 2014, 1:14 a.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, > > line 1 > > > > > > You should be creating new alembic

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-21 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/#review10653 --- comments about modifying alembic. branches/12/contrib/ast-db-

[asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-21 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23038 https://i

[asterisk-dev] [Code Review] 3147: manager: eventfilter= should use extended regex in trunk

2014-01-21 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3147/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation

2014-01-21 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/#review10652 --- Ship it! Ship It! - Matt Jordan On Jan. 17, 2014, 3:46 a.m.

Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

2014-01-21 Thread Scott Griepentrog
> On Jan. 20, 2014, 9:08 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/test-config.yaml, lines > > 16-29 > > > > > > I'd prefer not to have all of these tests. > > > > 1. M

Re: [asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

2014-01-21 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3144/ --- (Updated Jan. 21, 2014, 11:34 a.m.) Review request for Asterisk Developers

[asterisk-dev] What is dahdi.auto_assigned_spans and why should you care? (II)

2014-01-21 Thread Tzafrir Cohen
Hi again, Some other things missing from the previous message: setting E1/T1/[J1?] and upgrading. E1/T1 - an E1/T1/J1 should be configured to be either E1 or T1.There are a number of ways to set this. Specifically: quite a few different ways. With the new DAHDI initialization scheme we also

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-21 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/ --- (Updated Jan. 21, 2014, 11:21 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] Media Format Work

2014-01-21 Thread Matthew Jordan
On Tue, Jan 21, 2014 at 10:17 AM, Sean Darcy wrote: > On 01/21/2014 10:14 AM, Joshua Colp wrote: >> >> Greetings everyone, >> >> I thought I'd give an update on this. The wiki page[1] is now at a state >> where I'm happy with the design aspect of it. Matt Jordan has also >> contributed test cases

Re: [asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

2014-01-21 Thread rmudgett
> On Jan. 21, 2014, 3:18 a.m., Guenther Kelleter wrote: > > /branches/11/main/manager.c, lines 5628-5633 > > > > > > This replaces session_destroy(...) with unref_mansession(...) so > > session is not removed from

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

2014-01-21 Thread George Joseph
> On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!" doesn't really make sense. It actually > > negates the d

Re: [asterisk-dev] Media Format Work

2014-01-21 Thread Sean Darcy
On 01/21/2014 10:14 AM, Joshua Colp wrote: Greetings everyone, I thought I'd give an update on this. The wiki page[1] is now at a state where I'm happy with the design aspect of it. Matt Jordan has also contributed test cases to the wiki page which will be implemented so that the existing code (

Re: [asterisk-dev] Bounty for regular beep in Monitor() and MixMonitor()

2014-01-21 Thread Matthew Jordan
On Tue, Jan 21, 2014 at 4:23 AM, Andrey Utkin wrote: > 2013/9/26 Alistair Cunningham : >> I don't think we want to do this. This is for Enswitch, which is a big >> complex carrier product, with some systems having many thousands of >> concurrent calls, and lots of existing dial plan complexity suc

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-21 Thread opticron
> On Jan. 17, 2014, 8:44 a.m., wdoekes wrote: > > asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml, > > lines 92-93 > > > > > > I think you can do: > > > > From

[asterisk-dev] Media Format Work

2014-01-21 Thread Joshua Colp
Greetings everyone, I thought I'd give an update on this. The wiki page[1] is now at a state where I'm happy with the design aspect of it. Matt Jordan has also contributed test cases to the wiki page which will be implemented so that the existing code (and new code) will have tests that cover vari

Re: [asterisk-dev] [Code Review] 3122: ARI: Add support for specifying channel variables during originate

2014-01-21 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3122/ --- (Updated Jan. 21, 2014, 8:27 a.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

2014-01-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3145/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] Bounty for regular beep in Monitor() and MixMonitor()

2014-01-21 Thread Andrey Utkin
2013/9/26 Alistair Cunningham : > I don't think we want to do this. This is for Enswitch, which is a big > complex carrier product, with some systems having many thousands of > concurrent calls, and lots of existing dial plan complexity such as heavy > use of local channels. We really really don't

Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation

2014-01-21 Thread wdoekes
> On Jan. 21, 2014, 3:08 a.m., Matt Jordan wrote: > > /branches/1.8/configs/manager.conf.sample, line 92 > > > > > > I agree that it's odd to use basic instead of extended. > > > > Maybe document it in 1.8+,

Re: [asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

2014-01-21 Thread Guenther Kelleter
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3144/#review10646 --- /branches/11/main/manager.c