Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

2014-01-22 Thread Matt Jordan
> On Jan. 20, 2014, 9:08 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/pjsip/tests.yaml, line 16 > > > > > > Thinking for the future: > > > > This is really a test for Offer/Answer - if we conf

Re: [asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

2014-01-22 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3134/ --- (Updated Jan. 22, 2014, 4:28 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

2014-01-22 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/ --- (Updated Jan. 22, 2014, 4:05 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3149: manager: ExtensionStatus event status human readable

2014-01-22 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3149/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23154 https://i

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-22 Thread Paul Belanger
> On Jan. 22, 2014, 1:14 a.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, > > line 1 > > > > > > You should be creating new alembic

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-22 Thread Kevin Harwell
> On Jan. 21, 2014, 7:14 p.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, > > line 1 > > > > > > You should be creating new alembic

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-22 Thread Paul Belanger
> On Jan. 22, 2014, 1:14 a.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, > > line 1 > > > > > > You should be creating new alembic

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-22 Thread Scott Griepentrog
> On Jan. 21, 2014, 7:14 p.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py, > > lines 38-39 > > > > > > same comment as above > > Kevin Harwell wrote

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-22 Thread Kevin Harwell
> On Jan. 21, 2014, 7:14 p.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, > > line 1 > > > > > > You should be creating new alembic