Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10701 --- Current code says "You will be placed into the conference." to

Re: [asterisk-dev] [Code Review] 3156: rtp_engine: improved handling of get_rtp_info failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3156/#review10700 --- Ship it! I'm not going to say no to error messages in strange

Re: [asterisk-dev] [Code Review] 3156: rtp_engine: improved handling of get_rtp_info failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3156/ --- (Updated Jan. 24, 2014, 7:08 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3156: rtp_engine: improved handling of get_rtp_info failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3156/#review10698 --- /branches/1.8/main/rtp_engine.c

Re: [asterisk-dev] [Code Review] 3128: Protect CEL data structures during reload and shutdown. v12 version.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3128/ --- (Updated Jan. 24, 2014, 5:30 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3127: Protect CEL data structures during reload and shutdown. v11 version.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3127/ --- (Updated Jan. 24, 2014, 5:18 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3151: res_pjsip: PJSUA pluggable module and subscription tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3151/ --- (Updated Jan. 24, 2014, 11 p.m.) Review request for Asterisk Developers.

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.9.0-rc1 Now Available

The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.9.0-rc1 DAHDI-Tools-v2.9.0-rc1 dahdi-linux-complete-2.9.0-rc1+2.9.0-rc1 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux http://downloads.asterisk.org/pub/teleph

Re: [asterisk-dev] [Code Review] 3142: Thread Debugging: Add LWP to core show locks output

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3142/ --- (Updated Jan. 24, 2014, 4:35 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3151: res_pjsip: PJSUA pluggable module and subscription tests

> On Jan. 24, 2014, 10:15 p.m., Kevin Harwell wrote: > > /asterisk/trunk/lib/python/asterisk/pluggable_modules.py, line 271 > > > > > > Parent method calls should also now be called with "super". Unfortunately, thi

Re: [asterisk-dev] [Code Review] 3151: res_pjsip: PJSUA pluggable module and subscription tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3151/#review10693 --- /asterisk/trunk/lib/python/asterisk/pluggable_modules.py

Re: [asterisk-dev] [Code Review] 3139: chan_pjsip: Test that all configured codecs are present in INVITE when sending

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3139/#review10696 --- Ship it! /asterisk/trunk/tests/channels/pjsip/basic_calls/two

Re: [asterisk-dev] [Code Review] 3140: chan_pjsip: Send configured codecs even when core requests a specific one

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3140/#review10695 --- Ship it! Ship It! - Mark Michelson On Jan. 18, 2014, 5:17 p

Re: [asterisk-dev] [Code Review] 3141: res_config_pgsql: Make sure PQClear is used for all PGResults

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3141/ --- (Updated Jan. 24, 2014, 3:46 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/#review10694 --- Ship it! Ship It! - Mark Michelson On Jan. 24, 2014, 7:33 p

Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3145/#review10692 --- /asterisk/trunk/tests/rest_api/bridges/attended_transfer/atten

Re: [asterisk-dev] [Code Review] 3152: testsuite: Add a test for SQLite3 backend and custom CDR entries

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3152/#review10691 --- Ship it! Ship It! - Mark Michelson On Jan. 24, 2014, 8:16 p

Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/#review10690 --- branches/11/apps/confbridge/conf_state_multi_marked.c

[asterisk-dev] [Code Review] 3156: rtp_engine: improved handling of get_rtp_info failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3156/ --- Review request for Asterisk Developers. Bugs: AST-1276 https://issues.

Re: [asterisk-dev] [Code Review] 3152: testsuite: Add a test for SQLite3 backend and custom CDR entries

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3152/ --- (Updated Jan. 24, 2014, 2:16 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3152: testsuite: Add a test for SQLite3 backend and custom CDR entries

> On Jan. 24, 2014, 1:55 p.m., Mark Michelson wrote: > > /asterisk/trunk/tests/cdr/sqlite3/cdr_sqlite3.py, lines 128-139 > > > > > > There's something I don't like about this method of verifying CDR > > entries: yo

Re: [asterisk-dev] [Code Review] 3152: testsuite: Add a test for SQLite3 backend and custom CDR entries

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3152/#review10688 --- /asterisk/trunk/tests/cdr/sqlite3/cdr_sqlite3.py

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/ --- (Updated Jan. 24, 2014, 1:33 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

> On Jan. 24, 2014, 1:13 p.m., Mark Michelson wrote: > > /branches/12/apps/app_dial.c, lines 1282-1283 > > > > > > I agree with the removal of ast_channel_publish_dial() here. As you > > pointed out, the status ca

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/#review10686 --- /branches/12/apps/app_dial.c

[asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3155/ --- Review request for Asterisk Developers. Bugs: PQ-1396 https://issues.a

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/#review10684 --- Aside from this one problem, the C portion of this review looks

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/#review10685 --- Okay, so I see what you are saying. I just ran the scripts and

Re: [asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3144/ --- (Updated Jan. 24, 2014, 12:29 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10683 --- /branches/12/res/res_pjsip_multihomed.c

Re: [asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3153/ --- (Updated Jan. 24, 2014, 12:09 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23164 https://i

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- (Updated Jan. 24, 2014, 12:01 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3144/#review10682 --- Ship it! Ship It! - Mark Michelson On Jan. 21, 2014, 5:34 p

[asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3153/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23164 https://i

[asterisk-dev] [Code Review] 3152: testsuite: Add a test for SQLite3 backend and custom CDR entries

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3152/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23162 https://i

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/ --- (Updated Jan. 24, 2014, 11:46 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3149: manager: ExtensionStatus event status human readable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3149/#review10681 --- Ship it! Ship It! - Mark Michelson On Jan. 22, 2014, 7:04 p

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

> On Jan. 24, 2014, 4:49 p.m., Mark Michelson wrote: > > branches/12/res/res_pjsip/config_system.c, lines 152-156 > > > > > > Josh may correct me on this, but since sorcery configs are immutable, > > you shouldn't

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

> On Jan. 24, 2014, 10:49 a.m., Mark Michelson wrote: > > Note: My review is strictly on the C code and not the alembic stuff. > > > > Is there a particular reason you placed this option in the "system" type > > instead of the "global" type? The difference between the two is that system > > op

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3148/#review10677 --- Note: My review is strictly on the C code and not the alembic s

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

> On Jan. 21, 2014, 7:14 p.m., Paul Belanger wrote: > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, > > line 1 > > > > > > You should be creating new alembic

Re: [asterisk-dev] Asterisk 11; WEBRTC firefox nightly build fingeprint sha-256

On 24/01/14 10:59, Lorenzo Miniero wrote: > Hi Daniel, > > the "sha-2" error can be easily circumvented, and the dtlsverify=no > needs an additional callback in the code to always return a success. > Nitesh and I provided some patches here: > > https://issues.asterisk.org/jira/browse/ASTERISK-22961

Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/#review10663 --- /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming

Re: [asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths->names == NULL) to ast_sip_auth_array_destroy(auths)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3143/#review10675 --- Ship it! Ship It! - Joshua Colp On Jan. 20, 2014, 10:03 p.m

Re: [asterisk-dev] [Code Review] 3149: manager: ExtensionStatus event status human readable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3149/#review10674 --- Ship it! Ship It! - Joshua Colp On Jan. 22, 2014, 7:04 p.m.

Re: [asterisk-dev] [Code Review] 3150: Decouple Subscription handling and NOTIFY/PUBLISH body generation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3150/#review10673 --- Ship it! U, I've looked over this twice and come up with n

Re: [asterisk-dev] Asterisk 11; WEBRTC firefox nightly build fingeprint sha-256

Hi Daniel, the "sha-2" error can be easily circumvented, and the dtlsverify=no needs an additional callback in the code to always return a success. Nitesh and I provided some patches here: https://issues.asterisk.org/jira/browse/ASTERISK-22961 Mine was specifically targeted at getting Firefox to

Re: [asterisk-dev] Asterisk 11; WEBRTC firefox nightly build fingeprint sha-256

On 22/02/13 22:09, Matthew Jordan wrote: > On 02/22/2013 10:40 AM, Mitja Kaučič wrote: >> Hello Joshua and Matthew. >> >> I would be happy to contribute with a patch. >> I just need folowing info: >> 1. With witch client can i test the current implementation of DTLS-SRTP on >> asterisk? > They're

Re: [asterisk-dev] Asterisk handling of AVPF

On 23/01/14 16:15, Matthew Jordan wrote: > On Thu, Jan 23, 2014 at 7:30 AM, Daniel Pocock wrote: >> On 03/07/13 11:39, Torrey Searle wrote: >> >> Was this change accepted? >> >> In 11.5 (using the Debian packages) it still appears that incoming calls are >> rejected if they don't match the AVPF se