Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-10 Thread Joshua Colp
Matthew Jordan wrote: It's important to point out that optimization's goal was never the removal of the channel. If anything, nuking Local channels has - in my opinion - always made life more difficult for everyone, not easier. The goal was performance - minimize the frame path. If I'm pi

Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-10 Thread Matthew Jordan
On Mon, Mar 10, 2014 at 6:59 AM, Joshua Colp wrote: > Matthew Jordan wrote: > >> >> > > > > >> It's important to point out that optimization's goal was never the >> removal of the channel. If anything, nuking Local channels has - in >> my opinion - always made life more difficult for everyone, n

Re: [asterisk-dev] [Code Review] 3316: CHANGES: update documentation for unique id changes

2014-03-10 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3316/ --- (Updated March 10, 2014, 11:40 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] Proposal for PJSIP TOS/COS and DSCP

2014-03-10 Thread Jonathan Rose
So there is a change in plans I should report here. I was approaching this from the standpoint of option 3 described before... looking into deprecating the TOS options in favor of DSCP options. Doing so breaks some configuration tests in a fairly trivial manner because only the DSCP fields show up

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-10 Thread Leif Madsen
> On March 6, 2014, 9:20 p.m., Mark Michelson wrote: > > I'm not a fan of this change, because I think it's not really fixing the > > root problem. bridge_p2p_rtp_write() is called in only one place in > > res_rtp_asterisk.c, and it's called like this: > > > > /* If we are directly bridged

Re: [asterisk-dev] [Code Review] 3317: pjsip: TOS/DSCP phase 2: Introduce DSCP equivalents to tos/tos_audio/tos_video and deprecate the existing tos options.

2014-03-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3317/ --- (Updated March 10, 2014, 1:02 p.m.) Status -- This change has been di

Re: [asterisk-dev] [Code Review] 3316: CHANGES: update documentation for unique id changes

2014-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3316/#review11139 --- Ship it! Don't forget to mark the previous review issue as fix

[asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

2014-03-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/ --- Review request for Asterisk Developers, George Joseph and Matt Jordan. Bug

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

2014-03-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/#review11140 --- /branches/12/res/res_pjsip/config_transport.c

[asterisk-dev] [Code Review] 3323: res_pjsip: Update PJSIP tests that evaluate ToS settings to go back to anticipating decimal values. Also fix another failure that is more recent.

2014-03-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3323/ --- Review request for Asterisk Developers, Matt Jordan and Scott Griepentrog.

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-10 Thread Mark Michelson
> On March 6, 2014, 9:20 p.m., Mark Michelson wrote: > > I'm not a fan of this change, because I think it's not really fixing the > > root problem. bridge_p2p_rtp_write() is called in only one place in > > res_rtp_asterisk.c, and it's called like this: > > > > /* If we are directly bridged

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-03-10 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review11142 --- Ship it! This solved the issues I was having when using 0.0.0.

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-03-10 Thread opticron
> On March 10, 2014, 3:38 p.m., opticron wrote: > > This solved the issues I was having when using 0.0.0.0 as the bind address > > for the only defined transport on my multihomed setup. Previously, the > > issue this fixes was causing all kinds of weirdness when trying to connect > > calls and

[asterisk-dev] Asterisk 1.8.15-cert5, 1.8.26.1, 11.6-cert2, 11.8.1, 12.1.1 Now Available (Security Release)

2014-03-10 Thread Asterisk Development Team
The Asterisk Development Team has announced security releases for Certified Asterisk 1.8.15, 11.6, and Asterisk 1.8, 11, and 12. The available security releases are released as versions 1.8.15-cert5, 11.6-cert2, 1.8.26.1, 11.8.1, and 12.1.1. These releases are available for immediate download at h

[asterisk-dev] AST-2014-001: Stack Overflow in HTTP Processing of Cookie Headers.

2014-03-10 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2014-001 ProductAsterisk SummaryStack Overflow in HTTP Processing of Cookie Headers. Nature of Advisory Denial Of Service

[asterisk-dev] AST-2014-002: Denial of Service Through File Descriptor Exhaustion with chan_sip Session-Timers

2014-03-10 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2014-002 ProductAsterisk SummaryDenial of Service Through File Descriptor Exhaustion with chan_sip Session-Timers

[asterisk-dev] AST-2014-004: Remote Crash Vulnerability in PJSIP Channel Driver Subscription Handling

2014-03-10 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2014-004 ProductAsterisk SummaryRemote Crash Vulnerability in PJSIP Channel Driver Subscription Handling

[asterisk-dev] AST-2014-003: Remote Crash Vulnerability in PJSIP channel driver

2014-03-10 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2014-003 ProductAsterisk SummaryRemote Crash Vulnerability in PJSIP channel driver Nature of Advisory Denial of Service

[asterisk-dev] [Code Review] 3325: res_mwi_external: Clear the stasis cache entry when the external MWI is deleted.

2014-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3325/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

2014-03-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/#review11144 --- Ship it! Ship It! - George Joseph On March 10, 2014, 1:04 p