Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-11 Thread Matthew Jordan
On Mon, Mar 10, 2014 at 7:27 AM, Matthew Jordan mjor...@digium.com wrote: On Mon, Mar 10, 2014 at 6:59 AM, Joshua Colp jc...@digium.com wrote: Matthew Jordan wrote: snip The NLB compatibility code actually checks whether something like a MixMonitor is on either Local channel and won't

Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-11 Thread Joshua Colp
Matthew Jordan wrote: snip All of these scenarios are currently handled by core_unreal and core_local in some fashion. It is, however, very complex code that - particularly with Local channel chains - is prone to error. The implementation today faces two problems: (1) Knowledge of what is on

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- (Updated March 11, 2014, 11:06 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3311: tests/apps/agents/agent_request: Add nominal agent request test

2014-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3311/ --- (Updated March 11, 2014, 11:06 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3315: BridgeWait Roles Test

2014-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3315/#review11145 --- Ship it! Ship It! - Matt Jordan On March 6, 2014, 3:04

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

2014-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3248/#review11146 --- Hey Moy - I'm thinking of cutting release candidates this week

[asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

2014-03-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3314: Testsuite: BridgeWait's S Option Test

2014-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3314/#review11148 ---

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

2014-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/#review11149 --- Update the documentation ^_^ - Joshua Colp On March 11,

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/#review11147 --- Ship it! Ship It! - Matt Jordan On March 6, 2014, 5:59

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

2014-03-11 Thread Moises Silva
On March 11, 2014, 6:09 p.m., Matt Jordan wrote: Hey Moy - I'm thinking of cutting release candidates this week or the next, and I'd love to get this into 11.9.0+. Any chance you can commit this sometime this week? Not sure if you noticed I did a merge already, except for the latest

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

2014-03-11 Thread Matt Jordan
On March 11, 2014, 1:09 p.m., Matt Jordan wrote: Hey Moy - I'm thinking of cutting release candidates this week or the next, and I'd love to get this into 11.9.0+. Any chance you can commit this sometime this week? Moises Silva wrote: Not sure if you noticed I did a merge

[asterisk-dev] [Code Review] 3327: Test for endmarked users in confbridge

2014-03-11 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3327/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23302

[asterisk-dev] [Code Review] 3328: Agent Acknowledgement Nominal and Error Tests

2014-03-11 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3328/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23263

[asterisk-dev] [Code Review] 3329: AGI Exit Status Test

2014-03-11 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3329/ --- Review request for Asterisk Developers. Bugs: ASTERISK-19167

Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-11 Thread Corey Farrell
My one concern is if we stop optimizing Local channels and allow the ast_channel to live for the duration of the call, this could significantly increase open FD's. This would be a bigger issue for systems using res_timing_timerfd, since that causes alert pipe's to be created. On Tue, Mar 11,

Re: [asterisk-dev] [Code Review] 3314: Testsuite: BridgeWait's S Option Test

2014-03-11 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3314/ --- (Updated March 11, 2014, 9:51 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3331: Allows app_chanspy to whisper to a spyee's bridged peer (barge) even if the bridged party answers after initial spy invocation.

2014-03-11 Thread Robert Moss
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3331/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23381

[asterisk-dev] [Code Review] 3330: Testsuite: e( ) Options BridgeWait Application

2014-03-11 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3330/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23355