Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 13 Mar 2014, at 23:34, Matthew Jordan wrote: > (1) This is not "new" functionality - in the sense that we have not > written some amazing new functionality in either the core or a > res_pjsip* module and only want to use it one place. PJSIP itself > already provides DNS resolution. We just wa

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 13 Mar 2014, at 22:13, Sean Bright wrote: > On 3/13/2014 4:42 PM, Paul Belanger wrote: >> +1 with Dan. Comments aside on DNS functionality (I have opinions but >> sitting this one out). Any functionality should be channel agnostic. >> I too am a little concern'd that statement seems to have

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 13 Mar 2014, at 21:42, Paul Belanger wrote: > On Thu, Mar 13, 2014 at 4:15 PM, Dan Austin wrote: >> Matt wrote: >> >> Not including this change does not seem to buy us anything, save for some >> semblance of architectural purity. While I would love for there to be only >> one way to perform

Re: [asterisk-dev] [Code Review] 3350: Add AES-GCM support for SRTP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3350/#review11199 --- Ship it! Ship It! - Matt Jordan On March 13, 2014, 12:54 p.

Re: [asterisk-dev] [Code Review] 3329: AGI Exit Status Test

> On March 13, 2014, 6:13 p.m., Mark Michelson wrote: > > One thing I notice about this test is that it is structured to call the > > first extension, then when that finishes, call the second, then when that > > finishes, call the third, etc. > > > > Since no call depends on any of the previou

Re: [asterisk-dev] magic number 128- for concurrent meetme monitoring calls.

On Thu, Mar 13, 2014 at 6:54 PM, Richard Mudgett wrote: > > > > On Thu, Mar 13, 2014 at 5:07 PM, beiyan jin wrote: >> >> In my load test calls, >> 1. each call has two parties connected by meetme conference. >> 2. Each call is recorded by monitor. >> >> For every load test, before the number of c

Re: [asterisk-dev] [Code Review] 3329: AGI Exit Status Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3329/#review11196 --- One thing I notice about this test is that it is structured to

Re: [asterisk-dev] magic number 128- for concurrent meetme monitoring calls.

On Thu, Mar 13, 2014 at 5:07 PM, beiyan jin wrote: > In my load test calls, > 1. each call has two parties connected by meetme conference. > 2. Each call is recorded by monitor. > > For every load test, before the number of concurrent calls reach 128, > everything is fine. But after 128, newly st

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

> On March 13, 2014, 10:31 a.m., Olle E Johansson wrote: > > We really should NOT add this code. Instead, we should clean up the code so > > all of Asterisk use the same resolver and relies on the system > > configuration. Having a separate DNS resolver, maybe even using a separate > > DNS ser

[asterisk-dev] [Code Review] 3353: testsuite: Test for receiving Play/Record start and stop events on ARI bridge playback/recording.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3353/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson. Bu

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On Thu, Mar 13, 2014 at 4:13 PM, Sean Bright wrote: > On 3/13/2014 4:42 PM, Paul Belanger wrote: > > +1 with Dan. Comments aside on DNS functionality (I have opinions but > sitting this one out). Any functionality should be channel agnostic. > I too am a little concern'd that statement seems to h

Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated March 13, 2014, 4:27 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

> On March 13, 2014, 7:32 p.m., rmudgett wrote: > > /branches/12/bridges/bridge_softmix.c, line 662 > > > > > > Doing this will require you to deal with the action running on all > > other channels in the bridge.

Re: [asterisk-dev] version.c generation

Michal Rybárik Thursday, March 13, 2014 4:03 PM Hello, how and when is main/version.c generated ? I checked out branch-11 svn, compiled, packaged for debian, and now I realized that "core show version" is diffent than version that I got from SVN. main/version.c static

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/ --- (Updated March 13, 2014, 9:34 p.m.) Review request for Asterisk Developers

[asterisk-dev] magic number 128- for concurrent meetme monitoring calls.

In my load test calls, 1. each call has two parties connected by meetme conference. 2. Each call is recorded by monitor. For every load test, before the number of concurrent calls reach 128, everything is fine. But after 128, newly started calls get dropped. Both CPU and memory are ok in the linu

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/#review11193 --- /branches/12/include/asterisk/frame.h

Re: [asterisk-dev] [Code Review] 3330: Testsuite: e( ) Options BridgeWait Application

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3330/#review11195 --- Ship it! Ship It! - Mark Michelson On March 11, 2014, 11:10

Re: [asterisk-dev] [Code Review] 3328: Agent Acknowledgement Nominal and Error Tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3328/#review11194 --- Ship it! Ship It! - Mark Michelson On March 11, 2014, 7:48

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 3/13/2014 4:42 PM, Paul Belanger wrote: +1 with Dan. Comments aside on DNS functionality (I have opinions but sitting this one out). Any functionality should be channel agnostic. I too am a little concern'd that statement seems to have changed. In order to make this "channel agnostic" you h

[asterisk-dev] version.c generation

Hello, how and when is main/version.c generated ? I checked out branch-11 svn, compiled, packaged for debian, and now I realized that "core show version" is diffent than version that I got from SVN. main/version.c static const char asterisk_version[] = "SVN-branch-11-r410490M"; ipfon-test*CL

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/#review11191 --- test_sorcery.c also calls ast_sorcery_apply_config() and one of

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On Thu, Mar 13, 2014 at 4:15 PM, Dan Austin wrote: > Matt wrote: > > Not including this change does not seem to buy us anything, save for some > semblance of architectural purity. While I would love for there to be only > one way to perform DNS resolution, that feels like a long term goal - and >

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11181 --- /branches/11/main/format.c

Re: [asterisk-dev] [Code Review] 3321: media_formats: Move dialplan functions over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3321/#review11190 --- Ship it! Ship It! - Kevin Harwell On March 8, 2014, 11:36 a

Re: [asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3322/#review11189 --- /team/group/media_formats-reviewed/res/res_musiconhold.c

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

Matt wrote: Not including this change does not seem to buy us anything, save for some semblance of architectural purity. While I would love for there to be only one way to perform DNS resolution, that feels like a long term goal – and sacrificing the practicality of delivering a feature that a

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

> On March 13, 2014, 4:31 p.m., Olle E Johansson wrote: > > We really should NOT add this code. Instead, we should clean up the code so > > all of Asterisk use the same resolver and relies on the system > > configuration. Having a separate DNS resolver, maybe even using a separate > > DNS serv

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/#review11187 --- /branches/12/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 3336: ARI: Ensure ChannelEnteredBridge messages get to the managing application

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3336/ --- (Updated March 13, 2014, 2:30 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

> On March 13, 2014, 12:43 p.m., rmudgett wrote: > > You need to add cases to the switches that handle AST_FRAME_BRIDGE_ACTION > > in frame.c and bridge_softmix.c. It is probably best if the > > AST_FRAME_BRIDGE_ACTION_SYNC case is next to the AST_BRIDGE_ACTION case. > > > > The main difficul

Re: [asterisk-dev] [Code Review] 3331: Allows app_chanspy to whisper to a spyee's bridged peer (barge) even if the bridged party answers after initial spy invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3331/ --- (Updated March 13, 2014, 7:24 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

> On March 13, 2014, 10:31 a.m., Olle E Johansson wrote: > > We really should NOT add this code. Instead, we should clean up the code so > > all of Asterisk use the same resolver and relies on the system > > configuration. Having a separate DNS resolver, maybe even using a separate > > DNS ser

Re: [asterisk-dev] [Code Review] 3327: Test for endmarked users in confbridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3327/#review11184 --- Ship it! Ship It! - Mark Michelson On March 11, 2014, 7:45

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/ --- (Updated March 13, 2014, 7 p.m.) Review request for Asterisk Developers an

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

> On March 13, 2014, 5:43 p.m., rmudgett wrote: > > You need to add cases to the switches that handle AST_FRAME_BRIDGE_ACTION > > in frame.c and bridge_softmix.c. It is probably best if the > > AST_FRAME_BRIDGE_ACTION_SYNC case is next to the AST_BRIDGE_ACTION case. > > > > The main difficult

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11180 --- Ship it! Short of protecting the global interfaces container p

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 13, 2014, 7:41 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3325: res_mwi_external: Clear the stasis cache entry when the external MWI is deleted.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3325/ --- (Updated March 13, 2014, 1:23 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3350: Add AES-GCM support for SRTP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3350/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22832 https://i

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/#review11177 --- You need to add cases to the switches that handle AST_FRAME_BRI

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/ --- (Updated March 13, 2014, 12:37 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3325: res_mwi_external: Clear the stasis cache entry when the external MWI is deleted.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3325/#review11179 --- Ship it! My only issues are with documentation. Otherwise, it'

[asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23343 https://i

Re: [asterisk-dev] [Code Review] 3339: Testsuite: ARI test for playback of audio to a channel in a bridge.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3339/#review11178 --- /asterisk/trunk/tests/rest_api/playback/to_channel_in_bridge/p

[asterisk-dev] SS7 point code clustering

Hello everybody, I would like to set up SS7 point code clustering with libSS7 in Asterisk. As far as i know, some work has already been done for this, can you please share me the pointers on how to start this project. Any other relevant information is also welcome. Regards, Nitesh Bansal --

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/#review11176 --- Ship it! Ship It! - Joshua Colp On March 13, 2014, 4:11 p.m

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/ --- (Updated March 13, 2014, 11:11 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

> On March 13, 2014, 7:32 a.m., Joshua Colp wrote: > > /branches/12/res/res_pjsip/config_transport.c, lines 505-518 > > > > > > Why not just use ast_asprintf for both of the to_str functions? Because... sometimes I

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic (also recording)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3340/#review11174 --- Ship it! Ship It! /branches/12/res/ari/resource_bridges.c

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic (also recording)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3340/ --- (Updated March 13, 2014, 10:57 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3340/ --- (Updated March 13, 2014, 10:56 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/#review11173 --- Ship it! Excellent job fixing the problem! A note to whoever

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3340/#review11171 --- The code changes themselves look good to me. I suggest taking y

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11170 --- We really should NOT add this code. Instead, we should clean up

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/#review11166 --- Before this patch goes any further, it needs adequate testing.

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/ --- (Updated March 13, 2014, 2:53 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

> On March 13, 2014, 2:21 p.m., Matt Jordan wrote: > > Before this patch goes any further, it needs adequate testing. > > > > While posting a patch with 'it compiles' is a bare minimum requirement, for > > it to be included seriously for inclusion the "How this was tested" field > > should be

Re: [asterisk-dev] [Code Review] 3331: Allows app_chanspy to whisper to a spyee's bridged peer (barge) even if the bridged party answers after initial spy invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3331/#review11167 --- /trunk/apps/app_chanspy.c

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3340/#review11165 --- {quote} I only receive the PlaybackStarted and PlaybackFinished

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/#review11164 --- /branches/12/res/res_pjsip/config_transport.c

Re: [asterisk-dev] [Code Review] 3323: res_pjsip: Update PJSIP tests that evaluate ToS settings to go back to anticipating decimal values. Also fix another failure that is more recent.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3323/#review11163 --- Ship it! Ship It! - Joshua Colp On March 10, 2014, 7:13 p.m

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

- Original Message - > From: "Olle E. Johansson" > To: "Asterisk Developers Mailing List" > So we have yet another internal resolver? Is that a good thing? Why > are we not using the system resolver? > > We need to have some direction here. I think adding yet another DNS > resolver is b

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 13 Mar 2014, at 12:06, Joshua Colp wrote: > Olle E. Johansson wrote: >> >> On 13 Mar 2014, at 11:42, Joshua Colp > > wrote: >> >>> In case others are wondering as Olle was: >>> >>> PJLIB-Util (part of pjproject) provides a DNS client which can >>> optionall

Re: [asterisk-dev] [Code Review] 3345: Testsuite: Ensure that a PJSIP endpoint that receives unsolcited MWI for a mailbox cannot subscribe to an AOR that provides MWI for that mailbox

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3345/#review11162 --- Ship it! Ship It! - Joshua Colp On March 12, 2014, 9:52 p.m

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3340/#review11161 --- /branches/12/res/ari/resource_bridges.c

Re: [asterisk-dev] [Code Review] 3341: Realtime: Be more consistent with how returns of store and update operations are treated.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3341/#review11160 --- Ship it! Ship It! - Joshua Colp On March 12, 2014, 6:26 p.m

Re: [asterisk-dev] [Code Review] 3344: PJSIP MWI: Prevent endpoints from subscribing to AORs that provide MWI for a mailbox for which they are already receiving unsolicited MWI.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3344/#review11159 --- Ship it! Ship It! - Joshua Colp On March 12, 2014, 9:52 p.m

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11158 --- /branches/12/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11157 --- Ship it! Looks good to me. Now if only we could have it autom

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

Olle E. Johansson wrote: On 13 Mar 2014, at 11:42, Joshua Colp mailto:reviewbo...@asterisk.org>> wrote: In case others are wondering as Olle was: PJLIB-Util (part of pjproject) provides a DNS client which can optionally (but is highly suggested) to be used with PJSIP. It provides asynchronous

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 13 Mar 2014, at 11:42, Joshua Colp wrote: > In case others are wondering as Olle was: > > PJLIB-Util (part of pjproject) provides a DNS client which can optionally > (but is highly suggested) to be used with PJSIP. It provides asynchronous > DNS, SRV lookups, multiple record support, etc.

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

Olle E. Johansson wrote: On 12 Mar 2014, at 19:53, Joshua Colp mailto:reviewbo...@asterisk.org>> wrote: This change adds a configuration option for setting nameservers to be used by the PJSIP DNS client. If this option is not set then the system nameservers are retrieved and used instead. Thi

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/ --- (Updated March 13, 2014, 10:42 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

Olle E. Johansson wrote: On 12 Mar 2014, at 19:53, Joshua Colp mailto:reviewbo...@asterisk.org>> wrote: This change adds a configuration option for setting nameservers to be used by the PJSIP DNS client. If this option is not set then the system nameservers are retrieved and used instead. Thi

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/ --- (Updated March 13, 2014, 10:09 a.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23351 https://i

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

On 12 Mar 2014, at 19:53, Joshua Colp wrote: > This change adds a configuration option for setting nameservers to be used by > the PJSIP DNS client. If this option is not set then the system nameservers > are retrieved and used instead. > > This also allows the nameservers to be changed by do