Re: [asterisk-dev] [Code Review] 3381: res_pjsip: Fix contact authenticate_qualify endpoint lookup when qualifing a contact.

2014-03-21 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3381/ --- (Updated March 21, 2014, 8:16 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3381: res_pjsip: Fix contact authenticate_qualify endpoint lookup when qualifing a contact.

2014-03-21 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3381/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23254 https://i

Re: [asterisk-dev] [Code Review] 3361: rest_api/bridges/subscription: Update test to accomodate r410528

2014-03-21 Thread Jonathan Rose
> On March 21, 2014, 2:13 p.m., Jonathan Rose wrote: > > Ship It! Following kmoore's suggestions that is. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3361/#review11318 --

Re: [asterisk-dev] [Code Review] 3361: rest_api/bridges/subscription: Update test to accomodate r410528

2014-03-21 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3361/#review11318 --- Ship it! Ship It! - Jonathan Rose On March 14, 2014, 4:23 p

Re: [asterisk-dev] [Code Review] 3361: rest_api/bridges/subscription: Update test to accomodate r410528

2014-03-21 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3361/#review11317 --- "The last verification broke because we now ensure that applica

Re: [asterisk-dev] [Code Review] 3380: ARI: When a channel controlled by stasis is removed from a bridge, automatically created subscriptions to the bridge aren't removed.

2014-03-21 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3380/#review11316 --- /branches/12/res/res_stasis.c

[asterisk-dev] [Code Review] 3380: ARI: When a channel controlled by stasis is removed from a bridge, automatically created subscriptions to the bridge aren't removed.

2014-03-21 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3380/ --- Review request for Asterisk Developers, Matt Jordan and opticron. Reposito

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-21 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11314 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

2014-03-21 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3322/#review11315 --- Ship it! Ship It! - Kevin Harwell On March 17, 2014, 7:45 a

Re: [asterisk-dev] [Code Review] 3368: chan_sip segfault: INTERNAL_OBJ at astobj2.c:120

2014-03-21 Thread one47
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3368/ --- (Updated March 21, 2014, 4:54 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP

2014-03-21 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated March 21, 2014, 9:20 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-21 Thread Geert Van Pamel
> On March 21, 2014, 6:05 a.m., Corey Farrell wrote: > > /trunk/channels/sip/reqresp_parser.c, line 131 > > > > > > I'm getting a segfault with the test "tel:911". userinfo == NULL > > causes strchr to segfault on

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-21 Thread Geert Van Pamel
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 21, 2014, 8:32 a.m.) Review request for Asterisk Developers