On March 21, 2014, 7:01 p.m., Corey Farrell wrote:
/trunk/channels/sip/reqresp_parser.c, line 130
https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130
This needs to blank both variables:
userinfo = uri = ;
Geert Van Pamel wrote:
We return the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3318/
---
(Updated March 23, 2014, 6:49 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3322/
---
(Updated March 23, 2014, 6:48 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3319/
---
(Updated March 23, 2014, 6:50 a.m.)
Status
--
This change has been
On March 21, 2014, 6:01 p.m., Corey Farrell wrote:
/trunk/channels/sip/reqresp_parser.c, line 130
https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130
This needs to blank both variables:
userinfo = uri = ;
Geert Van Pamel wrote:
We return the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/#review11331
---
Looks pretty much good to go. A few remarks below.
And a last
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11333
---
Minor nits. Still waiting for someone to test this.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3349/#review11335
---
Ship it!
Ship It!
- Corey Farrell
On March 22, 2014, 9:08
On March 21, 2014, 2:01 p.m., Corey Farrell wrote:
/trunk/channels/sip/reqresp_parser.c, line 130
https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130
This needs to blank both variables:
userinfo = uri = ;
Geert Van Pamel wrote:
We return the
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote:
I don't see what happens with the phone-context argument. Shouldn't we pass
that on as a channel variable?
Geert Van Pamel wrote:
We return this into the hostport.
Geert Van Pamel wrote:
According to RFC 3966
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3382/
---
Review request for Asterisk Developers, Joshua Colp and rmudgett.
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote:
I don't see what happens with the phone-context argument. Shouldn't we pass
that on as a channel variable?
Geert Van Pamel wrote:
We return this into the hostport.
Geert Van Pamel wrote:
According to RFC 3966
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3382/#review11338
---
To disable AO2_DEBUG / AST_DEVMODE could we just modify '#if
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3382/
---
(Updated March 23, 2014, 4:45 p.m.)
Review request for Asterisk
14 matches
Mail list logo