Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread Olle E Johansson
On March 21, 2014, 7:01 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, line 130 https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130 This needs to blank both variables: userinfo = uri = ; Geert Van Pamel wrote: We return the

Re: [asterisk-dev] [Code Review] 3318: media_formats: Move bridges over.

2014-03-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3318/ --- (Updated March 23, 2014, 6:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

2014-03-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3322/ --- (Updated March 23, 2014, 6:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- (Updated March 23, 2014, 6:50 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread wdoekes
On March 21, 2014, 6:01 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, line 130 https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130 This needs to blank both variables: userinfo = uri = ; Geert Van Pamel wrote: We return the

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-23 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/#review11331 --- Looks pretty much good to go. A few remarks below. And a last

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

2014-03-23 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/#review11333 --- Minor nits. Still waiting for someone to test this.

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11335 --- Ship it! Ship It! - Corey Farrell On March 22, 2014, 9:08

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread Corey Farrell
On March 21, 2014, 2:01 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, line 130 https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130 This needs to blank both variables: userinfo = uri = ; Geert Van Pamel wrote: We return the

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread Olle E Johansson
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? Geert Van Pamel wrote: We return this into the hostport. Geert Van Pamel wrote: According to RFC 3966

[asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3382/ --- Review request for Asterisk Developers, Joshua Colp and rmudgett.

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread Geert Van Pamel
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? Geert Van Pamel wrote: We return this into the hostport. Geert Van Pamel wrote: According to RFC 3966

Re: [asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-23 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3382/#review11338 --- To disable AO2_DEBUG / AST_DEVMODE could we just modify '#if

Re: [asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3382/ --- (Updated March 23, 2014, 4:45 p.m.) Review request for Asterisk