Re: [asterisk-dev] [Code Review] 3377: ref count logs: Redo structure of log file, provide a python debugging tool

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3377/#review11422 --- A few python issues: /branches/1.8/contrib/scripts/refcounter

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

> On March 28, 2014, 4:15 a.m., Matt Jordan wrote: > > I'm going to go ahead and push this into 1.8, 11, and 12. > > Matt Jordan wrote: > Scratch that, I'll block this on 12. I've submitted a proper patch for trunk (and 12) version here: https://reviewboard.asterisk.org/r/3335/. The only d

[asterisk-dev] Enable dtls_cfg

Hi I am having problems using DTLS-SRTP and trying to debug why I am getting this error [Mar 26 14:48:23] WARNING[31977][C-0009]: chan_sip.c:10657 process_sdp: Can't provide secure audio requested in SDP offer In chan_sip.c Tracing through the code, at this point the value of p->dtls_cf

Re: [asterisk-dev] Enable dtls_cfg

jaflong jaflong wrote: Hi I am having problems using DTLS-SRTP and trying to debug why I am getting this error [Mar 26 14:48:23] WARNING[31977][C-0009]: chan_sip.c:10657 process_sdp: Can't provide secure audio requested in SDP offer In chan_sip.c Tracing through the code, at this point

Re: [asterisk-dev] Enable dtls_cfg

Hi Joshua, I did have this set dtlsenable=yes dtlsverify=no dtlsrekey=60 dtlscertfile=/etc/asterisk/certs/asterisk.pem dtlsprivatekey=/etc/asterisk/certs/asterisk.key dtlscafile=/etc/asterisk/certs/asterisk.pem dtlscipher=ALL dtlssetup=actpass Do you think the the SHA-256 issue was the cause o

Re: [asterisk-dev] Enable dtls_cfg

jaflong jaflong wrote: Hi Joshua, I did have this set dtlsenable=yes dtlsverify=no dtlsrekey=60 dtlscertfile=/etc/asterisk/certs/asterisk.pem dtlsprivatekey=/etc/asterisk/certs/asterisk.key dtlscafile=/etc/asterisk/certs/asterisk.pem dtlscipher=ALL dtlssetup=actpass Do you think the the SHA-2

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3402/ --- (Updated March 28, 2014, 9:19 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/#review11429 --- Ship it! This one is good to go for trunk. - wdoekes On Mar

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated March 28, 2014, 10:56 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/ --- (Updated March 28, 2014, 12:09 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3377: ref count logs: Redo structure of log file, provide a python debugging tool

> On March 28, 2014, 4:15 a.m., wdoekes wrote: > > /branches/1.8/contrib/scripts/refcounter.py, lines 37-38 > > > > > > print >>sys.stderr, "blah" I had considered suggesting this, but then I thought about redirecti

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11432 --- ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

> On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: > > I don't see what happens with the phone-context argument. Shouldn't we pass > > that on as a channel variable? > > Geert Van Pamel wrote: > We return this into the hostport. > > Geert Van Pamel wrote: > According to RFC 3966 p

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

> On March 27, 2014, 4:45 p.m., Kevin Harwell wrote: > > ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample, lines 10-12 > > > > > > Maybe make this a little more specific like 'ami-id' > > opticron wrote: >

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

> On March 22, 2014, 10:39 a.m., Olle E Johansson wrote: > > I don't see what happens with the phone-context argument. Shouldn't we pass > > that on as a channel variable? > > Geert Van Pamel wrote: > We return this into the hostport. > > Geert Van Pamel wrote: > According to RFC 3966

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3402/ --- (Updated March 28, 2014, 11:16 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3377: ref count logs: Redo structure of log file, provide a python debugging tool

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3377/#review11418 --- Do we want to produce a warning if someone tries writing to ref

Re: [asterisk-dev] [Code Review] 3207: HEP: Add a Homer Encapsulation Protocol (HEP) v3 capture agent module and a packet logger for PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3207/ --- (Updated March 28, 2014, 1:09 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

> On March 27, 2014, 4:45 p.m., Kevin Harwell wrote: > > ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample, lines 10-12 > > > > > > Maybe make this a little more specific like 'ami-id' Using "id" for the AMI

Re: [asterisk-dev] [Code Review] 3379: ARI: Make bridges/{bridgeId}/play queue sound files if sounds are already playing on the bridge instead of playing them simultaneously as they are called

> On March 27, 2014, 5:14 p.m., Mark Michelson wrote: > > /branches/12/res/ari/resource_bridges.c, lines 502-508 > > > > > > A few things here. > > > > First and foremost, this isn't guaranteed to work. Con

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

> On March 28, 2014, 4:59 p.m., Mark Michelson wrote: > > ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py, lines 330-331 > > > > > > I think if you use shutil.move2 instead of shutil.move, you won't have

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3402/#review11427 --- Ship it! While I'm not a fan of putting in changes that fix pr

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/ --- (Updated March 28, 2014, 6:28 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3377: ref count logs: Redo structure of log file, provide a python debugging tool

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3377/#review11435 --- My comments appear in reverse order due to filename sorting. P

Re: [asterisk-dev] [Code Review] 3379: ARI: Make bridges/{bridgeId}/play queue sound files if sounds are already playing on the bridge instead of playing them simultaneously as they are called

> On March 27, 2014, 5:14 p.m., Mark Michelson wrote: > > /branches/12/res/ari/resource_bridges.c, lines 502-508 > > > > > > A few things here. > > > > First and foremost, this isn't guaranteed to work. Con

Re: [asterisk-dev] [Code Review] 3379: ARI: Make bridges/{bridgeId}/play queue sound files if sounds are already playing on the bridge instead of playing them simultaneously as they are called

> On March 27, 2014, 4:20 p.m., Matt Jordan wrote: > > /branches/12/res/res_ari_bridges.c, lines 950-956 > > > > > > If it isn't already noted, this needs to be in the CHANGES file. > > > > Upon examining the

Re: [asterisk-dev] [Code Review] 3399: PJSIP DTMF INFO Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3399/ --- (Updated March 28, 2014, 7:54 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3379: ARI: Make bridges/{bridgeId}/play queue sound files if sounds are already playing on the bridge instead of playing them simultaneously as they are called

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3379/ --- (Updated March 28, 2014, 3:14 p.m.) Review request for Asterisk Developers

[asterisk-dev] Asterisk 11.9.0-rc1 Now Available

The Asterisk Development Team has announced the first release candidate of Asterisk 11.9.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.9.0-rc1 resolves several issues reported by the community and wo

[asterisk-dev] Asterisk 1.8.27.0-rc1 Now Available

The Asterisk Development Team has announced the first release candidate of Asterisk 1.8.27.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 1.8.27.0-rc1 resolves several issues reported by the community an

[asterisk-dev] Asterisk 12.2.0-rc1 Now Available

The Asterisk Development Team has announced the first release candidate of Asterisk 12.2.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.2.0-rc1 resolves several issues reported by the community and wo

Re: [asterisk-dev] [Code Review] 3353: testsuite: Test for receiving Play/Record start and stop events on ARI bridge playback/recording.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3353/ --- (Updated March 28, 2014, 3:29 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3379: ARI: Make bridges/{bridgeId}/play queue sound files if sounds are already playing on the bridge instead of playing them simultaneously as they are called

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3379/#review11438 --- /branches/12/res/ari/resource_bridges.c

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.9.1 Now Available

The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.9.1 DAHDI-Tools-v2.9.1 dahdi-linux-complete-2.9.1+2.9.1 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux http://downloads.asterisk.org/pub/telephony/dahdi-tools

[asterisk-dev] [Code Review] 3406: AGI/Manager: Prevent multiple Newexten events from occuring from AGI application changes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3406/ --- Review request for Asterisk Developers, Benjamin Keith Ford and Matt Jordan.

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/ --- (Updated March 28, 2014, 8:44 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3406: AGI/Manager: Prevent multiple Newexten events from occuring from AGI application changes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3406/#review11439 --- Ship it! I didn't see any CDR, dial, or unit test failures eit

[asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://i