Re: [asterisk-dev] [Code Review] 3389: media_formats: Move chan_nbs, chan_phone, and chan_vpb over.

2014-03-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3389/ --- (Updated March 30, 2014, 7:12 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3390: media_formats: Move chan_motif, chan_jingle, and chan_gtalk over.

2014-03-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3390/ --- (Updated March 30, 2014, 7:13 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3387: media_formats: Move chan_dahdi over.

2014-03-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3387/ --- (Updated March 30, 2014, 7:15 a.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-03-30 Thread Shlomi Gutman
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3409/ --- Review request for Asterisk Developers. Bugs: ASTERISK-16115 https://i

Re: [asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

2014-03-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3408/#review11442 --- Ship it! Ship It! - Matt Jordan On March 29, 2014, 2:21 p.m

Re: [asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

2014-03-30 Thread Matt Jordan
> On March 30, 2014, 1:33 p.m., Matt Jordan wrote: > > Ship It! If you'd like to rename it, that's fine. It doesn't appear as if anything else would be using the current name (since it wouldn't link...) - Matt --- This is an automatica

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-03-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3409/#review11445 --- There are a large number of coding guideline violations in this

Re: [asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

2014-03-30 Thread Corey Farrell
> On March 30, 2014, 2:33 p.m., Matt Jordan wrote: > > Ship It! > > Matt Jordan wrote: > If you'd like to rename it, that's fine. It doesn't appear as if anything > else would be using the current name (since it wouldn't link...) > > app_voicemail (now that I've modified it) is the on

Re: [asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

2014-03-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3408/ --- (Updated March 30, 2014, 3:05 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

2014-03-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3408/#review11447 --- Ship it! Ship It! - Matt Jordan On March 30, 2014, 2:05 p.m