Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-03-31 Thread Shlomi Gutman
On March 30, 2014, 6:44 p.m., Matt Jordan wrote: There are a large number of coding guideline violations in this patch. Please review the Coding Guidelines on the Asterisk wiki [1] and re-submit this patch. Please also clean up any extraneous white space in your patch (which will

[asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Johan Wilfer
Hi! I've spent some time scratching my head thinking about video conferencing and how to go about it. Right now we use Meetme as a audio bridge for pstn connectivity and so on. But our users ask for video and screen sharing. I can see four distinct ways to go about this: 1. Asterisk right

Re: [asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Olle E. Johansson
On 31 Mar 2014, at 12:47, Johan Wilfer li...@jttech.se wrote: Hi! I've spent some time scratching my head thinking about video conferencing and how to go about it. Right now we use Meetme as a audio bridge for pstn connectivity and so on. But our users ask for video and screen sharing. I

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
On March 30, 2014, 12:12 a.m., Corey Farrell wrote: Do you have any ideas on how this will effect CPU load? I was thinking of this as an example: A system with 1 inbound call per second, each call lasting 5 minutes. Every inbound channel gets a 60 second timer for beep Playback

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- (Updated March 31, 2014, 12:56 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- (Updated March 31, 2014, 1:14 p.m.) Review request for Asterisk

Re: [asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Johan Wilfer
2014-03-31 13:41, Olle E. Johansson skrev: On 31 Mar 2014, at 12:47, Johan Wilfer li...@jttech.se wrote: 4. Jitsi Videobridge - multiple video streams from server, but send only your stream to the server. The jitsi videobridge the distributes the stream to all other clients. This will eat a

Re: [asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Lorenzo Miniero
2014-03-31 15:17 GMT+02:00 Johan Wilfer li...@jttech.se: 2014-03-31 13:41, Olle E. Johansson skrev: On 31 Mar 2014, at 12:47, Johan Wilfer li...@jttech.se wrote: 4. Jitsi Videobridge - multiple video streams from server, but send only your stream to the server. The jitsi videobridge the

[asterisk-dev] [Code Review] 3410: media_formats: Move chan_multicast_rtp, chan_console, app_jack, and chan_ooh323 over.

2014-03-31 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3410/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread jamuel
On March 30, 2014, 12:12 a.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, line 206 https://reviewboard.asterisk.org/r/3362/diff/4/?file=56930#file56930line206 state-last_hook is never pre-initialized to ast_tvnow(), so hooks would always trigger on first check after

Re: [asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Dan Cropp
I've been lobbying hardware manufacturers to provide video cards for Asterisk where we can have licenses to do transcoding and reformatting, so far with no success. I passed this onto someone in our hardware department to look into. I do worry about the thought of hardware for a video

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
On March 30, 2014, 12:12 a.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, line 206 https://reviewboard.asterisk.org/r/3362/diff/4/?file=56930#file56930line206 state-last_hook is never pre-initialized to ast_tvnow(), so hooks would always trigger on first check after

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- (Updated March 31, 2014, 4:11 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread jamuel
On March 30, 2014, 12:12 a.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, line 206 https://reviewboard.asterisk.org/r/3362/diff/4/?file=56930#file56930line206 state-last_hook is never pre-initialized to ast_tvnow(), so hooks would always trigger on first check after

Re: [asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Bryant Zimmerman
Sangoma has trans coding solutions that allow for use with virtual machines. They had video codecs in their road map. I am not sure if they have them yet? Thanks Bryant Zimmerman (ZK Tech Inc.) 616-855-1030 Ext. 2003 From: Dan Cropp

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Corey Farrell
On March 29, 2014, 8:12 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, line 299 https://reviewboard.asterisk.org/r/3362/diff/4/?file=56930#file56930line299 Can we detach the audio hook here? I know we escape the hook callback very early but it still feels wasteful

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/#review11455 --- /trunk/funcs/func_periodic_hook.c

Re: [asterisk-dev] [Code Review] 3320: media_formats: Move format modules over.

2014-03-31 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3320/#review11456 --- Ship it! A couple of nits that may not need to even be

[asterisk-dev] DAHDI-Linux v2.9.1.1 Now Available

2014-03-31 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.9.1.1 dahdi-linux-complete-2.9.1.1+2.9.1 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux http://downloads.asterisk.org/pub/telephony/dahdi-linux-complete Fix

Re: [asterisk-dev] Asterisk and video conferencing

2014-03-31 Thread Johan Wilfer
2014-03-31 15:33, Lorenzo Miniero skrev: I don't think there's an easy way to do that except by placing multiple calls (e.g., N+1, 1 for sending your audio/video and receiving the mixed audio, N for receiving each of the remote videos) and heavily customizing MeetMe/ConfBridge for the purpose.

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 136-139 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line136 I'm unsure the purpose of beep in macro_arg. Also think chan_name + hook_id can never be close

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- (Updated March 31, 2014, 8:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread rmudgett
On March 31, 2014, 12:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't