[asterisk-dev] UDP/TLS/RTP/SAVPF to RTP/SAVPF

2014-04-04 Thread jaflong jaflong
Hi List, Can anyone please advise where sdp m = line can be modified in the source code (chan_sip.c) for example the I want to change m=audio 30490 UDP/TLS/RTP/SAVPF 0 126 to m=audio 30490 RTP/SAVPF 0 126 UDP/TLS/RTP/SAVPF to RTP/SAVPF on the response invite where in the code can this be d

Re: [asterisk-dev] [Code Review] 3413: media_formats: move app.c and file.c over

2014-04-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3413/#review11497 --- Ship it! Ship It! - Joshua Colp On April 2, 2014, 10:02 p.m

Re: [asterisk-dev] UDP/TLS/RTP/SAVPF to RTP/SAVPF

2014-04-04 Thread Lorenzo Miniero
This has been discussed several times, actually. Asterisk does the right thing, because the standard mandates UDP/TLS/RTP/SAVPF when DTLS is involved. I don't know why browsers only use RTP/SAVPF instead. That said, it's something that you can easily fix directly in JavaScript. Lorenzo 2014-04-04

Re: [asterisk-dev] [Code Review] 3415: bridging: Ensure proper locking during snapshot creation

2014-04-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3415/ --- (Updated April 4, 2014, 9:31 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3398: TestSuite: Fix tests affected by 411086

2014-04-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3398/ --- (Updated April 4, 2014, 9:32 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-04 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- (Updated April 4, 2014, 3:42 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/#review11498 --- Ship it! All my concerns are addressed. - Corey Farrell On

Re: [asterisk-dev] [Code Review] 3411: Add some asserts that were handy when looking for a stasis cache problem.

2014-04-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3411/ --- (Updated April 4, 2014, 12:53 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3414: internal_timing: Remove the option and always make it enabled if a timing module is loaded.

2014-04-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3414/ --- (Updated April 4, 2014, 1:32 p.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 3417: Add AMI events for all device state and presence state changes

2014-04-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3417/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 3418: Test the DeviceStateChange and PresenceStateChange AMI events

2014-04-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3418/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 3413: media_formats: move app.c and file.c over

2014-04-04 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3413/ --- (Updated April 4, 2014, 3:21 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3412: testsuite: Add call setup tracking to masquerade supertest.

2014-04-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3412/#review11501 --- Ship it! Ship It! - Mark Michelson On April 3, 2014, 8:45 p

Re: [asterisk-dev] [Code Review] 3417: Add AMI events for all device state and presence state changes

2014-04-04 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3417/#review11502 --- Ship it! Ship It! - Kevin Harwell On April 4, 2014, 2:38 p.

[asterisk-dev] [Code Review] 3419: Test for PJSIP fast picture update

2014-04-04 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3419/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23562 https://i

Re: [asterisk-dev] [Code Review] 3418: Test the DeviceStateChange and PresenceStateChange AMI events

2014-04-04 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3418/#review11503 --- Ship it! - Kevin Harwell On April 4, 2014, 2:38 p.m., Mark M

Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP

2014-04-04 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 4, 2014, 5:44 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP

2014-04-04 Thread jbigelow
> On April 3, 2014, 2:24 p.m., Mark Michelson wrote: > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml, > > lines 46-54 > > > > > > The comments here contradict w

[asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

2014-04-04 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23218 https://i

Re: [asterisk-dev] [Code Review] 3412: testsuite: Add call setup tracking to masquerade supertest.

2014-04-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3412/ --- (Updated April 4, 2014, 6:10 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

2014-04-04 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/ --- (Updated April 4, 2014, 11:15 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3421: Originated calls: Fix several originate call problems.

2014-04-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3421/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [svn-commits] rmudgett: branch 1.8 r411715 - in /branches/1.8: ./ channels/ configs/ includ...

2014-04-04 Thread Olle E. Johansson
On 04 Apr 2014, at 20:32, SVN commits to the Digium repositories wrote: > - case 'I': > - ast_set_flag(&ast_options, > AST_OPT_FLAG_INTERNAL_TIMING); > - break; Just checking... I would rather add a NOTICE log here that "i" is not needed an