[asterisk-dev] [Code Review] 3464: Sounds: Various new sound sets were missing from the makefile and menuselect options

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3464/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23550 https://i

[asterisk-dev] [Code Review] 3463: RFC: astobj2 cached objects (alternative to weak containers)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3463/ --- Review request for Asterisk Developers, George Joseph, Joshua Colp, and rmu

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11679 --- Ship it! My final finding is pretty minor and easily fixable b

Re: [asterisk-dev] [Code Review] 3448: res_pjsip: Handle reloading when permanent contacts exist and qualify is configured

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3448/ --- (Updated April 17, 2014, 5:49 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/ --- (Updated April 17, 2014, 5:21 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/ --- (Updated April 17, 2014, 5:17 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3379: ARI: Make bridges/{bridgeId}/play queue sound files if sounds are already playing on the bridge instead of playing them simultaneously as they are called

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3379/#review11678 --- Ship it! Ship It! - Mark Michelson On April 10, 2014, 9:59

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/ --- (Updated April 17, 2014, 4:57 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/#review11677 --- This wasn't committed yet. It just got tagged because the revie

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/ --- (Updated April 17, 2014, 4:47 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3427: ARI: Add tones playback resource

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3427/ --- (Updated April 17, 2014, 9:47 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 17, 2014, 4:06 p.m., Matt Jordan wrote: > > /branches/1.8/CHANGES, lines 15-25 > > > > > > Update this description to be explicit about what the settings are: > > > > If a peer is set with 'trust_

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11675 --- /branches/1.8/CHANGES

Re: [asterisk-dev] [Code Review] 3399: PJSIP DTMF INFO Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3399/ --- (Updated April 17, 2014, 4:05 p.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 3462: PJSIP: Allow for multiple contacts to be set in a single contact= line in an aor section of pjsip.conf

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3462/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11674 --- Also worth noting, it looks like we'll be just using legacy as

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/ --- (Updated April 17, 2014, 3:25 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3455: testsuite: Add chan_sip tests for sendrpid=pai/rpid tests (baseline and with trust_id_outbound)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3455/#review11673 --- Left out the notes in the new version description: == party=

Re: [asterisk-dev] [Code Review] 3455: testsuite: Add chan_sip tests for sendrpid=pai/rpid tests (baseline and with trust_id_outbound)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3455/ --- (Updated April 17, 2014, 3:07 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3426: Fix build failure on SmartOS / Illumos / SunOS

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3426/ --- (Updated April 17, 2014, 3:06 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3458: Testsuite: Off-Nominal Disa Bad Authentication Test

> On April 17, 2014, 6:39 p.m., Corey Farrell wrote: > > ./asterisk/trunk/tests/apps/disa/off-nominal/bad_auth/configs/ast1/extensions.conf, > > lines 7-26 > > > > > > These extensions appear to be unreachable. > >

Re: [asterisk-dev] [Code Review] 3441: testsuite: Add a test for TEL URI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3441/ --- (Updated April 17, 2014, 2:53 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3442: chan_sip: Add TELPHONECONTEXT channel variable for Request TEL URIs

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3442/ --- (Updated April 17, 2014, 2:51 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3457: DISA Test - Invalid Extension

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3457/ --- (Updated April 17, 2014, 7:51 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3459: DISA Test - No Context

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3459/ --- (Updated April 17, 2014, 7:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3458: Testsuite: Off-Nominal Disa Bad Authentication Test

> On April 17, 2014, 2:39 p.m., Corey Farrell wrote: > > ./asterisk/trunk/tests/apps/disa/off-nominal/bad_auth/configs/ast1/extensions.conf, > > lines 7-26 > > > > > > These extensions appear to be unreachable. For

Re: [asterisk-dev] [Code Review] 3442: chan_sip: Add TELPHONECONTEXT channel variable for Request TEL URIs

> On April 12, 2014, 1:21 a.m., Olle E Johansson wrote: > > /trunk/channels/chan_sip.c, line 8262 > > > > > > Sadly, I think we should name this SIPURIPHONECONTEXT or something that > > starts with SIP like SIPDOM

Re: [asterisk-dev] [Code Review] 3442: chan_sip: Add TELPHONECONTEXT channel variable for Request TEL URIs

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3442/ --- (Updated April 17, 2014, 2:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3460: DISA Test - No Authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3460/ --- (Updated April 17, 2014, 7:44 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3458: Testsuite: Off-Nominal Disa Bad Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3458/ --- (Updated April 17, 2014, 7:40 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3400: Nominal DISA Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3400/ --- (Updated April 17, 2014, 7:38 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3400: Nominal DISA Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3400/ --- (Updated April 17, 2014, 7:30 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3458: Testsuite: Off-Nominal Disa Bad Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3458/ --- (Updated April 17, 2014, 7:27 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3460: DISA Test - No Authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3460/#review11668 --- ./asterisk/trunk/tests/apps/disa/nominal/no_authentication/con

Re: [asterisk-dev] [Code Review] 3458: Testsuite: Off-Nominal Disa Bad Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3458/#review11665 --- ./asterisk/trunk/tests/apps/disa/off-nominal/bad_auth/configs/

Re: [asterisk-dev] [Code Review] 3457: DISA Test - Invalid Extension

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3457/#review11666 --- ./asterisk/trunk/tests/apps/disa/nominal/invalid_exten/configs

Re: [asterisk-dev] [Code Review] 3459: DISA Test - No Context

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3459/#review11667 --- ./asterisk/trunk/tests/apps/disa/nominal/no_context/configs/as

Re: [asterisk-dev] [Code Review] 3400: Nominal DISA Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3400/#review11664 --- ./asterisk/trunk/tests/apps/disa/nominal/authenticate/configs/

Re: [asterisk-dev] [Code Review] 3441: testsuite: Add a test for TEL URI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3441/#review11662 --- Ship it! Ship It! - opticron On April 11, 2014, 9:35 p.m.,

Re: [asterisk-dev] [Code Review] 3421: Originated calls: Fix several originate call problems.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3421/#review11661 --- Ship it! Ship It! - opticron On April 4, 2014, 8:46 p.m., r

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3447/#review11659 > --- > > > So going with the legacy idea wdoekes posted, I

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 17, 2014, 11:47 a.m., Jonathan Rose wrote: > > So going with the legacy idea wdoekes posted, I've updated the expectations > > charts: > > > > sendrpid=pai > > | pres=allowed | > > pres=prohibited┃

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 17, 2014, 11:26 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11659 --- So going with the legacy idea wdoekes posted, I've updated the

[asterisk-dev] [Code Review] 3458: Testsuite: Off-Nominal Disa Bad Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3458/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23525 https://i

Re: [asterisk-dev] [Code Review] 3444: Testsuite: PJSIP Callee Initiated Nominal Blind Transfers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3444/ --- (Updated April 17, 2014, 4:10 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 6:02 p.m., Joshua Colp wrote: > > /branches/1.8/channels/chan_sip.c, lines 11420-11425 > > > > > > If a legit fromdomain is specified you have to use it, or else you've > > just ignored the f

[asterisk-dev] [Code Review] 3459: DISA Test - No Context

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3459/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23523 https://i

[asterisk-dev] [Code Review] 3460: DISA Test - No Authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3460/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23522 https://i

[asterisk-dev] [Code Review] 3457: DISA Test - Invalid Extension

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3457/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23526 https://i

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 6:02 p.m., Joshua Colp wrote: > > /branches/1.8/channels/chan_sip.c, lines 11420-11425 > > > > > > If a legit fromdomain is specified you have to use it, or else you've > > just ignored the f

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 6:02 p.m., Joshua Colp wrote: > > /branches/1.8/channels/chan_sip.c, lines 11420-11425 > > > > > > If a legit fromdomain is specified you have to use it, or else you've > > just ignored the f

Re: [asterisk-dev] [Code Review] 3400: Nominal DISA Authentication Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3400/ --- (Updated April 17, 2014, 3:38 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 17, 2014, 6:58 a.m., Matt Jordan wrote: > > Quoting Pavel here, who sent this e-mail to the dev list. I'd hate for his > > comment to get missed here: > > > > {quote} > > Hi! > > PLEASE, don't touch the screening indicator (screen=xxx). It has NOTHING > > to do with presentation o

Re: [asterisk-dev] [Code Review] 3445: res_pjsip_refer: Channel variable SIPREFERTOHDR not being set during blind transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3445/ --- (Updated April 17, 2014, 10:16 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3448: res_pjsip: Handle reloading when permanent contacts exist and qualify is configured

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3448/#review11654 --- Ship it! Ship It! - Kevin Harwell On April 15, 2014, 12:31

Re: [asterisk-dev] [Code Review] 3337: Code for DTLS retransmission

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3337/#review11653 --- Is there an ASTERISK issue for the DTLS retransmission bug? -

Re: [asterisk-dev] [Code Review] 3337: Code for DTLS retransmission

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3337/#review11652 --- http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_a

Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c

> On April 17, 2014, 9:28 a.m., Matt Jordan wrote: > > Ship It! For tracking purposes, please open an issue in the issue tracker for these improvements, and reference this review board post. Thanks! - Matt --- This is an automatically

Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/#review11650 --- Ship it! Ship It! - Matt Jordan On April 16, 2014, 6:07 a.m

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11649 --- Quoting Pavel here, who sent this e-mail to the dev list. I'd h