Re: [asterisk-dev] [Code Review] 3514: res_pjsip_refer: Add Referred-By header on INVITE for blind transfers.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3514/#review11789 --- Ship it! I'd make a note in the UPGRADE file that the SIPREFER

Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/#review11790 --- Ship it! Ship It! - Matt Jordan On April 29, 2014, 6:29 a.m

Re: [asterisk-dev] [Code Review] 3491: res_pjsip: Allow cipher to be specified by name

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3491/ --- (Updated May 1, 2014, 7:30 a.m.) Status -- This change has been marke

Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated May 1, 2014, 7:34 a.m.) Status -- This change has been marke

Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call is already held.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3473/#review11791 --- Ship it! Ship It! - opticron On April 30, 2014, 10:45 a.m.,

Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call is already held.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3473/ --- (Updated May 1, 2014, 7:49 a.m.) Status -- This change has been marke

Re: [asterisk-dev] [Code Review] 3073: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3073/ --- (Updated May 1, 2014, 12:53 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3477: Japanese language patch for app_voicemail.c and say.c

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3477/#review11792 --- /trunk/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/#review11793 --- ./asterisk/trunk/tests/pbx/call_file_retries_archive/retries_a

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

> On May 1, 2014, 2:06 p.m., opticron wrote: > > ./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml, lines > > 15-17 > > > > > > This custom module could be replaced with an AMIEventModule invocation

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

> On May 1, 2014, 2:06 p.m., opticron wrote: > > ./asterisk/trunk/tests/pbx/call_file_retries_archive/retries_archive.py, > > line 43 > > > > > > This should also check that the file does not exist in the old locati

Re: [asterisk-dev] [Code Review] 3490: Testsuite: Ensure that repeated device states and presence states behave as expected

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3490/ --- (Updated May 1, 2014, 10:45 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3482: func_presencestate: Make base64 encoded-ness consistent for consumers of presence state

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3482/ --- (Updated May 1, 2014, 11:21 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

> On May 1, 2014, 6:14 p.m., Joshua Colp wrote: > > /branches/11/apps/app_chanspy.c, lines 664-668 > > > > > > Can you explain why the audiohook would not already be attached by the > > previous code here? Or to b

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

> On May 1, 2014, 9:06 a.m., opticron wrote: > > ./asterisk/trunk/tests/pbx/call_file_retries_archive/retries_archive.py, > > line 43 > > > > > > This should also check that the file does not exist in the old locati

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11799 --- /branches/11/apps/app_chanspy.c

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11801 --- Ship it! Ship It! - Mark Michelson On April 29, 2014, 10:07

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

> On May 1, 2014, 9:06 a.m., opticron wrote: > > ./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml, lines > > 15-17 > > > > > > This custom module could be replaced with an AMIEventModule invocation

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3519/#review11797 --- /team/group/media_formats-reviewed/channels/chan_h323.c

Re: [asterisk-dev] [Code Review] 3446: Parking: Add 'AnnounceChannel' to Park manager action. Change some announcement behavior for Park manager action.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3446/#review11804 --- Ship it! Ship It! - rmudgett On April 25, 2014, 11:54 a.m.,

Re: [asterisk-dev] [Code Review] 3515: media_formats: Move chan_pjsip over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3515/#review11803 --- /team/group/media_formats-reviewed/channels/chan_pjsip.c

Re: [asterisk-dev] [Code Review] 3518: media_formats: Move abstract jitterbuffer, audiohooks, smoother, and some core stuff over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3518/#review11806 --- Ship it! Ship It! - Mark Michelson On April 30, 2014, 10:52

Re: [asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3516/#review11805 --- /team/group/media_formats-reviewed/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3514: res_pjsip_refer: Add Referred-By header on INVITE for blind transfers.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3514/#review11807 --- Ship it! Ship It! - Mark Michelson On April 30, 2014, 11:04

Re: [asterisk-dev] [Code Review] 3512: media formats: Convert the translation core over

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3512/#review11808 --- team/group/media_formats-reviewed/main/translate.c

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11809 --- /branches/12/rest-api/api-docs/applications.json

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

> On May 1, 2014, 7:26 p.m., Matt Jordan wrote: > > /branches/12/rest-api/api-docs/applications.json, lines 84-90 > > > > > > I don't think there should be a userEvent field in the query parameter. > > > > I

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

> On May 1, 2014, 4:59 p.m., Samuel Galarneau wrote: > > /branches/12/rest-api/api-docs/applications.json, line 51 > > > > > > What was the thought process behind adding this API endpoint to the > > applications res

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

> On May 1, 2014, 9:59 p.m., Samuel Galarneau wrote: > > /branches/12/rest-api/api-docs/applications.json, line 51 > > > > > > What was the thought process behind adding this API endpoint to the > > applications res

[asterisk-dev] [Code Review] 3520: libpri: Add control of inband audio progress indication ie to the SETUP_ACKNOWLEDGE message.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3520/ --- Review request for Asterisk Developers. Bugs: AST-1338 https://issues.

[asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3521/ --- Review request for Asterisk Developers. Bugs: AST-1338 https://issues.