Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
> On May 1, 2014, 4:59 p.m., Samuel Galarneau wrote: > > /branches/12/rest-api/api-docs/applications.json, line 51 > > > > > > What was the thought process behind adding this API endpoint to the > > applications res

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- (Updated May 9, 2014, 5:29 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
> On May 2, 2014, 8:37 a.m., Matt Jordan wrote: > > /branches/12/main/stasis_user.c, lines 64-74 > > > > > > Wrapping the snapshots is fine, but I think all you'll need is the type > > stored as an enum. That will a

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
> On May 1, 2014, 2:26 p.m., Matt Jordan wrote: > > /branches/12/include/asterisk/stasis_app.h, lines 242-247 > > > > > > Why AGER? App_generate? > > > > I'd use APP_GEN, personally. It's a bit easier to re

[asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- Review request for Asterisk Developers and Joshua Colp. Bugs: ASTERISK-236

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/ --- (Updated May 9, 2014, 11:10 a.m.) Status -- This change has been mark

Re: [asterisk-dev] Wrong entity field in NOTIFY??

2014-05-09 Thread Eugen Dedu
On 09/05/14 09:31, Olle E. Johansson wrote: On 08 May 2014, at 18:33, Eugen Dedu wrote: >Hi asterisk devs, > >Since several years we (opal, ekiga VoIP community) noticed that there is a problem in the NOTIFY messages created by asterisk (entity attribute is set to the subscriber instead of t

Re: [asterisk-dev] Wrong entity field in NOTIFY??

2014-05-09 Thread Olle E. Johansson
On 08 May 2014, at 18:33, Eugen Dedu wrote: > Hi asterisk devs, > > Since several years we (opal, ekiga VoIP community) noticed that there is a > problem in the NOTIFY messages created by asterisk (entity attribute is set > to the subscriber instead of the subscribed) and I finally decided to