Re: [asterisk-dev] [Code Review] 3547: Logger/CLI: Fix some aesthetic issues; clean up some chatty verbose messages

2014-05-19 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3547/#review11913 --- /trunk/cel/cel_pgsql.c

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485/#review11915 --- /branches/12/include/asterisk/bridge.h

Re: [asterisk-dev] [Code Review] 3543: app_meetme: Don't interrupt MOH on waitmarked users.

2014-05-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3543/#review11916 --- Ship it! Ship It! - Matt Jordan On May 15, 2014, 5:44 p.m.,

[asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-05-19 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3548/ --- Review request for Asterisk Developers and rmudgett. Bugs: ASTERISK-23554

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-19 Thread Jonathan Rose
> On May 19, 2014, 9:11 a.m., Matt Jordan wrote: > > /branches/12/include/asterisk/bridge.h, lines 951-953 > > > > > > Terminal does not feel like a good name for this parameter. > > > > What's more, in mos

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-19 Thread Jonathan Rose
> On May 19, 2014, 9:11 a.m., Matt Jordan wrote: > > /branches/12/include/asterisk/bridge.h, lines 951-953 > > > > > > Terminal does not feel like a good name for this parameter. > > > > What's more, in mos

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-19 Thread Jonathan Rose
> On May 19, 2014, 9:11 a.m., Matt Jordan wrote: > > /branches/12/include/asterisk/bridge.h, lines 951-953 > > > > > > Terminal does not feel like a good name for this parameter. > > > > What's more, in mos

[asterisk-dev] [Code Review] 3549: Replace __ast_answer with ast_raw_answer in app_control_answer

2014-05-19 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3549/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23758 https://i

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
> On May 12, 2014, 8:58 p.m., Matt Jordan wrote: > > I feel like we're missing a SIPp scenario here. We have the initial > > receiver of the call, and we have the scenario that sends the REFER request > > - but where is the second SIP channel from the initiator of the transfer, > > and where i

Re: [asterisk-dev] [Code Review] 3549: Replace __ast_answer with ast_raw_answer in app_control_answer

2014-05-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3549/#review11920 --- Ship it! Ship It! - Joshua Colp On May 19, 2014, 5:20 p.m.,

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 19, 2014, 1:02 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485/ --- (Updated May 19, 2014, 1:25 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
> On May 12, 2014, 8:58 p.m., Matt Jordan wrote: > > asterisk/trunk/lib/python/asterisk/ari.py, lines 511-523 > > > > > > This should not be bundled with EventWatcher. Separation of concerns > > takes a real beatin

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 19, 2014, 2:25 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 19, 2014, 2:27 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3549: Replace __ast_answer with ast_raw_answer in app_control_answer

2014-05-19 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3549/ --- (Updated May 19, 2014, 2:50 p.m.) Status -- This change has been mark

[asterisk-dev] [Code Review] 3550: build: Allow autoconf/ast_ext_tool_check to handle cross-compiling better

2014-05-19 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3550/ --- Review request for Asterisk Developers. Repository: Asterisk Description