[asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- Review request for Asterisk Developers. Bugs: AFS-65 and ASTERISK-17954

Re: [asterisk-dev] [Code Review] 3599: menuselect fails to read config when all resource modules are disabled

> On June 6, 2014, 10:41 p.m., Matt Jordan wrote: > > /trunk/menuselect.c, lines 1258-1260 > > > > > > As much as I'd like to hit 'Ship It!', I'm pretty sure this is going > > blow up people trying to use menusele

Re: [asterisk-dev] [Code Review] 3599: menuselect fails to read config when all resource modules are disabled

> On June 6, 2014, 9:41 p.m., Matt Jordan wrote: > > /trunk/menuselect.c, lines 1258-1260 > > > > > > As much as I'd like to hit 'Ship It!', I'm pretty sure this is going > > blow up people trying to use menuselec

Re: [asterisk-dev] [Code Review] 3599: menuselect fails to read config when all resource modules are disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3599/#review12093 --- /trunk/menuselect.c

[asterisk-dev] ari-py websocket connection issue

Hi all I'm excited to build a new web app using the ARI, however I'm having some issues using the ari-py library with python. I'm trying to get up and running with the ari-py library. The REST side of things is working great, I can create channels, do stuff to those channels, no problems. Howeve

Re: [asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3591/#review12092 --- I noticed that your update said "fixed issues" - can you go thr

Re: [asterisk-dev] [Code Review] 3587: chan_pjsip: PJSIPNotify - strip content-length headers, add documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3587/ --- (Updated June 6, 2014, 4:56 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3588: chan_sip: Flip the order of variables supplied to SIPNotify

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3588/ --- (Updated June 6, 2014, 4:14 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3588: chan_sip: Flip the order of variables supplied to SIPNotify

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3588/#review12091 --- Ship it! Ship It! - Mark Michelson On June 6, 2014, 9:08 p.

Re: [asterisk-dev] [Code Review] 3588: chan_sip: Flip the order of variables supplied to SIPNotify

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3588/ --- (Updated June 6, 2014, 4:08 p.m.) Review request for Asterisk Developers,

[asterisk-dev] [Code Review] 3600: testsuite: SIPNotify + PJSIPNotify behavioral tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3600/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson. Re

Re: [asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3591/ --- (Updated June 6, 2014, 7:56 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3593/ --- (Updated June 6, 2014, 1:49 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

> On June 6, 2014, 2:34 p.m., wdoekes wrote: > > /asterisk/trunk/tests/apps/chanspy/chanspy_barge/run-test, lines 46-47 > > > > > > os.getcwd() is always a bad idea > > > > Please replace with path relativ

Re: [asterisk-dev] [Code Review] 3560: Testsuite: Add PJSIP nominal attended transfer tests

> On June 6, 2014, 8:35 a.m., Matt Jordan wrote: > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/callee_initiated/attended_transfer.py, > > lines 15-21 > > > > > > I'm not sure I understand why t

[asterisk-dev] [Code Review] 3599: menuselect fails to read config when all resource modules are disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3599/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23830 https://i

Re: [asterisk-dev] [Code Review] 3596: PJSIP: Recalculate translation paths on raw format changes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3596/ --- (Updated June 6, 2014, 1:51 p.m.) Status -- This change has been disc

Re: [asterisk-dev] Question about audiohook.c and re-sampling

Dennis Guse wrote: > Hi, Kia ora, > at the moment I am working on app_jack, so that it is not limited to > 8000Hz anymore. During the day I made some progress and found that for a > G722 I only get slin in app_jack instead of the expected slin16 (or even > higher). > I looked further and found t

[asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 3596: PJSIP: Recalculate translation paths on raw format changes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3596/ --- Review request for Asterisk Developers. Bugs: AFS-63 https://issues.as

Re: [asterisk-dev] [Code Review] 3594: autoservice exit on clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3594/#review12087 --- Ship it! Ship It! - Mark Michelson On June 6, 2014, 4:22 p.

Re: [asterisk-dev] [Code Review] 3588: chan_sip: Flip the order of variables supplied to SIPNotify

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3588/#review12086 --- /branches/1.8/include/asterisk/config.h

Re: [asterisk-dev] [Code Review] 3568: Reduce creation of channel snapshots to improve performance

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3568/#review12085 --- Ship it! Ship It! - Mark Michelson On June 6, 2014, 12:34 a

Re: [asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

> On June 6, 2014, 10:34 a.m., wdoekes wrote: > > /asterisk/trunk/run-local, line 57 > > > > > > /usr/local/bin and /usr/sbin? > > > > What kind of combination is that? > > > > Should this just be a

Re: [asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3397/ --- (Updated June 6, 2014, 1:26 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3593/#review12084 --- branches/12/main/astobj2_hash.c

Re: [asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3595/ --- (Updated June 6, 2014, 12:10 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3595/#review12083 --- /branches/1.8/apps/app_queue.c

[asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3595/ --- Review request for Asterisk Developers. Bugs: AST-1248 https://issues.

[asterisk-dev] [Code Review] 3594: autoservice exit on clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3594/ --- Review request for Asterisk Developers and Matt Jordan. Bugs: ASTERISK-238

[asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3593/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3397/#review12080 --- Ship it! Good changes. A few minor nits below, but good to go

Re: [asterisk-dev] [Code Review] 3578: Update tests for channel snapshot reduction; add AMI channelvars/Status action test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3578/#review12081 --- Ship it! Ship It! - Mark Michelson On June 1, 2014, 9:16 p.

Re: [asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

> On June 5, 2014, 3:57 p.m., Corey Farrell wrote: > > /asterisk/trunk/runtests.py, lines 98-99 > > > > > > I think a message could be good even when the test was already failed. > > Leaks that happen due to error'

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated June 6, 2014, 9:08 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3496/ --- (Updated June 6, 2014, 9:06 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3591/#review12078 --- Thanks for the feature. This will also require updates to: -

Re: [asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3397/ --- (Updated June 6, 2014, 9:43 a.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

> On May 23, 2014, 6:22 a.m., wdoekes wrote: > > /asterisk/trunk/lib/python/asterisk/asterisk.py, line 464 > > > > > > Don't do: > > > > "abc %s" % (string) > > > > It means exactly: > > > >

Re: [asterisk-dev] [Code Review] 3560: Testsuite: Add PJSIP nominal attended transfer tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3560/#review12076 --- asterisk/trunk/contrib/sipp/table_of_contents