Re: [asterisk-dev] Astobj2 debugging change proposal

2014-06-09 Thread Matthew Jordan
On Mon, Jun 9, 2014 at 5:45 PM, Richard Mudgett wrote: > > > > On Mon, Jun 9, 2014 at 12:31 PM, George Joseph < > george.jos...@fairview5.com> wrote: > >> On Mon, Jun 9, 2014 at 11:22 AM, Corey Farrell wrote: >> >>> One thing I dislike about AST_DEVMODE is that changing it requires >>> rerunning

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

2014-06-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/#review12103 --- /trunk/main/pbx.c

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12102 --- /branches/11/funcs/func_jitterbuffer.c

[asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22409 https://i

Re: [asterisk-dev] Astobj2 debugging change proposal

2014-06-09 Thread Richard Mudgett
On Mon, Jun 9, 2014 at 12:31 PM, George Joseph wrote: > On Mon, Jun 9, 2014 at 11:22 AM, Corey Farrell wrote: > >> One thing I dislike about AST_DEVMODE is that changing it requires >> rerunning ./configure. I feel ./configure should be restricted as much as >> possible to checking dependencies

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

2014-06-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/#review12101 --- /branches/12/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3587: chan_pjsip: PJSIPNotify - strip content-length headers, add documentation.

2014-06-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3587/#review12100 --- Ship it! Ship It! - Mark Michelson On June 6, 2014, 9:56 p.

[asterisk-dev] [Code Review] 3604: Add presence information to core show hints

2014-06-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/ --- Review request for Asterisk Developers. Bugs: AFS-53 https://issues.as

Re: [asterisk-dev] [Code Review] 2170: Changes from Mantis ID 13495 V2

2014-06-09 Thread KNK
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2170/ --- (Updated June 9, 2014, 3:25 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 2170: Changes from Mantis ID 13495 V2

2014-06-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2170/#review12099 --- Ship it! I'm committing these changes to the ss7_27_knk branch

Re: [asterisk-dev] [Code Review] 2150: Post trunk-resurrection fixes to libss7.

2014-06-09 Thread KNK
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2150/ --- (Updated June 9, 2014, 2:48 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 2150: Post trunk-resurrection fixes to libss7.

2014-06-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2150/#review12098 --- Ship it! I'm committing these changes to the libss7 trunk. St

Re: [asterisk-dev] [Code Review] 3599: menuselect fails to read config when all resource modules are disabled

2014-06-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3599/ --- (Updated June 9, 2014, 3:21 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] Astobj2 debugging change proposal

2014-06-09 Thread George Joseph
On Mon, Jun 9, 2014 at 11:22 AM, Corey Farrell wrote: > One thing I dislike about AST_DEVMODE is that changing it requires > rerunning ./configure. I feel ./configure should be restricted as much as > possible to checking dependencies. Any build configuration that is not > directly enabled/disa

Re: [asterisk-dev] Astobj2 debugging change proposal

2014-06-09 Thread Corey Farrell
One thing I dislike about AST_DEVMODE is that changing it requires rerunning ./configure. I feel ./configure should be restricted as much as possible to checking dependencies. Any build configuration that is not directly enabled/disabled by an external dependency should be in menuselect. If we a

Re: [asterisk-dev] Astobj2 debugging change proposal

2014-06-09 Thread Matthew Jordan
On Sun, Jun 8, 2014 at 10:03 AM, George Joseph wrote: > Right now, the non-ref debugging code in astobj2 is triggered by a mix of > AST_DEVMODE and AO2_DEBUG and both get set if you want to run the test > framework. I've noticed though that the inclusion of the debugging code can > actually hide

Re: [asterisk-dev] ari-py websocket connection issue

2014-06-09 Thread Matthew Jordan
On Fri, Jun 6, 2014 at 9:33 PM, Thomas McMahon wrote: > Hi all > > I'm excited to build a new web app using the ARI, however I'm having some > issues using the ari-py library with python. > > I'm trying to get up and running with the ari-py library. The REST side of > things is working great, I ca

Re: [asterisk-dev] Question about audiohook.c and re-sampling

2014-06-09 Thread Joshua Colp
Dennis Guse wrote: Hi, Kia ora, AST_AUDIOHOOK_MANIPULATE_ALL_RATES works like charm, e.g. the data is correctly handed over to Jack and comes back even for 16Khz. So o