Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 24, 2014, 6:53 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3463: RFC: astobj2 cached objects (alternative to weak containers)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3463/ --- (Updated June 24, 2014, 2:29 a.m.) Status -- This change has been dis

[asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3670/ --- Review request for Asterisk Developers, George Joseph, Matt Jordan, and rmu

[asterisk-dev] [Code Review] 3669: chan_sip: Fix handling of "From" headers longer than 256 characters

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3669/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23790 https://i

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

> On June 17, 2014, 9:25 p.m., Mark Michelson wrote: > > trunk/apps/app_queue.c, line 8490 > > > > > > atoi() does not detect errors (such as the input not being an integer) > > and will just return 0 on bad value

[asterisk-dev] [Code Review] 3668: refcounter.py uses excessive RAM when processing large refs file

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3668/ --- Review request for Asterisk Developers and Matt Jordan. Bugs: ASTERISK-239

Re: [asterisk-dev] [Code Review] 3661: Move eid functions to utils.c, mark netsock.h deprecated

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3661/ --- (Updated June 23, 2014, 9:50 p.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 3667: Media Formats fixes for trunk branch

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3667/ --- Review request for Asterisk Developers, Joshua Colp and Matt Jordan. Repos

Re: [asterisk-dev] [Code Review] 3666: res_fax: fax show session, fax show sessions, fax show stats - providing similar AMI commands

> On June 23, 2014, 4:36 p.m., Matt Jordan wrote: > > /trunk/res/res_fax.c, lines 318-325 > > > > > > For duplicate fields, use an xi:include to pull in the documentation. > > Don't reproduce documentation that you

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/ --- (Updated June 23, 2014, 5:10 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/#review12286 --- /team/group/media_formats-reviewed/main/rtp_engine.c

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/ --- (Updated June 23, 2014, 4:42 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/#review12285 --- Ship it! Ship It! - Corey Farrell On June 23, 2014, 4:34 p.

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

> On June 23, 2014, 3:45 p.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed/main/rtp_engine.c, line 1730 > > > > > > I think we need to zero out the records starting with > > ast_rtp_mime_types[y

Re: [asterisk-dev] [Code Review] 3657: when using FEC, asterisk considers negative sequence numbers as missing

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3657/#review12282 --- Ship it! Ship It! - Matt Jordan On June 20, 2014, 3:47 a.m.

Re: [asterisk-dev] [Code Review] 3657: when using FEC, asterisk considers negative sequence numbers as missing

> On June 23, 2014, 11:48 a.m., Matt Jordan wrote: > > trunk/main/udptl.c, lines 538-543 > > > > > > I'm not very familiar with the UDPTL code here, so this is more a dump > > of me trying to figure out what the er

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated June 23, 2014, 3:56 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/#review12280 --- /team/group/media_formats-reviewed/main/rtp_engine.c

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/ --- (Updated June 23, 2014, 3:34 p.m.) Review request for Asterisk Developers,

[asterisk-dev] [Code Review] 3666: res_fax: fax show session, fax show sessions, fax show stats - providing similar AMI commands

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3666/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson. Re

Re: [asterisk-dev] [Code Review] 3657: when using FEC, asterisk considers negative sequence numbers as missing

> On June 23, 2014, 4:48 p.m., Matt Jordan wrote: > > trunk/main/udptl.c, lines 538-543 > > > > > > I'm not very familiar with the UDPTL code here, so this is more a dump > > of me trying to figure out what the err

Re: [asterisk-dev] [Code Review] 3657: when using FEC, asterisk considers negative sequence numbers as missing

> On June 23, 2014, 4:48 p.m., Matt Jordan wrote: > > trunk/main/udptl.c, lines 538-543 > > > > > > I'm not very familiar with the UDPTL code here, so this is more a dump > > of me trying to figure out what the err

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

> On June 23, 2014, 12:10 a.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed/main/codec.c, line 87 > > > > > > Why? > > Matt Jordan wrote: > Because there are times when a user wants to look up a

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

> On June 23, 2014, 12:41 p.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed/main/rtp_engine.c, line 234 > > > > > > For a static procedure shouldn't we omit the "ast_" namespace? I didn't here sim

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/#review12275 --- /team/group/media_formats-reviewed/main/format_cache.c

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

> On June 23, 2014, 12:10 a.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed/main/rtp_engine.c, line 669 > > > > > > type->format could be leaking a reference here. > > Matt Jordan wrote: > If th

Re: [asterisk-dev] [Code Review] 3657: when using FEC, asterisk considers negative sequence numbers as missing

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3657/#review12273 --- trunk/main/udptl.c

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

> On June 23, 2014, 1:10 a.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed/main/format_cache.c, line 297 > > > > > > I'd prefer we just use George's ao2_replace. > > Matt Jordan wrote: > Now tha

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

> On June 17, 2014, 4:25 p.m., Mark Michelson wrote: > > trunk/apps/app_queue.c, line 8490 > > > > > > atoi() does not detect errors (such as the input not being an integer) > > and will just return 0 on bad value

Re: [asterisk-dev] Format branch naming conventions

On Sun, Jun 22, 2014 at 12:22 PM, Corey Farrell wrote: > For a few functions you are recommending we create a new function, and keep > the old function. I think we should delete the old function, at most > provide a macro so the new function can be called with the old name. The > media formats u

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3665/ --- (Updated June 23, 2014, 9:51 a.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3622: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (11)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3622/ --- (Updated June 23, 2014, 9:35 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3621: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (1.8)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3621/ --- (Updated June 23, 2014, 9:34 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

> On June 23, 2014, 12:10 a.m., Corey Farrell wrote: > > Sorry to hit so many issues, I did tell you I was not so confident with the > > changes I made to the last 3 files. Looking at it a second time has helped > > find stuff. Feel free to BUGBUG things where possible. I've clicked "open >

Re: [asterisk-dev] [svn-commits] file: branch file/sha256-a-harsh-reality r417073 - /team/file/sha256-a-harsh-...

On 23 Jun 2014, at 14:24, Joshua Colp wrote: > Olle E. Johansson wrote: >> On 23 Jun 2014, at 13:59, SVN commits to the Digium >> repositories wrote: >> >>> + /* If ICE negotiation is enabled the DTLS Handshake will be performed >>> upon completion of it */ >>> +#ifdef USE_PJPROJECT >>> +

Re: [asterisk-dev] [svn-commits] file: branch file/sha256-a-harsh-reality r417073 - /team/file/sha256-a-harsh-...

Olle E. Johansson wrote: On 23 Jun 2014, at 13:59, SVN commits to the Digium repositories wrote: + /* If ICE negotiation is enabled the DTLS Handshake will be performed upon completion of it */ +#ifdef USE_PJPROJECT + if (!rtp->ssl || rtp->ice) { +#else if (!rtp->ssl) { +

Re: [asterisk-dev] [svn-commits] file: branch file/sha256-a-harsh-reality r417073 - /team/file/sha256-a-harsh-...

On 23 Jun 2014, at 13:59, SVN commits to the Digium repositories wrote: > + /* If ICE negotiation is enabled the DTLS Handshake will be performed > upon completion of it */ > +#ifdef USE_PJPROJECT > + if (!rtp->ssl || rtp->ice) { > +#else > if (!rtp->ssl) { > +#endif >

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3607/ --- (Updated June 23, 2014, 9:41 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

> On June 17, 2014, 9:25 p.m., Mark Michelson wrote: > > trunk/apps/app_queue.c, line 8490 > > > > > > atoi() does not detect errors (such as the input not being an integer) > > and will just return 0 on bad value

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3607/ --- (Updated June 23, 2014, 9:36 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3661: Move eid functions to utils.c, mark netsock.h deprecated

On 23 Jun 2014, at 04:01, Matt Jordan wrote: > > Move eid functions from netsock.c to utils.c. These functions were already > published by utils.h. Flag netsock.h as deprecated and switch > res_pjsip_session.h to use netsock2.h. The only code that still uses > netsock.h is chan_iax2. May

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3548/ --- (Updated June 23, 2014, 2:44 a.m.) Status -- This change has been mar