Re: [asterisk-dev] [Code Review] 3825: testsuite: Add a PJSIPNotify manager command test for using URIs instead of endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3825/#review12843 --- Ship it! Ship It! - Joshua Colp On July 18, 2014, 6:33 p.m.

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/#review12844 --- /trunk/res/res_pjsip_notify.c

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812/ --- (Updated July 24, 2014, 8:01 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/#review12847 --- Ship it! Ship It! - Joshua Colp On July 21, 2014, 4:58 p.m.

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

> On July 21, 2014, 5:49 p.m., Mark Michelson wrote: > > /trunk/main/loader.c, lines 1001-1005 > > > > > > Feel free to cringe at this suggestion, but since you've created both > > an AST_DLLIST_ENTRY and an AST_L

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/#review12848 --- Ship it! Ship It! - Matt Jordan On July 23, 2014, 12:26 p.m

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/#review12849 --- /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3841/#review12851 --- What is the impact of doing this performance wise? Is it still

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/#review12850 --- /asterisk/trunk/tests/rest_api/bridges/playback/forward/test-c

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/#review12852 --- Also, please reference the ASTERISK issue on the reviews. - Ma

Re: [asterisk-dev] [Code Review] 3832: testsuite: Accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3832/#review12854 --- Ship it! Ship It! - Matt Jordan On July 22, 2014, 8:13 p.m.

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/#review12855 --- Ship it! Ship It! - Matt Jordan On July 21, 2014, 5:19 p.m.

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/#review12853 --- /asterisk/trunk/lib/python/asterisk/pluggable_modules.py

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 24, 2014, 9:46 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3807: xmldoc: Add support for an tag in the Asterisk XML documentation

> On July 16, 2014, 2:13 p.m., Paul Belanger wrote: > > /trunk/funcs/func_jitterbuffer.c, lines 69-76 > > > > > > Your priority values for each extension is not consistent. 5 are exten > > => 1,1 and 1 is exten =>

Re: [asterisk-dev] Original 48kHz versions of the asterisk prompts and addons?

> On Fri, Jul 18, 2014 at 8:54 PM, Stephen Davies > wrote: >> >> Hi, >> >> I'm on a mission to build a little demo system that blows past everyone's >> perceptions of what a VOIP system sounds like. >> >> For that system I want to make a set of standard and addon prompts in >> .sln48. But I don't

Re: [asterisk-dev] [Code Review] 3807: xmldoc: Add support for an tag in the Asterisk XML documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3807/ --- (Updated July 24, 2014, 9:55 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] AstriDevCon on Oct 21st, 2014 in Las Vegas - Asterisk Developers invited!

Thanks! Just one comment ref the wiki page SIP: SIP/31...@astridevcon.asterisk.org Is not a valid formatted SIP uri :-) Torrey On 23 July 2014 21:36, Digium's Asterisk Development Team < asteriskt...@digium.com> wrote: > Digium invites developers who are interested in the future of Asterisk

Re: [asterisk-dev] [Code Review] 3771: device state: Update core to report ONHOLD if channel is on hold

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3771/ --- (Updated July 24, 2014, 10:21 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12858 --- trunk/include/asterisk/stasis.h

Re: [asterisk-dev] [Code Review] 3802: Add module support level to module info; print module support level in CLI "module show" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3802/#review12859 --- Ship it! Ship It! - Matt Jordan On July 16, 2014, 9:54 a.m.

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

> On July 24, 2014, 2:22 p.m., Matt Jordan wrote: > > /asterisk/trunk/lib/python/asterisk/pluggable_modules.py, lines 430-431 > > > > > > I'm not sure why you're popping 'type' off of the action here. The reason wh

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/ --- (Updated July 24, 2014, 3:53 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/ --- (Updated July 24, 2014, 10:58 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/ --- (Updated July 24, 2014, 5:08 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3807: xmldoc: Add support for an tag in the Asterisk XML documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3807/#review12861 --- /trunk/main/xmldoc.c

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/ --- (Updated July 24, 2014, 5:42 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/ --- (Updated July 24, 2014, 5:44 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/ --- (Updated July 24, 2014, 12:47 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3818: Deprecate astobj.h

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3818/ --- (Updated July 24, 2014, 12:50 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3834: chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3834/ --- (Updated July 24, 2014, 12:55 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

> On July 23, 2014, 2:58 p.m., Tilghman Lesher wrote: > > As long as you're doing multiple statements, might it be faster to do a > > SELECT first and then conditionally do an INSERT or UPDATE, depending upon > > the results of that SELECT? It would seem as if one read and one write > > opera

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

> On July 24, 2014, 9:57 a.m., Joshua Colp wrote: > > What is the impact of doing this performance wise? Is it still better than > > before? I was having the same thoughts as you and was doing some testing to see if there are any gains anymore from the patch. With my testing, I am sad to say,

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3841/ --- (Updated July 24, 2014, 4:55 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3716/#review12860 --- You are affecting the lifetime of the continer node object with

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3841/ --- (Updated July 24, 2014, 4:01 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3840: bridge: Move "bridge destroy" CLI command to devmode and add "all" to "bridge kick" CLI command

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/#review12864 --- /branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 3836: app_bridgewait: Remove race condition where bridge may be dissolved when trying to join

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3836/#review12865 --- Ship it! Ship It! - rmudgett On July 22, 2014, 10:14 a.m.,

Re: [asterisk-dev] [Code Review] 3840: bridge: Move "bridge destroy" CLI command to devmode and add "all" to "bridge kick" CLI command

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/ --- (Updated July 24, 2014, 9:51 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3840: bridge: Move "bridge destroy" CLI command to devmode and add "all" to "bridge kick" CLI command

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/#review12866 --- /branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 3840: bridge: Move "bridge destroy" CLI command to devmode and add "all" to "bridge kick" CLI command

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/ --- (Updated July 24, 2014, 9:56 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3840: bridge: Move "bridge destroy" CLI command to devmode and add "all" to "bridge kick" CLI command

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/#review12867 --- Ship it! Ship It! - rmudgett On July 24, 2014, 4:56 p.m., J

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated July 24, 2014, 5:48 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3832: testsuite: Accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3832/ --- (Updated July 24, 2014, 6:02 p.m.) Status -- This change has been mar