---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3851/
---
(Updated July 29, 2014, 9:53 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3850/
---
(Updated July 29, 2014, 10:56 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3843/#review12899
---
The two findings below apply to all three tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3797/#review12900
---
/trunk/res/res_pjsip/pjsip_options.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3817/#review12901
---
Ship it!
Ship It!
- Joshua Colp
On July 24, 2014, 3:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3854/#review12902
---
/branches/1.8/main/manager.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 29, 2014, 2:40 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3856/#review12904
---
/branches/11/channels/chan_iax2.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3829/#review12905
---
Per https://reviewboard.asterisk.org/r/3833/, there is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3833/#review12906
---
This change needs documentation since as it is unless you see
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3607/#review12903
---
Regarding the actual diff, most findings I have on this are
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3865/#review12907
---
Ship it!
I was going to say something about how breakdown
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3866/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24124
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3865/
---
(Updated July 29, 2014, 11:05 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3810/#review12908
---
Ship it!
Ship It!
- Joshua Colp
On July 27, 2014, 3:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3842/#review12909
---
Ship it!
Your test descriptions need editing to remove/fix
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3842/#review12910
---
On July 17, 2014, 4:41 p.m., Matt Jordan wrote:
/trunk/main/stasis_channels.c, lines 1071-1077
https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071
I'm not sure why these changes (removal of the .to_ami callback) were
necessary.
Generally, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3673/#review12912
---
http://pastebin.com/LtPH0bSY
-- new diff addresses the last
On June 27, 2014, 2:42 p.m., Matt Jordan wrote:
Alexander Traud wrote:
hence a 'retry once' poll may not be sufficient regardless to read all
of the data from the socket.
I am not sure, I understand you guys. Just to clarify my intentions: The
proposed patch is not
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/
---
(Updated July 29, 2014, 2:14 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3857/
---
(Updated July 29, 2014, 7:16 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3816/
---
(Updated July 29, 2014, 7:17 p.m.)
Status
--
This change has been
On July 29, 2014, 2:32 p.m., Joshua Colp wrote:
/branches/1.8/main/manager.c, line 207
https://reviewboard.asterisk.org/r/3854/diff/1/?file=65275#file65275line207
This confuses me, even after reading a few times. Specifically what
you've added: directly or via function. Dialplan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3797/
---
(Updated July 29, 2014, 8:05 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review12915
---
/trunk/res/res_pjsip_outbound_publish.c
On July 29, 2014, 2:32 p.m., Joshua Colp wrote:
/branches/1.8/main/manager.c, line 207
https://reviewboard.asterisk.org/r/3854/diff/1/?file=65275#file65275line207
This confuses me, even after reading a few times. Specifically what
you've added: directly or via function. Dialplan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3799/#review12917
---
Ship it!
Ship it! (aside from opticron's findings)
- Mark
28 matches
Mail list logo