Re: [asterisk-dev] [Code Review] 3851: res_pjsip_pidf_body_generator / res_pjsip_xpidf_body_generator: Ensure entity is unquoted.

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3851/ --- (Updated July 29, 2014, 9:53 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3850: res_pjsip_session: Ensure session supplements are invoked before redirection occurs

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3850/ --- (Updated July 29, 2014, 10:56 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3843: Add tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions

2014-07-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3843/#review12899 --- The two findings below apply to all three tests.

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12900 --- /trunk/res/res_pjsip/pjsip_options.c

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/#review12901 --- Ship it! Ship It! - Joshua Colp On July 24, 2014, 3:58

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/#review12902 --- /branches/1.8/main/manager.c

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3780/ --- (Updated July 29, 2014, 2:40 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3856/#review12904 --- /branches/11/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/#review12905 --- Per https://reviewboard.asterisk.org/r/3833/, there is an

Re: [asterisk-dev] [Code Review] 3833: Allow sending voicemail to multiple email addresses

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3833/#review12906 --- This change needs documentation since as it is unless you see

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3607/#review12903 --- Regarding the actual diff, most findings I have on this are

Re: [asterisk-dev] [Code Review] 3865: Stasis: Handle incoming masquerades

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3865/#review12907 --- Ship it! I was going to say something about how breakdown

[asterisk-dev] [Code Review] 3866: Ensure that arbitrary header order of AMI Userevent Action results in same information being transmitted in the ensuing AMI event.

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3866/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24124

Re: [asterisk-dev] [Code Review] 3865: Stasis: Handle incoming masquerades

2014-07-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3865/ --- (Updated July 29, 2014, 11:05 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3810: res_hep_rtcp: Add module that sends RTCP information to a Homer Server

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3810/#review12908 --- Ship it! Ship It! - Joshua Colp On July 27, 2014, 3:39

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/#review12909 --- Ship it! Your test descriptions need editing to remove/fix

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/#review12910 ---

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-29 Thread Matt Jordan
On July 17, 2014, 4:41 p.m., Matt Jordan wrote: /trunk/main/stasis_channels.c, lines 1071-1077 https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071 I'm not sure why these changes (removal of the .to_ami callback) were necessary. Generally, I

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-29 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12912 --- http://pastebin.com/LtPH0bSY -- new diff addresses the last

Re: [asterisk-dev] [Code Review] 3653: chan_sip: (Optionally) poll even on first part of TLS message

2014-07-29 Thread Alexander Traud
On June 27, 2014, 2:42 p.m., Matt Jordan wrote: Alexander Traud wrote: hence a 'retry once' poll may not be sufficient regardless to read all of the data from the socket. I am not sure, I understand you guys. Just to clarify my intentions: The proposed patch is not

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 29, 2014, 2:14 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3857: Ensure that channels that move from a stasis bridge to a non-stasis bridge have a StasisEnd sent at an appropriate time.

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3857/ --- (Updated July 29, 2014, 7:16 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3816: Publish transferee and transfer target channels, when possible, during transfers.

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3816/ --- (Updated July 29, 2014, 7:17 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-29 Thread rnewton
On July 29, 2014, 2:32 p.m., Joshua Colp wrote: /branches/1.8/main/manager.c, line 207 https://reviewboard.asterisk.org/r/3854/diff/1/?file=65275#file65275line207 This confuses me, even after reading a few times. Specifically what you've added: directly or via function. Dialplan

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/ --- (Updated July 29, 2014, 8:05 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3780/#review12915 --- /trunk/res/res_pjsip_outbound_publish.c

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-29 Thread Mark Michelson
On July 29, 2014, 2:32 p.m., Joshua Colp wrote: /branches/1.8/main/manager.c, line 207 https://reviewboard.asterisk.org/r/3854/diff/1/?file=65275#file65275line207 This confuses me, even after reading a few times. Specifically what you've added: directly or via function. Dialplan

Re: [asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3799/#review12917 --- Ship it! Ship it! (aside from opticron's findings) - Mark