Re: [asterisk-dev] [Code Review] 3912: Fix ASTERISK-24032.

2014-08-15 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3912/#review13088 --- Ship it! Works for me. The configure changes are: ---

[asterisk-dev] [Code Review] 3914: res_http_websocket: Fix bug where query parameters are not present in client request

2014-08-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3914/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3915: AMI: Add AllVariables parameter to Status

2014-08-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3915/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3916: Testsuite: Add test for AllVariables Status parameter

2014-08-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3916/ --- (Updated Aug. 15, 2014, 10:33 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24043

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/#review13089 ---

Re: [asterisk-dev] [Code Review] 3918: Testsuite: Add a test for ARI originate and continue functionality

2014-08-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3918/ --- (Updated Aug. 15, 2014, noon) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-15 Thread Jonathan Rose
On Aug. 15, 2014, 10:54 a.m., opticron wrote: /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/test-config.yaml, lines 45-47 https://reviewboard.asterisk.org/r/3873/diff/2/?file=66349#file66349line45 Make these settings overridable defaults

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/ --- (Updated Aug. 15, 2014, 1:57 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3914: res_http_websocket: Fix bug where query parameters are not present in client request

2014-08-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3914/#review13091 --- Ship it! Ship It! - Jonathan Rose On Aug. 15, 2014, 7:02

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-15 Thread Krandon Bruse
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/#review13092 --- Just retested this with the SVN Asterisk 12 - works well! -

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-15 Thread Jonathan Rose
On Aug. 15, 2014, 4:24 p.m., Krandon Bruse wrote: Just retested this with the SVN Asterisk 12 - works well! I've also written an automated test for this, which can be found here: https://reviewboard.asterisk.org/r/3918/ - Jonathan

Re: [asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

2014-08-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1152/#review13094 --- /trunk/res/res_calendar_ews.c