Re: [asterisk-dev] [Code Review] 3927: Resolve race condition in scheduler when attempting to delete a running task

2014-08-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3927/ --- (Updated Aug. 24, 2014, 11:42 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/ --- (Updated Aug. 24, 2014, 11:37 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
> On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: > > My only concern with this is that we somehow have code which expected to be > > invoked at #3 - do you think this is possible at all? > > Joshua Colp wrote: > It may also be useful to document your flow discovery above within the > code

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Mark Michelson
> On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: > > My only concern with this is that we somehow have code which expected to be > > invoked at #3 - do you think this is possible at all? > > Joshua Colp wrote: > It may also be useful to document your flow discovery above within the > code

[asterisk-dev] [Code Review] 3932: runtests.py: -H (--hide-skipped)

2014-08-24 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3932/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

[asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-24 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 3928: res_musiconhold: Fix MOH restarting where it left off from the last hold.

2014-08-24 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3928/#review13159 --- Ship it! Whoops. I was indeed misled by that comment. Perhaps

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
> On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: > > My only concern with this is that we somehow have code which expected to be > > invoked at #3 - do you think this is possible at all? It may also be useful to document your flow discovery above within the code somewhere for future reference

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/#review13157 --- My only concern with this is that we somehow have code which ex

[asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24212 https://i