Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

> On Sept. 15, 2014, 7:07 p.m., Corey Farrell wrote: > > /branches/1.8/contrib/scripts/refcounter.py, lines 118-119 > > > > > > This can be optimized if invalid objects are given curcount == -1, that > > way it wou

Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

> On Sept. 15, 2014, 6:07 p.m., Corey Farrell wrote: > > /branches/1.8/contrib/scripts/refcounter.py, lines 118-119 > > > > > > This can be optimized if invalid objects are given curcount == -1, that > > way it wou

Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3971/#review13307 --- /branches/1.8/contrib/scripts/refcounter.py

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/#review13306 --- This seems to only be a problem in v13+ and should not be appli

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/ --- (Updated Sept. 15, 2014, 4:37 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 15, 2014, 1:43 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13305 --- branches/12/include/asterisk/strings.h

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

> On Sept. 10, 2014, 6:25 p.m., Joshua Colp wrote: > > /branches/12/res/res_pjsip/config_auth.c, line 116 > > > > > > Test this and make sure that the PJSIP digest authentication doesn't > > freak. :P Confirmed th

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/ --- (Updated Sept. 15, 2014, 7:27 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3995: res_pjsip_endpoint_identifier_ip: Can't parse identify with match value containing CIDR

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3995/ --- Review request for Asterisk Developers and Joshua Colp. Bugs: ASTERISK-242

Re: [asterisk-dev] [Code Review] 3916: Testsuite: Add test for AllVariables Status parameter

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3916/#review13303 --- Ship it! asterisk/trunk/tests/manager/status_all_vars/test-co

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

> On Sept. 15, 2014, 4:14 p.m., opticron wrote: > > This change appears to render the media_use_received_transport > > configuration option non-functional since it removes all checks relating to > > it. It'll still work, the difference is on received it is always done and the outgoing check h

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13301 --- This change appears to render the media_use_received_transport

[asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3994/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23469 None De

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

> On Sept. 11, 2014, 10:16 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 2488-2501 > > > > > > Looking at the pjproject code why wouldn't the following return values > > cover these cases for wh

Re: [asterisk-dev] [Code Review] 3993: config: bug: Fix SEGV in ast_category_insert when a matching category isn't found

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3993/ --- (Updated Sept. 15, 2014, 9:03 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/#review13299 --- Ship it! /branches/13/res/res_rtp_asterisk.c

Re: [asterisk-dev] [Code Review] 3993: config: bug: Fix SEGV in ast_category_insert when a matching category isn't found

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3993/#review13298 --- branches/1.8/main/config.c

Re: [asterisk-dev] [Code Review] 2764: Add edit-MASTER-channel option to CHANNEL() function. To work around channel optimization removing my channel settings.

> On Aug. 21, 2013, 1:47 p.m., Matt Jordan wrote: > > Why not use pre-dial to put the musicclass directly on the channel that > > will survive, as opposed to the Local channel? Because I have no pre-dial in this old branch, mostly. But now I don't need it on the local channel anymore. Thanks

Re: [asterisk-dev] [Code Review] 2764: Add edit-MASTER-channel option to CHANNEL() function. To work around channel optimization removing my channel settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2764/ --- (Updated Sept. 15, 2014, 10 a.m.) Status -- This change has been disc