[asterisk-dev] [Code Review] 4003: 503 incorrectly sent to rentransmitted invites

2014-09-19 Thread Torrey Searle
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4003/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4003: 503 incorrectly sent to rentransmitted invites

2014-09-19 Thread Torrey Searle
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4003/ --- (Updated Sept. 19, 2014, 6:52 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4003: 503 incorrectly sent to rentransmitted invites

2014-09-19 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4003/#review13363 --- Ship it! LGTM. Please commit it against 1.8. - wdoekes On

Re: [asterisk-dev] [Code Review] 4003: 503 incorrectly sent to rentransmitted invites

2014-09-19 Thread Torrey Searle
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4003/ --- (Updated Sept. 19, 2014, 7:25 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4003: 503 incorrectly sent to rentransmitted invites

2014-09-19 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4003/#review13364 --- If it's not too much trouble, don't attach the test case as

[asterisk-dev] [Code Review] 4006: Test to validate 503 not generated on INVITE retransmissions

2014-09-19 Thread Torrey Searle
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4006/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24335

Re: [asterisk-dev] [Code Review] 4003: 503 incorrectly sent to rentransmitted invites

2014-09-19 Thread Torrey Searle
On Sept. 19, 2014, 7:48 a.m., wdoekes wrote: If it's not too much trouble, don't attach the test case as tgz, but create a separate review for it. Patch http://svn.asterisk.org/svn/testsuite/asterisk/trunk with it and create a review from that.

Re: [asterisk-dev] [Code Review] 3924: Testsuite: Add modular event action framework

2014-09-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3924/ --- (Updated Sept. 19, 2014, 7:50 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4007: testsuite: pick test suite temp dir based on free space

2014-09-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4007/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4007: testsuite: pick test suite temp dir based on free space

2014-09-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4007/#review13366 --- Ship it! Blech. Thanks CentOS 7. :-( This patch will work

Re: [asterisk-dev] [Code Review] 4007: testsuite: pick test suite temp dir based on free space

2014-09-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4007/ --- (Updated Sept. 19, 2014, 8:54 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4006: Test to validate 503 not generated on INVITE retransmissions

2014-09-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4006/#review13368 --- There are a couple of problems with this test: 1) It's quite

Re: [asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3999/ --- (Updated Sept. 19, 2014, 9:56 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4006: Test to validate 503 not generated on INVITE retransmissions

2014-09-19 Thread Torrey Searle
On Sept. 19, 2014, 2:34 p.m., Mark Michelson wrote: There are a couple of problems with this test: 1) It's quite a bit more complicated than it needs to be. What's actually being tested here is that Asterisk does not send a 503 in addition to a 486 on an INVITE retransmission. This

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 19, 2014, 10:10 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4006: Test to validate 503 not generated on INVITE retransmissions

2014-09-19 Thread Torrey Searle
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4006/ --- (Updated Sept. 19, 2014, 3:19 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4006: Test to validate 503 not generated on INVITE retransmissions

2014-09-19 Thread Torrey Searle
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4006/ --- (Updated Sept. 19, 2014, 3:51 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4008: res_pjsip_session: Add additional checks to prevent session refresh in unpossible states.

2014-09-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4008/ --- Review request for Asterisk Developers and Mark Michelson. Repository:

Re: [asterisk-dev] [Code Review] 4000: res_pjsip_sdp_rtp.c: Fix native formats containing formats that were not negotiated.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4000/ --- (Updated Sept. 19, 2014, 12:08 p.m.) Status -- This change has been

[asterisk-dev] Asterisk 1.8.31.0-rc1 Now Available

2014-09-19 Thread Asterisk Development Team
The Asterisk Development Team has announced the first release candidate of Asterisk 1.8.31.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 1.8.31.0-rc1 resolves several issues reported by the community

[asterisk-dev] Asterisk 11.13.0-rc1 Now Available

2014-09-19 Thread Asterisk Development Team
The Asterisk Development Team has announced the first release candidate of Asterisk 11.13.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.13.0-rc1 resolves several issues reported by the community and

[asterisk-dev] Asterisk 13.0.0-beta2 Now Available!

2014-09-19 Thread Asterisk Development Team
The Asterisk Development Team is pleased to announce the second beta release of Asterisk 13.0.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk/releases All interested users of Asterisk are encouraged to participate in the Asterisk 13

[asterisk-dev] Asterisk 12.6.0-rc1 Now Available

2014-09-19 Thread Asterisk Development Team
The Asterisk Development Team has announced the first release candidate of Asterisk 12.6.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.6.0-rc1 resolves several issues reported by the community and

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 4:52 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 4:54 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 4:55 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 5:02 p.m.) Review request for Asterisk

[asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-19 Thread George Joseph
In the process of getting my GUI and real customers up on PJSIP I've come across a few things that could work better for me. One of them is the configuration process for ITSP trunks, specifically those that require registration and have more than 1 server. In a simple single-server scenario, a