Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13378 --- Ship it! Ship It! - Joshua Colp On Sept. 19, 2014, 10:02

Re: [asterisk-dev] [Code Review] 4016: chan_sip: Unref outbound proxy structure on dialog(pvt) struct

2014-09-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4016/#review13379 --- /branches/1.8/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 4016: chan_sip: Unref outbound proxy structure on dialog(pvt) struct

2014-09-23 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4016/ --- (Updated Sept. 23, 2014, 12:18 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4016: chan_sip: Unref outbound proxy structure on dialog(pvt) struct

2014-09-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4016/#review13380 --- Ship it! Ship It! - Joshua Colp On Sept. 23, 2014, 12:18

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Paul Albrecht
On Sep 22, 2014, at 3:47 PM, Joshua Colp jc...@digium.com wrote: Paul Albrecht wrote: Asterisk 13 beta2 compile fails: . . . [CC] chan_pjsip.c - chan_pjsip.o [CC] pjsip/dialplan_functions.c - pjsip/dialplan_functions.o [LD] chan_pjsip.o pjsip/dialplan_functions.o - chan_pjsip.so

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Joshua Colp
Paul Albrecht wrote: On Sep 22, 2014, at 3:47 PM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: Paul Albrecht wrote: Asterisk 13 beta2 compile fails: . . . [CC] chan_pjsip.c - chan_pjsip.o [CC] pjsip/dialplan_functions.c - pjsip/dialplan_functions.o [LD] chan_pjsip.o

Re: [asterisk-dev] [Code Review] 4014: Changes to CDR and CEL unit tests to prevent FRACKs.

2014-09-23 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4014/ --- (Updated Sept. 23, 2014, 9:29 a.m.) Status -- This change has been

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Paul Albrecht
On Sep 23, 2014, at 9:25 AM, Joshua Colp jc...@digium.com wrote: Paul Albrecht wrote: On Sep 22, 2014, at 3:47 PM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: Paul Albrecht wrote: Asterisk 13 beta2 compile fails: . . . [CC] chan_pjsip.c - chan_pjsip.o [CC]

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Matthew Jordan
On Tue, Sep 23, 2014 at 10:11 AM, Paul Albrecht palbre...@glccom.com wrote: On Sep 23, 2014, at 9:25 AM, Joshua Colp jc...@digium.com wrote: Paul Albrecht wrote: On Sep 22, 2014, at 3:47 PM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: Paul Albrecht wrote:

Re: [asterisk-dev] [Code Review] 4013: Alembic: Add 'outgoing' enum value to sippeers directmedia enumerator

2014-09-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4013/ --- (Updated Sept. 23, 2014, 10:41 a.m.) Review request for Asterisk

[asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread George Joseph
I've been working on some changes for config.c and in the process I've found 5 instances of someone attempting to do cat-name == category_name instead of strcmp(cat-name, category_name).Example: /* try exact match first, then case-insensitive match */ for (cat = config-root; cat; cat =

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread George Joseph
On Tue, Sep 23, 2014 at 9:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for config.c and in the process I've found 5 instances of someone attempting to do cat-name == category_name instead of strcmp(cat-name, category_name).Example: /* try

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread Matthew Jordan
On Tue, Sep 23, 2014 at 10:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for config.c and in the process I've found 5 instances of someone attempting to do cat-name == category_name instead of strcmp(cat-name, category_name).Example: /* try

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread Richard Mudgett
On Tue, Sep 23, 2014 at 10:51 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, Sep 23, 2014 at 9:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for config.c and in the process I've found 5 instances of someone attempting to do cat-name

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Paul Albrecht
On Sep 23, 2014, at 10:24 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 23, 2014 at 10:11 AM, Paul Albrecht palbre...@glccom.com wrote: On Sep 23, 2014, at 9:25 AM, Joshua Colp jc...@digium.com wrote: Paul Albrecht wrote: On Sep 22, 2014, at 3:47 PM, Joshua Colp

Re: [asterisk-dev] [Code Review] 4017: chan_pjsip: Don't attempt to apply formats if there aren't any capabilities defined when creating a new channel

2014-09-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4017/ --- (Updated Sept. 23, 2014, 11:32 a.m.) Review request for Asterisk

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread Paul Belanger
On Tue, Sep 23, 2014 at 11:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for config.c and in the process I've found 5 instances of someone attempting to do cat-name == category_name instead of strcmp(cat-name, category_name).Example: /* try

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Jason Parker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/23/2014 11:19 AM, Paul Albrecht wrote: I’m just a user reporting a bug No you aren't. If you were reporting a bug, you would be at https://issues.asterisk.org/, instead. -BEGIN PGP SIGNATURE- Version: GnuPG v1

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread Matthew Jordan
On Tue, Sep 23, 2014 at 11:29 AM, Paul Belanger paul.belan...@polybeacon.com wrote: On Tue, Sep 23, 2014 at 11:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for config.c and in the process I've found 5 instances of someone attempting to do

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Matthew Jordan
On Tue, Sep 23, 2014 at 11:19 AM, Paul Albrecht palbre...@glccom.com wrote: On Sep 23, 2014, at 10:24 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 23, 2014 at 10:11 AM, Paul Albrecht palbre...@glccom.com wrote: On Sep 23, 2014, at 9:25 AM, Joshua Colp jc...@digium.com wrote:

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread George Joseph
On Tue, Sep 23, 2014 at 10:05 AM, Richard Mudgett rmudg...@digium.com wrote: On Tue, Sep 23, 2014 at 10:51 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, Sep 23, 2014 at 9:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread George Joseph
On Tue, Sep 23, 2014 at 11:13 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 23, 2014 at 11:29 AM, Paul Belanger paul.belan...@polybeacon.com wrote: On Tue, Sep 23, 2014 at 11:45 AM, George Joseph george.jos...@fairview5.com wrote: I've been working on some changes for

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Paul Albrecht
On Sep 23, 2014, at 12:22 PM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 23, 2014 at 11:19 AM, Paul Albrecht palbre...@glccom.com wrote: On Sep 23, 2014, at 10:24 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 23, 2014 at 10:11 AM, Paul Albrecht

Re: [asterisk-dev] Opinions Needed: Case sensitivity in config file section names

2014-09-23 Thread Paul Belanger
On Tue, Sep 23, 2014 at 1:47 PM, George Joseph george.jos...@fairview5.com wrote: On Tue, Sep 23, 2014 at 11:13 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 23, 2014 at 11:29 AM, Paul Belanger paul.belan...@polybeacon.com wrote: On Tue, Sep 23, 2014 at 11:45 AM, George Joseph

[asterisk-dev] [Code Review] 4018: res_pjsip: Make transport cipher option accept a comma separated list of cipher names.

2014-09-23 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4018/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24199