Re: [asterisk-dev] [Code Review] 4023: Allow passing options and command to MixMonitor when recording in ConfBridge

2014-09-27 Thread gareth
On Sept. 26, 2014, 1:11 p.m., Corey Farrell wrote: I believe this change would allow AMI users to execute arbitrary commands on the Asterisk server (security risk). The ability to SetVar CONFBRIDGE(bridge,record_command) from AMI would need to be blocked when asterisk.conf has

Re: [asterisk-dev] [Code Review] 4023: Allow passing options and command to MixMonitor when recording in ConfBridge

2014-09-27 Thread gareth
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4023/ --- (Updated Sept. 27, 2014, 6:30 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4024: AMI connection closes if sendMessage generates an erros response

2014-09-27 Thread Peter Katzmann
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4024/#review13391 --- Ship it! Ship It! - Peter Katzmann On Sept. 26, 2014, 9:04

Re: [asterisk-dev] [Code Review] 4008: res_pjsip_session: Add additional checks to prevent session refresh in unpossible states.

2014-09-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4008/ --- (Updated Sept. 27, 2014, 7:42 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4012: testsuite: Allow multiple -t options to be passed.

2014-09-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4012/#review13392 --- Ship it! Ship It! - Corey Farrell On Sept. 26, 2014, 9:28