Re: [asterisk-dev] [Code Review] 4052: chan_sip: Failure to receive ACK to SIP re-INVITE results in dialog leak.

2014-10-10 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4052/ --- (Updated Oct. 10, 2014, 2:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-10 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- (Updated Oct. 10, 2014, 2:29 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4068: res_calendar_ews: Relax neon version check to work with 0.30 too.

2014-10-10 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4068/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24325

Re: [asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

2014-10-10 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4067/ --- (Updated Oct. 10, 2014, 7:55 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add virtual line support for automatic inbound matching

2014-10-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2964/ --- (Updated Oct. 10, 2014, 1:18 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4068: res_calendar_ews: Relax neon version check to work with 0.30 too.

2014-10-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4068/#review13487 --- Ship it! Ship It! - Matt Jordan On Oct. 10, 2014, 7:11

Re: [asterisk-dev] [Code Review] 4064: makefile: Relax badshell tilde test to allow for ~ in middle of DESTDIR.

2014-10-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4064/#review13488 --- Ship it! Ship It! - Matt Jordan On Oct. 9, 2014, 10:01

[asterisk-dev] [Code Review] 4069: res_phoneprov: Cleanup module load error handling

2014-10-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4069/ --- Review request for Asterisk Developers and Matt Jordan. Repository:

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-10 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- (Updated Oct. 10, 2014, 12:44 p.m.) Review request for Asterisk

Re: [asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-10 Thread Nir Simionovich
Well, Can I assume you are referring to the following section in the code (pbx.c): 12371if (sscanf(pri, %30d, ipri) != 1) {12372 ipri = ast_findlabel_extension http://doxygen.asterisk.org/trunk/db/de0/pbx_8h.html#0be9518646cf9aca4878b313cc02e901(chan, context ? context :

[asterisk-dev] [Code Review] 4071: scheduler: Fix a bug introduced by adding a delete flag to scheduled tasks

2014-10-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4071/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson.

Re: [asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-10 Thread Scott Griepentrog
Yes, that's the function that converts a label to a priority. You should be able to use that to enable label lookup from the rest api. On Fri, Oct 10, 2014 at 1:38 PM, Nir Simionovich nir.simionov...@gmail.com wrote: Well, Can I assume you are referring to the following section in the code

Re: [asterisk-dev] [Code Review] 4071: scheduler: Fix a bug introduced by adding a delete flag to scheduled tasks

2014-10-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4071/ --- (Updated Oct. 10, 2014, 1:49 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-10 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/#review13489 --- /asterisk/trunk/runtests.py

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/ --- (Updated Oct. 10, 2014, 8:13 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4057/ --- (Updated Oct. 10, 2014, 3:47 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4072: Testsuite: Tests for manager GetConfig and UpdateConfig AMI actions

2014-10-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4072/ --- Review request for Asterisk Developers. Repository: testsuite