Re: [asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-13 Thread Nir Simionovich
Ok, I'm now looking into implementing a similar thing with the continue request. The main issue that I'm seeing is this - the ast_findlabel_extension function, requires a channel and a callerid. I've tried ascertaining how i can obtain that information from within the

Re: [asterisk-dev] [Code Review] 2783: Fix SIP/TLS reading - random connection drop

2014-10-13 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2783/#review13494 --- What's the status of this patch? Should it be closed? - Olle

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Russell Bryant
On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Hi I finally got the asterisk-testsuite accpted into Debian (I know, I need to get it updated). A related question ... what's the value of having it packaged at all? I could see the value if the test suite was

[asterisk-dev] License issue

2014-10-13 Thread Olle E. Johansson
Hi! A customer showed interest in supporting the SIP GIN standard - registering for multiple contacts according to RFC 6140, part of the SIPconnect work. I remembered an old patch on reviewboard that has an issue in the bug tracker - #18705 The patch was never uploaded to the bug tracker,

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Tzafrir Cohen
On Mon, Oct 13, 2014 at 09:18:10AM -0400, Russell Bryant wrote: On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Hi I finally got the asterisk-testsuite accpted into Debian (I know, I need to get it updated). A related question ... what's the value of

Re: [asterisk-dev] License issue

2014-10-13 Thread Russell Bryant
On Mon, Oct 13, 2014 at 9:28 AM, Olle E. Johansson o...@edvina.net wrote: Hi! A customer showed interest in supporting the SIP GIN standard - registering for multiple contacts according to RFC 6140, part of the SIPconnect work. I remembered an old patch on reviewboard that has an issue in

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Russell Bryant
On Mon, Oct 13, 2014 at 9:44 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, Oct 13, 2014 at 09:18:10AM -0400, Russell Bryant wrote: On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Hi I finally got the asterisk-testsuite accpted into

Re: [asterisk-dev] License issue

2014-10-13 Thread Olle E. Johansson
On 13 Oct 2014, at 15:46, Russell Bryant russ...@russellbryant.net wrote: On Mon, Oct 13, 2014 at 9:28 AM, Olle E. Johansson o...@edvina.net wrote: Hi! A customer showed interest in supporting the SIP GIN standard - registering for multiple contacts according to RFC 6140, part of the

Re: [asterisk-dev] License issue

2014-10-13 Thread Joshua Colp
Russell Bryant wrote: It should be fine. Users have never been able to use reviewboard without an active contributor license agreement. (AFAIK) In the past this was manually done but these days it's automatic (yay automatic!). The gist being like Russell said: If a patch is on reviewboard

Re: [asterisk-dev] [Code Review] 4071: scheduler: Fix a bug introduced by adding a delete flag to scheduled tasks

2014-10-13 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4071/#review13495 --- Ship it! Excellent work tracking this down. *shakes fist*

Re: [asterisk-dev] [Code Review] 4033: manager/config: Enhancements to support templates and non-unique category names via AMI

2014-10-13 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4033/ --- (Updated Oct. 13, 2014, 11:08 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 2783: Fix SIP/TLS reading - random connection drop

2014-10-13 Thread Matt Jordan
On Oct. 13, 2014, 7:32 a.m., Olle E Johansson wrote: What's the status of this patch? Should it be closed? I think it should be closed out. The long, tortuous history is as follows: (1) Mark Michelson, under ASTERISK-20212 (https://reviewboard.asterisk.org/r/2123) - as part of fixing

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Matthew Jordan
On Mon, Oct 13, 2014 at 12:58 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Hi I finally got the asterisk-testsuite accpted into Debian (I know, I need to get it updated). And just as it entered Unstable, it already got 3 bug reports on build failures:

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13497 --- Ship it! The new option should be mentioned in the UPGRADE

Re: [asterisk-dev] [Code Review] 4072: Testsuite: Tests for manager GetConfig and UpdateConfig AMI actions

2014-10-13 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4072/ --- (Updated Oct. 13, 2014, 4:21 p.m.) Status -- This change has been

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread George Joseph
On Mon, Oct 13, 2014 at 10:15 AM, Matthew Jordan mjor...@digium.com wrote: On Mon, Oct 13, 2014 at 12:58 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Hi I finally got the asterisk-testsuite accpted into Debian (I know, I need to get it updated). And just as it entered Unstable,

[asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4073/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/ --- (Updated Oct. 13, 2014, 12:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4073/#review13498 --- /trunk/res/res_pjsip/pjsip_configuration.c

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Joshua Colp
On Oct. 13, 2014, 5:33 p.m., Matt Jordan wrote: /trunk/res/res_pjsip/pjsip_configuration.c, line 1735 https://reviewboard.asterisk.org/r/4073/diff/1/?file=68003#file68003line1735 Alembic! Thinking about it, we also need to update Alembic with your optimistic

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Olle E Johansson
On Oct. 13, 2014, 7:33 p.m., Matt Jordan wrote: /trunk/res/res_pjsip/pjsip_configuration.c, line 1735 https://reviewboard.asterisk.org/r/4073/diff/1/?file=68003#file68003line1735 Alembic! Thinking about it, we also need to update Alembic with your optimistic

Re: [asterisk-dev] [Code Review] 4066: stasis_channels.c: Resolve unfinished Dials when doing masquerades (Part 2)

2014-10-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4066/#review13502 --- Ship it! Ship It! - Matt Jordan On Oct. 9, 2014, 12:22

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4073/ --- (Updated Oct. 13, 2014, 6:09 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-13 Thread Matt Jordan
On Oct. 13, 2014, 11:18 a.m., Matt Jordan wrote: /trunk/res/res_pjsip_sdp_rtp.c, lines 1097-1103 https://reviewboard.asterisk.org/r/3992/diff/2/?file=67982#file67982line1097 Blobs! Joshua Colp wrote: Per other review this needs alembic. And you're correct on the other

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/#review13503 --- /branches/12/bridges/bridge_native_rtp.c

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/#review13505 --- /branches/12/bridges/bridge_native_rtp.c

[asterisk-dev] [Code Review] 4074: AMI: Missing SetVar events when a channel inherits variables.

2014-10-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4074/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24415

Re: [asterisk-dev] [Code Review] 4074: AMI: Add missing VarSet events when a channel inherits variables.

2014-10-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4074/ --- (Updated Oct. 13, 2014, 2:54 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-13 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/ --- Review request for Asterisk Developers and Matt Jordan. Bugs:

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/#review13506 --- /branches/13/res/parking/parking_tests.c

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-13 Thread Jonathan Rose
On Oct. 13, 2014, 4:58 p.m., rmudgett wrote: /branches/13/res/parking/parking_tests.c, lines 60-64 https://reviewboard.asterisk.org/r/4075/diff/1/?file=68013#file68013line60 Why is chan in parentheses? Because I lazily copied this function from a macro and overlooked all of these

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-13 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/ --- (Updated Oct. 13, 2014, 5:18 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/#review13508 --- /branches/13/res/parking/parking_tests.c

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-13 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/ --- (Updated Oct. 13, 2014, 5:45 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4076: res_phoneprov: Create accessor for ast_phoneprov_std_variable_lookup.

2014-10-13 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4076/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Torrey Searle
Does this also mean there are official debian packages for all of the testsuite dependencies? If so, that would go along way to getting people to start using it :-) Torrey On 13 October 2014 18:28, George Joseph george.jos...@fairview5.com wrote: On Mon, Oct 13, 2014 at 10:15 AM, Matthew