Re: [asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4050/#review13510 --- /trunk/main/presencestate.c

Re: [asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

2014-10-14 Thread Olle E. Johansson
On 14 Oct 2014, at 15:51, Matt Jordan reviewbo...@asterisk.org wrote: exten = hint,SIP/aliceCustomPresence:alice Will *always* use the presence provided by SIP/alice, instead of the custom presence provider. That feels like a loss of functionality. Prior to this patch, we would only use

Re: [asterisk-dev] [Code Review] 3948: Asterisk does not respect outbound proxy when sending qualify requests

2014-10-14 Thread Matt Jordan
On Aug. 29, 2014, 6:04 p.m., Damian Ivereigh wrote: Thanks for all that info Matt. In answer to the question how should outboundproxy behave, perhaps it might be useful to detail my setup. I have a number of Asterisk servers on an internal network with a kamailio server and a media

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/#review13512 --- /branches/13/res/parking/parking_tests.c

[asterisk-dev] [Code Review] 4077: Test Suite: Unregister registered outbound registrations

2014-10-14 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4077/ --- Review request for Asterisk Developers. Repository: testsuite

[asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

2014-10-14 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4048/ --- (Updated Oct. 14, 2014, 11:16 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4066: stasis_channels.c: Resolve unfinished Dials when doing masquerades (Part 2)

2014-10-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4066/ --- (Updated Oct. 14, 2014, 11:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

2014-10-14 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4049/ --- (Updated Oct. 14, 2014, 11:44 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/#review13514 --- branches/12/main/config.c

Re: [asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/ --- (Updated Oct. 14, 2014, 11:13 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4076: res_phoneprov: Create accessor for ast_phoneprov_std_variable_lookup.

2014-10-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4076/#review13513 --- The undefined symbol warning is now gone on Asterisk startup.

Re: [asterisk-dev] [Code Review] 4076: res_phoneprov: Create accessor for ast_phoneprov_std_variable_lookup.

2014-10-14 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4076/ --- (Updated Oct. 14, 2014, 12:02 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4076: res_phoneprov: Create accessor for ast_phoneprov_std_variable_lookup.

2014-10-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4076/#review13515 --- Ship it! Ship It! - rmudgett On Oct. 14, 2014, 1:02 p.m.,

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

2014-10-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13516 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-14 Thread Matt Jordan
On Oct. 13, 2014, 2:04 p.m., rmudgett wrote: /branches/12/bridges/bridge_native_rtp.c, line 143 https://reviewboard.asterisk.org/r/3997/diff/3/?file=68004#file68004line143 Needs to be if (bc0 == bc1) to handle the first channel joining the bridge tech case. If that's

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/#review13518 --- /branches/12/bridges/bridge_native_rtp.c

Re: [asterisk-dev] [Code Review] 4071: scheduler: Fix a bug introduced by adding a delete flag to scheduled tasks

2014-10-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4071/ --- (Updated Oct. 14, 2014, 1:49 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4063: res_pjsip_session/res_pjsip_sdp_rtp: Fix a variety of situations where Asterisk would incorrectly reject offers

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4063/ --- Review request for Asterisk Developers and Joshua Colp. Bugs:

[asterisk-dev] [Code Review] 4079: testsuite: Update Offer/Answer PJSIP Tests

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4079/ --- Review request for Asterisk Developers and Joshua Colp. Repository:

Re: [asterisk-dev] [Code Review] 4079: testsuite: Update Offer/Answer PJSIP Tests

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4079/ --- (Updated Oct. 14, 2014, 2:07 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4079: testsuite: Update Offer/Answer PJSIP Tests

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4079/ --- (Updated Oct. 14, 2014, 2:07 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-14 Thread Matt Jordan
On Oct. 14, 2014, 1:46 p.m., Joshua Colp wrote: /branches/12/bridges/bridge_native_rtp.c, line 143 https://reviewboard.asterisk.org/r/3997/diff/3/?file=68004#file68004line143 No, AST_LIST_FIRST and AST_LIST_LAST would return the same thing since it's a linked list containing one

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-14 Thread Matt Jordan
On Oct. 13, 2014, 2:04 p.m., rmudgett wrote: /branches/12/bridges/bridge_native_rtp.c, line 234 https://reviewboard.asterisk.org/r/3997/diff/3/?file=68004#file68004line234 Does glue1 need to be checked for NULL before use here? No. You're guaranteed to have both bridge channels,

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/ --- (Updated Oct. 14, 2014, 2:11 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/#review13521 --- branches/12/include/asterisk/config.h

Re: [asterisk-dev] [Code Review] 3948: Asterisk does not respect outbound proxy when sending qualify requests

2014-10-14 Thread Damian Ivereigh
On Aug. 29, 2014, 11:04 p.m., Damian Ivereigh wrote: Thanks for all that info Matt. In answer to the question how should outboundproxy behave, perhaps it might be useful to detail my setup. I have a number of Asterisk servers on an internal network with a kamailio server and a media

Re: [asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/ --- (Updated Oct. 14, 2014, 2:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/#review13523 --- Ship it! Ship It! - Matt Jordan On Oct. 14, 2014, 3:33

Re: [asterisk-dev] [Code Review] 4078: config: Fix SEGV in unit test with MALLOC_DEBUG

2014-10-14 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/ --- (Updated Oct. 14, 2014, 3:46 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/ --- (Updated Oct. 14, 2014, 4:10 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4082: Incomplete channel originate handling with ARI

2014-10-14 Thread greenfieldtech
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4082/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24412

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/ --- (Updated Oct. 14, 2014, 4:49 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

2014-10-14 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/#review13525 --- Ship it! Ship It! - rmudgett On Oct. 14, 2014, 4:49 p.m.,