[asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4125/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24466 https://i

[asterisk-dev] [Code Review] 4124: audiohooks: Clean references to formats

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4124/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24465 https://i

[asterisk-dev] AstriDevCon Summary

2014-10-28 Thread Matthew Jordan
Hey everyone! Last week was AstriDevCon, and we had a great turn out with nearly 50 developers from all over the world. We had a lot of great discussion about a variety of topics, the notes of which are up on the Asterisk wiki: https://wiki.asterisk.org/wiki/display/AST/AstriDevCon+2014 Keep in

[asterisk-dev] [Code Review] 4123: app_agent_pool: Make agent alert interruptable by DTMF.

2014-10-28 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4123/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24257 and ASTERISK-

[asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4122/ --- Review request for Asterisk Developers and Scott Griepentrog. Repository:

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- (Updated Oct. 28, 2014, 6:06 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Phil Mickelson
I can't speak for anyone else, but my vision would be for an easy to use application that would allow for all the options you now have and even more. The major difference is that you wouldn't have to try to figure out all the complexities of the current dialplan. For example, you could have a dra

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Ben Langfeld
On 28 October 2014 19:47, Derek Andrew wrote: > What is the alternative to the dial plan? Is everyone talking about > getting rid of the statements like: > exten => s,1, > > what is the alternative? > Remote applications based on APIs like ARI. This is the start of the discussion, and please rem

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Derek Andrew
What is the alternative to the dial plan? Is everyone talking about getting rid of the statements like: exten => s,1, what is the alternative? -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-d

Re: [asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4121/ --- (Updated Oct. 28, 2014, 5:19 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4121/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4115: res_fax: fax gateway frames leak

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4115/ --- (Updated Oct. 28, 2014, 3:50 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4110: manager: acl_change_sub leaks

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4110/ --- (Updated Oct. 28, 2014, 3:41 p.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 4119: pjsip: handle outbound unregister correctly

2014-10-28 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4119/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24411 https://i

Re: [asterisk-dev] [Code Review] 4117: Fix building chan_phone on big endian systems

2014-10-28 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4117/#review13603 --- Ship it! Ship It! - Jonathan Rose On Oct. 28, 2014, 12:46 p

[asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly

2014-10-28 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Ben Langfeld
On 28 October 2014 14:44, Russell Bryant wrote: > On Tue, Oct 28, 2014 at 11:24 AM, Phil Mickelson > wrote: > >> So. After all this I'm tired of hearing the same argument. I've decided >> to take the other side. >> >> I have seen the progression of Asterisk for the last 5+ years. I was at >>

[asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-28 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4118/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 4117: Fix building chan_phone on big endian systems

2014-10-28 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4117/ --- Review request for Asterisk Developers. Bugs: https://issues.asterisk.org/

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Russell Bryant
On Tue, Oct 28, 2014 at 11:24 AM, Phil Mickelson wrote: > So. After all this I'm tired of hearing the same argument. I've decided > to take the other side. > > I have seen the progression of Asterisk for the last 5+ years. I was at > Astricon when it was held in the DC area and the last one in

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Phil Mickelson
So. After all this I'm tired of hearing the same argument. I've decided to take the other side. I have seen the progression of Asterisk for the last 5+ years. I was at Astricon when it was held in the DC area and the last one in Atlanta (I wish you'd go back there instead of Vegas!). I tried t

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Paul Albrecht
Not asking for unqualified promises about the future of Asterisk. Simply asking for an acknowledgment of the obvious, that is, Asterisk without the dial plan wouldn’t be Asterisk. The fact that one is not forthcoming raises a red flag with respect to the future of Asterisk. Furthermore, adding

Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4111/ --- (Updated Oct. 28, 2014, 6:17 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4113/ --- (Updated Oct. 28, 2014, 6:11 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

2014-10-28 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4112/ --- (Updated Oct. 28, 2014, 6:07 a.m.) Status -- This change has been mar