Re: [asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4129/ --- (Updated Oct. 31, 2014, 8:39 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4136: testsuite: Add escaped semicolons tests for UpdateConfig and dialplan save

2014-10-31 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4136/ --- (Updated Oct. 31, 2014, 9:10 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-31 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4129/#review13642 --- Ship it! Ship It! - Matt Jordan On Oct. 31, 2014, 8:39

Re: [asterisk-dev] [Code Review] 4107: Wiki: Some new PJSIP-related pages

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4107/#review13644 --- Kevin's issues have been addressed now. - Mark Michelson On

Re: [asterisk-dev] [Code Review] 4107: Wiki: Some new PJSIP-related pages

2014-10-31 Thread Mark Michelson
On Oct. 29, 2014, 10:07 p.m., Kevin Harwell wrote: Configuring res_pjsip for Presence Subscriptions Under the Configuration section, 3rd paragraph, the context option description - (just to be sure) the subscribing endpoint's context must be set to that of the hint?

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- (Updated Oct. 31, 2014, 3:58 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4119: pjsip: handle outbound unregister correctly

2014-10-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4119/ --- (Updated Oct. 31, 2014, 11:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4134: testsute: Add 'add-relative-to-search-path' handler to TestModuleLoader

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4134/#review13645 --- Ship it! asterisk/trunk/lib/python/asterisk/test_runner.py

Re: [asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-31 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4118/ --- (Updated Oct. 31, 2014, 11:25 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4129/ --- (Updated Oct. 31, 2014, 11:33 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4107: Wiki: Some new PJSIP-related pages

2014-10-31 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4107/#review13646 --- Ship it! Ship It! - Kevin Harwell On Oct. 22, 2014, 4:37

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4138/#review13647 --- /branches/1.8/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 4134: testsute: Add 'add-relative-to-search-path' handler to TestModuleLoader

2014-10-31 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4134/ --- (Updated Oct. 31, 2014, 11 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-31 Thread Corey Farrell
On Oct. 31, 2014, 12:58 p.m., Mark Michelson wrote: /branches/1.8/apps/app_voicemail.c, line 5800 https://reviewboard.asterisk.org/r/4138/diff/1/?file=68670#file68670line5800 My assumption here is that you initially created this patch for 11, 12, or 13, and then backported to

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/#review13650 --- /branches/11/funcs/func_jitterbuffer.c

Re: [asterisk-dev] [Code Review] 4136: testsuite: Add escaped semicolons tests for UpdateConfig and dialplan save

2014-10-31 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4136/ --- (Updated Oct. 31, 2014, 11:14 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-31 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4138/ --- (Updated Oct. 31, 2014, 1:15 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-31 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/ --- (Updated Oct. 31, 2014, 1:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/#review13651 --- /branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/#review13652 --- Ship it! Ship It! - rmudgett On Oct. 31, 2014, 12:20 p.m.,

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4138/#review13653 --- Ship it! Ship It! - Mark Michelson On Oct. 31, 2014, 5:15

Re: [asterisk-dev] [Code Review] 4107: Wiki: Some new PJSIP-related pages

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4107/ --- (Updated Oct. 31, 2014, 8:12 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread Mark Michelson
On Oct. 31, 2014, 5:39 p.m., rmudgett wrote: /branches/12/main/bridge.c, line 4253 https://reviewboard.asterisk.org/r/4135/diff/2/?file=68675#file68675line4253 I have a feeling that the race also affects parking here. If so then holding the bridge lock is not a viable solution.

[asterisk-dev] [Code Review] 4139: stun: fix size of attribute string to match rfc

2014-10-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4139/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread rmudgett
On Oct. 31, 2014, 12:39 p.m., rmudgett wrote: /branches/12/main/bridge.c, line 4253 https://reviewboard.asterisk.org/r/4135/diff/2/?file=68675#file68675line4253 I have a feeling that the race also affects parking here. If so then holding the bridge lock is not a viable solution.

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-31 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4122/ --- (Updated Oct. 31, 2014, 8:02 p.m.) Status -- This change has been