[asterisk-dev] Asterisk 12.7.0-rc1 Now Available

The Asterisk Development Team has announced the first release candidate of Asterisk 12.7.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.7.0-rc1 resolves several issues reported by the community and wo

[asterisk-dev] Asterisk 11.14.0-rc1 Now Available

The Asterisk Development Team has announced the first release candidate of Asterisk 11.14.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.14.0-rc1 resolves several issues reported by the community and

[asterisk-dev] Asterisk 1.8.32.0-rc1 Now Available

The Asterisk Development Team has announced the first release candidate of Asterisk 1.8.32.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 1.8.32.0-rc1 resolves several issues reported by the community an

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

> On Nov. 3, 2014, 1:12 p.m., rmudgett wrote: > > Minor nit. > > > > Does the patch still fix the reporter's memory leak? Mostly, yes (as much as the original patch). I'm not sure it can be fixed completely. I tested with the reporters sip.conf. Each peer originally allocated 2000 bytes fo

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 3, 2014, 1:53 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4143: testsuite: Close HTTP connections when test is complete to prevent reported leaks in tests/phoneprov/res_phoneprov and tests/manager/config

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4143/#review13662 --- Ship it! - Matt Jordan On Nov. 2, 2014, 10:46 p.m., Corey Fa

Re: [asterisk-dev] [Code Review] 4144: testsuite: Sort tests by name after loading

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4144/#review13661 --- Ship it! Ship It! - Matt Jordan On Nov. 2, 2014, 10:55 p.m.

Re: [asterisk-dev] [Code Review] 4142: func_talkdetect: Fix stasis message leak in audiohook callback

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4142/#review13660 --- Ship it! Eek - that's what I get for eschewing usage of RAII_V

Re: [asterisk-dev] [Code Review] 4140: res_http_websockets: Module reference decrease below zero

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4140/#review13659 --- Ship it! Ship It! - Matt Jordan On Nov. 2, 2014, 1:14 a.m.,

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13658 --- Ship it! Minor nit. Does the patch still fix the reporter's m

[asterisk-dev] [Code Review] 4146: res_pjsip: If an endpoint is associated with the dialog place it on the messag early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4146/ --- Review request for Asterisk Developers. Bugs: AST-1459 https://issues.

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 3, 2014, 12:55 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4137: res_pjsip: Add disable_tcp_switch option.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4137/ --- (Updated Nov. 3, 2014, 11:54 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4123: app_agent_pool: Make agent alert interruptable by DTMF.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4123/ --- (Updated Nov. 3, 2014, 11:31 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

> On Oct. 29, 2014, 6:55 p.m., rmudgett wrote: > > 1) In stringfields.h:ast_string_field_ptr_set_by_fields(), the __p__ and > > ptr pointers are the same by initialization so the test for *__p__ != *ptr > > is always false and will not release the old string value when > > __ast_string_field_a

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13656 --- /branches/11/include/asterisk/stringfields.h

[asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] Fwd: [asterisk-commits] mjordan: branch 12 r426995 - /branches/12/res/res_stasis.c

Matthew Jordan wrote: On Sun, Nov 2, 2014 at 3:29 PM, Matthew Jordan wrote: On Sun, Nov 2, 2014 at 1:27 AM, Corey Farrell wrote: If it's possible for apps_registry to be NULL then it's possible for the condition to race. Maybe we need to use AO2_GLOBAL_OBJ_STATIC? Could this issue apply to

Re: [asterisk-dev] [asterisk-commits] file: trunk r427112 - in /trunk: channels/ channels/pjsip/ configs/samples/ c...

Matthew Jordan wrote: Should have caught this in the review, but do you mind updating the CHANGES file for this as well? :-) Done! But hey - I remembered alembic! -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.dig

Re: [asterisk-dev] Fwd: [asterisk-commits] mjordan: branch 12 r426995 - /branches/12/res/res_stasis.c

On Sun, Nov 2, 2014 at 3:29 PM, Matthew Jordan wrote: > On Sun, Nov 2, 2014 at 1:27 AM, Corey Farrell wrote: >> If it's possible for apps_registry to be NULL then it's possible for the >> condition to race. Maybe we need to use AO2_GLOBAL_OBJ_STATIC? Could this >> issue apply to the other globa

Re: [asterisk-dev] [asterisk-commits] file: trunk r427112 - in /trunk: channels/ channels/pjsip/ configs/samples/ c...

Should have caught this in the review, but do you mind updating the CHANGES file for this as well? :-) On Mon, Nov 3, 2014 at 8:45 AM, SVN commits to the Asterisk project wrote: > Author: file > Date: Mon Nov 3 08:45:01 2014 > New Revision: 427112 > > URL: http://svnview.digium.com/svn/asterisk?

Re: [asterisk-dev] [Code Review] 4103: chan_pjsip: Add 'moh_passthrough' option for passing through musiconhold requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4103/ --- (Updated Nov. 3, 2014, 8:45 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

> On Oct. 29, 2014, 7:55 p.m., rmudgett wrote: > > 1) In stringfields.h:ast_string_field_ptr_set_by_fields(), the __p__ and > > ptr pointers are the same by initialization so the test for *__p__ != *ptr > > is always false and will not release the old string value when > > __ast_string_field_a

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 3, 2014, 8:29 a.m.) Review request for Asterisk Developers.