[asterisk-dev] unsubscribe

2014-11-11 Thread Peter Hyeroba
unsubscrube -- Hyeroba Wegulo Peter Managing Director Jezitech Solutions Limited P.O.Box 22861, Plot 27, Sir. Apollo Kagwa Road Kampala Uganda. website: www.jezitech.com Phones : +256-414-533238, +256-392-897155 Mobiles: +256-782-479192, +256-718-206135 other emails: jezit...@yahoo.com, phyer..

[asterisk-dev] [Code Review] 4172: Testsuite: tests for res_pjsip_config_wizard

2014-11-11 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4172/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

[asterisk-dev] [Code Review] 4170: testsuite: Delete bridges on completion for a bunch of rest_api tests

2014-11-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4170/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4099/#review13731 --- Ship it! Ship It! - Mark Michelson On Nov. 11, 2014, 8:14 p

[asterisk-dev] [Code Review] 4167: Allow mis-dialed DTMF-initiated transfers to be re-attempted.

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4167/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 4168: Testsuite: transferdialattempts test

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4168/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4164: res_pjsip_outbound_registration: stack overflow when using non-default sorcery wizard

2014-11-11 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4164/ --- (Updated Nov. 11, 2014, 2:56 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4164: res_pjsip_outbound_registration: stack overflow when using non-default sorcery wizard

2014-11-11 Thread Kevin Harwell
> On Nov. 11, 2014, 11:09 a.m., Mark Michelson wrote: > > branches/12/res/res_pjsip_outbound_registration.c, lines 1315-1324 > > > > > > This has the possibility to return two different types. Retrieving a > > reg

[asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4166/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

2014-11-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4099/ --- (Updated Nov. 11, 2014, 8:14 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13728 --- Ship it! My 2 cents on the option: I think having a separate o

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p->refer

2014-11-11 Thread Mark Michelson
> On Nov. 11, 2014, 6:43 p.m., Mark Michelson wrote: > > If I understand the purpose of p->refer correctly, it's supposed to be > > details relating to a specific REFER (or REFER-esque in some cases) > > transaction. I think that any in-dialog places where p->refer may be > > allocated, the pr

Re: [asterisk-dev] Should internal timer implementing session timers be stopped and restarted on response to re-invite?

2014-11-11 Thread Mark Michelson
On 11/11/2014 12:46 PM, Dave WOOLLEY wrote: In trying to do a back port of some of the fixes to session timers, we encountered a situation where multiple refreshes are sent in quick succession (with incrementing CSEQ values). Asterisk survives for a little while, but then gets very confused.

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p->refer

2014-11-11 Thread Corey Farrell
> On Nov. 11, 2014, 1:43 p.m., Mark Michelson wrote: > > If I understand the purpose of p->refer correctly, it's supposed to be > > details relating to a specific REFER (or REFER-esque in some cases) > > transaction. I think that any in-dialog places where p->refer may be > > allocated, the pr

Re: [asterisk-dev] [Code Review] 4159: chan_sip: Add missing braces on if, else, while and for

2014-11-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4159/ --- (Updated Nov. 11, 2014, 2:17 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4159: chan_sip: Add missing braces on if, else, while and for

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4159/#review13723 --- I fall into the camp of being not in favor of this patch. My ma

[asterisk-dev] Should internal timer implementing session timers be stopped and restarted on response to re-invite?

2014-11-11 Thread Dave WOOLLEY
In trying to do a back port of some of the fixes to session timers, we encountered a situation where multiple refreshes are sent in quick succession (with incrementing CSEQ values). Asterisk survives for a little while, but then gets very confused. Looking at the code, it seems to me that ever

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p->refer

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4160/#review13722 --- If I understand the purpose of p->refer correctly, it's suppose

Re: [asterisk-dev] [Code Review] 4162: pbx: Fix crash in off-nominal when add_priority encounters a failure.

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4162/#review13721 --- Ship it! Ship It! - Mark Michelson On Nov. 10, 2014, 2:06 p

Re: [asterisk-dev] [Code Review] 4164: res_pjsip_outbound_registration: stack overflow when using non-default sorcery wizard

2014-11-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4164/#review13720 --- branches/12/res/res_pjsip_outbound_registration.c