On Nov. 5, 2014, 12:49 p.m., Joshua Colp wrote:
/tags/12.4.0/main/rtp_engine.c, lines 2012-2018
https://reviewboard.asterisk.org/r/4093/diff/1/?file=68394#file68394line2012
This is not compliant to the way L16 is supposed to be declared within
SDP. The payload name is supposed to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4175/#review13740
---
Ship it!
/branches/13/main/features.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4163/
---
(Updated Nov. 13, 2014, 9:42 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4174/#review13741
---
Ship it!
Ship It!
/branches/12/res/res_pjsip_pubsub.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4170/#review13743
---
Ship it!
Ship It!
- Joshua Colp
On Nov. 11, 2014, 10:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4160/#review13744
---
Ship it!
Ship It!
- Mark Michelson
On Nov. 12, 2014, 8:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4166/#review13745
---
With the fix being made to the leaked bridge in Asterisk, is
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4167/#review13746
---
Ship it!
Ship It!
- Joshua Colp
On Nov. 12, 2014, 6:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4155/
---
(Updated Nov. 13, 2014, 10:53 a.m.)
Review request for Asterisk
The same rule in the RFC covers the case where Session-Expires is sent, but no
refresher is sent as covers the case where no Session-Expires is sent at all,
as long as session timers are supported:
UAC supports? refresher parameter refresher parameter
in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4155/#review13747
---
branches/12/res/res_pjsip_nat.c
I don't believe that the code that adds Required: timers to a 200 OK response
will work, even in Asterisk 13, current branch version.
In my back port, it produces an error saying headers cannot be added after
lines have been added. The same conditions for this seem to apply in version
13:
In
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4177/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4177/#review13749
---
Ship it!
Looks good to me. The only suggestion I have is to
On 11/13/2014 12:34 PM, Dave WOOLLEY wrote:
I don’t believe that the code that adds Required: timers to a 200 OK
response will work, even in Asterisk 13, current branch version.
In my back port, it produces an error saying headers cannot be added
after lines have been added. The same
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4178/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24514
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/
---
Review request for Asterisk Developers.
Repository: Asterisk
On Nov. 13, 2014, 11:06 a.m., Joshua Colp wrote:
Ship It!
I have to look into this again now that kmoore has committed testsuite revision
5921, many of these changes use the StasisEnd event to do cleanup.
- Corey
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/#review13751
---
Could this be solved by: read(ast_consock, buf, sizeof(buf) -
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/#review13752
---
I typically take issue with patches like this because it's not
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4164/
---
(Updated Nov. 13, 2014, 3:56 p.m.)
Status
--
This change has been
On Nov. 13, 2014, 11:30 a.m., Mark Michelson wrote:
With the fix being made to the leaked bridge in Asterisk, is this change
still required? Does hanging up self.channels[1] not result in
self.channels[3] and the bridge being destroyed as expected?
Still required, I'm guessing that
On Nov. 13, 2014, 11:30 a.m., Mark Michelson wrote:
With the fix being made to the leaked bridge in Asterisk, is this change
still required? Does hanging up self.channels[1] not result in
self.channels[3] and the bridge being destroyed as expected?
Corey Farrell wrote:
Still
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4109/#review13756
---
Ship it!
Ship It!
- Matt Jordan
On Oct. 22, 2014, 5:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4168/#review13755
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/#review13759
---
Ship it!
Ship It!
- Matt Jordan
On Nov. 7, 2014, 12:31
On Nov. 13, 2014, 4:30 p.m., Mark Michelson wrote:
With the fix being made to the leaked bridge in Asterisk, is this change
still required? Does hanging up self.channels[1] not result in
self.channels[3] and the bridge being destroyed as expected?
Corey Farrell wrote:
Still
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4156/#review13757
---
/asterisk/trunk/lib/python/asterisk/pcap.py
On Nov. 5, 2014, 11:43 a.m., Joshua Colp wrote:
Matt brought it up that this is actually a backwards incompatible change -
specifically changing priority into a string from an integer. What about
having label as a separate argument that is optional? If present it's
treated as a label
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4183/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24520
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4183/
---
(Updated Nov. 13, 2014, 5:34 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4165/
---
(Updated Nov. 13, 2014, 5:35 p.m.)
Status
--
This change has been
32 matches
Mail list logo
