Re: [asterisk-dev] [Code Review] 4184: app_confbridge: Don't delay playing 'you have been kicked' prompts to end_marked users when there are only end_marked users in the conference

2014-11-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4184/ --- (Updated Nov. 16, 2014, 9:05 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

2014-11-16 Thread Frankie Chin
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4093/ --- (Updated Nov. 17, 2014, 2:51 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

2014-11-16 Thread Frankie Chin
> On Nov. 5, 2014, 12:49 p.m., Joshua Colp wrote: > > /tags/12.4.0/main/rtp_engine.c, lines 2012-2018 > > > > > > This is not compliant to the way L16 is supposed to be declared within > > SDP. The payload name is

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-16 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/ --- (Updated Nov. 16, 2014, 6:38 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

2014-11-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4187/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24508 https://i

Re: [asterisk-dev] Process change proposal: allowing new features and improvements into release branches

2014-11-16 Thread Matthew Jordan
On Wed, Nov 12, 2014 at 6:44 AM, Leif Madsen wrote: > Matt and Community, > > This looks great to me. I've tweaked the wiki page a little bit to better > reflect the branch merging since 1.8 is now EOL. Otherwise, I think this > meets a very nice balance between "allowing features in to keep pace

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

2014-11-16 Thread greenfieldtech
> On Nov. 5, 2014, 5:43 p.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

2014-11-16 Thread Michael K.
> On Nov. 5, 2014, 1:55 p.m., Joshua Colp wrote: > > I'm fine with putting this in after looking at how it impacts behavior and > > real-world use. If you would like to fix the error that Jeremy mentioned > > feel free to. If you would like to also make an addition to the 'CHANGES' > > file th