Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

> On Nov. 18, 2014, 6:45 p.m., rmudgett wrote: > > Ship It! Corey: is this an issue in 12+ only because the code is different? Or did the test simply not fail in 11-? While I hope the former, from your comment [1] on the ticket I cannot deduce which it is. [1] "It appears that the issue I th

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

> On Nov. 18, 2014, 1:45 p.m., rmudgett wrote: > > Ship It! > > wdoekes wrote: > Corey: is this an issue in 12+ only because the code is different? Or did > the test simply not fail in 11-? > > While I hope the former, from your comment [1] on the ticket I cannot > deduce which it

Re: [asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4187/ --- (Updated Nov. 19, 2014, 5:50 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/ --- (Updated Nov. 19, 2014, 6:40 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4099/ --- (Updated Nov. 19, 2014, 6:56 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

> On Nov. 18, 2014, 12:45 p.m., rmudgett wrote: > > Ship It! > > wdoekes wrote: > Corey: is this an issue in 12+ only because the code is different? Or did > the test simply not fail in 11-? > > While I hope the former, from your comment [1] on the ticket I cannot > deduce which i

Re: [asterisk-dev] [Code Review] 4194: ast_str: Fix improper member access to struct ast_str members.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4194/ --- (Updated Nov. 19, 2014, 10:38 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/ --- (Updated Nov. 19, 2014, 11:35 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/ --- Review request for Asterisk Developers and Joshua Colp. Repository: Asteri

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/#review13823 --- /branches/13/main/bridge_basic.c

[asterisk-dev] [Code Review] 4197: testsuite: Update cleanup-test-remnants to clean /var/tmp/asterisk-testsuite and ./logs/*

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4197/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/#review13824 --- /branches/13/main/bridge_basic.c

[asterisk-dev] [Code Review] 4198: testsuite: Add --cleanup option to runtests.py

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4198/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/ --- (Updated Nov. 19, 2014, 12:14 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- (Updated Nov. 19, 2014, 1:30 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

> On Nov. 19, 2014, 12:47 p.m., rmudgett wrote: > > /branches/13/main/bridge_basic.c, lines 3032-3036 > > > > > > Would we want these sounds to be interruptible with a digit for the > > next attempt? > > > >

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/ --- (Updated Nov. 19, 2014, 4:57 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/#review13826 --- /branches/13/main/bridge_basic.c

[asterisk-dev] [Code Review] 4199: test_channel_feature_hooks.c: Fix unit test for DTMF hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4199/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 4200: manager: Fix could not extend string messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4200/ --- Review request for Asterisk Developers. Repository: Asterisk Description