Re: [asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/#review13900 --- The current patch is missing the second test for the AMI event.

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

> On Dec. 4, 2014, 5:08 p.m., Kevin Harwell wrote: > > branches/12/main/sorcery.c, lines 1268-1272 > > > > > > This particular observer's invocation was pushed to the taskprocessor. > > Do the replacement(s)/new

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/#review13902 --- Ship it! Ship It! - Kevin Harwell On Dec. 3, 2014, 11:36 a.

[asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4242/ --- Review request for Asterisk Developers. Bugs: https://issues.asterisk.org/

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/ --- (Updated Dec. 5, 2014, 9:01 a.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4242/ --- (Updated Dec. 5, 2014, 4:10 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/#review13903 --- Ship it! Ship It! - Joshua Colp On Dec. 5, 2014, 4:01 p.m.,

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/ --- (Updated Dec. 5, 2014, 11:05 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4242/#review13904 --- trunk/apps/app_meetme.c

Re: [asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4242/ --- (Updated Dec. 5, 2014, 6:49 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3683: testsuite: Add a test for CELGenUserEvent

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3683/ --- (Updated Dec. 5, 2014, 12:55 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4242/#review13905 --- Ship it! Ship It! - rmudgett On Dec. 5, 2014, 12:49 p.m., n

Re: [asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

> On Dec. 5, 2014, 1:31 p.m., rmudgett wrote: > > Ship It! This should be applied to v11+ as this patch is really a bug fix. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4

[asterisk-dev] [Code Review] 4244: ari: Add originate with linkedid test.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4244/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24552 https://i

[asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24552 https://i

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/#review13908 --- I'm concerned that the use of ast_channel_internal_set_fake_ids

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/#review13907 --- Since channel unique ids can be assigned by the user, they now

Re: [asterisk-dev] [Code Review] 4244: ari: Add originate with linkedid test.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4244/ --- (Updated Dec. 5, 2014, 9:04 p.m.) Status -- This change has been disc

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/ --- (Updated Dec. 5, 2014, 9:10 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

> On Dec. 5, 2014, 9:02 p.m., rmudgett wrote: > > /branches/13/res/ari/resource_channels.c, lines 755-757 > > > > > > This channel cannot be made to /continue in dialplan when the Stasis > > application exits. Tha

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/#review13910 --- /branches/13/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify an originator when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/ --- (Updated Dec. 5, 2014, 9:21 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/ --- (Updated Dec. 5, 2014, 9:21 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify an originator when originating calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/ --- (Updated Dec. 5, 2014, 9:27 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4244: ari: Add originate with originator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4244/ --- (Updated Dec. 5, 2014, 9:44 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4245: ARI/AMI: Include language in standard channel snapshot output

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4245/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24553 https://i