Re: [asterisk-dev] git migration update

2014-12-23 Thread Leif Madsen
On 22 December 2014 at 18:34, Russell Bryant wrote: > On Mon, Dec 22, 2014 at 3:08 PM, George Joseph < > george.jos...@fairview5.com> wrote: > >> On Mon, Dec 22, 2014 at 12:03 PM, Samuel Galarneau > > wrote: >> >>> 2 - we have a few options as far as team branches go. We could configure >>> user

[asterisk-dev] [Code Review] 4294: testsuite: Add a test for user_eq_phone setting in PJSIP

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4294/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4294: testsuite: Add a test for user_eq_phone setting in PJSIP

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4294/ --- (Updated Dec. 23, 2014, 6:46 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14028 --- /trunk/main/rtp_engine.c

Re: [asterisk-dev] [Code Review] 4285: Bug fixes for ARI Originate/Continue with label support (Continuation of /r/4101)

2014-12-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4285/#review14029 --- /branches/13/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4293: testsuite: Add a test for PJSIP keep alive packets for connection oriented transports

2014-12-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4293/#review14030 --- Ship it! Ship It! - Joshua Colp On Dec. 23, 2014, 4:19 a.m.

Re: [asterisk-dev] [Code Review] 4294: testsuite: Add a test for user_eq_phone setting in PJSIP

2014-12-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4294/#review14031 --- Ship it! Ship It! - Joshua Colp On Dec. 23, 2014, 12:46 p.m

Re: [asterisk-dev] [Code Review] 4281: Testsuite: Single channel redirect tests

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4281/#review14032 --- Ship it! /asterisk/trunk/tests/manager/redirect/single/app/te

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review14033 --- /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py <

Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/#review14034 --- /asterisk/trunk/tests/rest_api/external_interaction/blind_tran

Re: [asterisk-dev] [Code Review] 4272: Testsuite: Verify that bridged channels originated into Stasis and AMI Redirect interoperate properly

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4272/#review14035 --- asterisk/trunk/tests/rest_api/external_interaction/ami_redirec

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14036 --- /asterisk/trunk/lib/python/asterisk/bridge_test_case.py

Re: [asterisk-dev] [Code Review] 4291: Testsuite: Add external bridging tests for Stasis application interaction - Stasis bridge to non-stasis application.

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4291/#review14037 --- Ship it! - Matt Jordan On Dec. 22, 2014, 3:51 p.m., jbigelow

Re: [asterisk-dev] [Code Review] 4289: pjsip_options: Fix duplicate qualify schedules on reload.

2014-12-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4289/ --- (Updated Dec. 23, 2014, 9:09 a.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4295: test_astobj2: Fix warning for missing trailing slash in category.

2014-12-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4295/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4290: pjsip_options: Fix continued qualifies after endpoint/aor deletion.

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4290/#review14038 --- branches/13/res/res_pjsip/pjsip_options.c

Re: [asterisk-dev] [Code Review] 4289: pjsip_options: Fix duplicate qualify schedules on reload.

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4289/#review14039 --- branches/13/res/res_pjsip/pjsip_options.c

Re: [asterisk-dev] [Code Review] 4289: pjsip_options: Fix duplicate qualify schedules on reload.

2014-12-23 Thread George Joseph
> On Dec. 23, 2014, 9:50 a.m., Matt Jordan wrote: > > branches/13/res/res_pjsip/pjsip_options.c, lines 962-966 > > > > > > Is this still needed with the patch from > > https://reviewboard.asterisk.org/r/4290/? > >

Re: [asterisk-dev] [Code Review] 4289: pjsip_options: Fix duplicate qualify schedules on reload.

2014-12-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4289/ --- (Updated Dec. 23, 2014, 9:59 a.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4290: pjsip_options: Fix continued qualifies after endpoint/aor deletion.

2014-12-23 Thread George Joseph
> On Dec. 23, 2014, 9:46 a.m., Matt Jordan wrote: > > branches/13/res/res_pjsip/pjsip_options.c, lines 1009-1021 > > > > > > Since we are now removing all qualifies during a reload, do we still > > need an explici

Re: [asterisk-dev] Adding the support for NACK in asterisk

2014-12-23 Thread Nitesh Bansal
Hi Matt, Thanks for this nice explanation. Well, we still don't know if we are going to do it or not, it is still a pending decision. But i do have some comments ref your response, responding inline. General comment: By adding the support for NACK, i meant just adding the ability to forward th

Re: [asterisk-dev] [Code Review] 4295: test_astobj2: Fix warning for missing trailing slash in category.

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4295/#review14042 --- Ship it! Ship It! - Matt Jordan On Dec. 23, 2014, 10:32 a.m

Re: [asterisk-dev] [Code Review] 4290: pjsip_options: Fix continued qualifies after endpoint/aor deletion.

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4290/#review14043 --- Ship it! Ship It! - Matt Jordan On Dec. 22, 2014, 12:21 p.m

Re: [asterisk-dev] [Code Review] 4281: Testsuite: Single channel redirect tests

2014-12-23 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4281/#review14044 --- /asterisk/trunk/tests/manager/redirect/single/app/test-config.

Re: [asterisk-dev] git migration update

2014-12-23 Thread Paul Belanger
On Tue, Dec 23, 2014 at 7:20 AM, Leif Madsen wrote: > On 22 December 2014 at 18:34, Russell Bryant > wrote: >> >> On Mon, Dec 22, 2014 at 3:08 PM, George Joseph >> wrote: >>> >>> On Mon, Dec 22, 2014 at 12:03 PM, Samuel Galarneau >>> wrote: 2 - we have a few options as far as team bra

[asterisk-dev] [Code Review] 4296: PJSIP: Fix bugs and improve documentation of remote attended transfers

2014-12-23 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4296/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24376 https://i

Re: [asterisk-dev] [Code Review] 4295: test_astobj2: Fix warning for missing trailing slash in category.

2014-12-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4295/ --- (Updated Dec. 23, 2014, 5:16 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4290: pjsip_options: Fix continued qualifies after endpoint/aor deletion.

2014-12-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4290/ --- (Updated Dec. 23, 2014, 5:18 p.m.) Status -- This change has been mar