Re: [asterisk-dev] [Code Review] 4296: PJSIP: Fix bugs and improve documentation of remote attended transfers

2014-12-30 Thread Joshua Colp
> On Dec. 24, 2014, 9:46 p.m., Kevin Harwell wrote: > > /branches/13/res/res_pjsip_refer.c, lines 604-605 > > > > > > I don't think pjsip places a null terminator on the filled in string. > > May need to get the r

Re: [asterisk-dev] Adding the support for NACK in asterisk

2014-12-30 Thread Nitesh Bansal
Hi Matt, The scenario which i have in my mind is as follows: WebRTC browser ---> (Inbound) Asterisk --> SIP phone (VP.8 video call) Since this is a webRTC call, RTP stream will be encrypted between Web Browser and Asterisk (call leg 1) and in our case and call leg between As

Re: [asterisk-dev] git migration update

2014-12-30 Thread Paul Belanger
On Mon, Dec 29, 2014 at 9:47 AM, Matthew Jordan wrote: > On Mon, Dec 22, 2014 at 9:01 PM, Tzafrir Cohen > wrote: >> >> Hi, >> >> Thanks for the update. >> >> On Mon, Dec 22, 2014 at 01:03:17PM -0600, Samuel Galarneau wrote: >> > Just wanted to update everyone on the git migration status and illi

Re: [asterisk-dev] [Code Review] 4297: config: Add option to NOT preserve the effective context when changing a template.

2014-12-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4297/#review14049 --- branches/13/include/asterisk/config.h

Re: [asterisk-dev] [Code Review] 4291: Testsuite: Add external bridging tests for Stasis application interaction - Stasis bridge to non-stasis application.

2014-12-30 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4291/ --- (Updated Dec. 30, 2014, 10:36 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4298: Testsuite: Tests for Manager/Config/NoPreserveEffectiveContext

2014-12-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4298/#review14052 --- Ship it! Ship It! - Joshua Colp On Dec. 29, 2014, 1:29 a.m.

Re: [asterisk-dev] [Code Review] 4298: Testsuite: Tests for Manager/Config/NoPreserveEffectiveContext

2014-12-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4298/#review14051 --- asterisk/trunk/tests/manager/config/no_preserve_effective_cont

Re: [asterisk-dev] [Code Review] 4283: Testsuite: Dual channel redirect tests

2014-12-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4283/#review14050 --- Ship it! Ship It! - Joshua Colp On Dec. 24, 2014, 7:01 p.m.

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/#review14053 --- branches/13/res/res_pjsip_outbound_registration.c

[asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

2014-12-30 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4302/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24513 https://i

Re: [asterisk-dev] [Code Review] 4297: config: Add option to NOT preserve the effective context when changing a template.

2014-12-30 Thread George Joseph
> On Dec. 30, 2014, 8:20 a.m., Joshua Colp wrote: > > branches/13/include/asterisk/config.h, line 50 > > > > > > This is picky but we don't use the word "quirk" anywhere else. We > > generally just refer to them as

Re: [asterisk-dev] [Code Review] 4297: config: Add option to NOT preserve the effective context when changing a template.

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4297/ --- (Updated Dec. 30, 2014, 2:45 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- (Updated Dec. 30, 2014, 3:03 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread George Joseph
> On Dec. 30, 2014, 8:39 a.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 > > > > > > I'm concerned that the behavior that used to happen was explicitly > > documente

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- (Updated Dec. 30, 2014, 3:09 p.m.) Review request for Asterisk Developers,

[asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.

2014-12-30 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/ --- (Updated Dec. 30, 2014, 6:12 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.

2014-12-30 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/ --- (Updated Dec. 30, 2014, 6:15 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/ --- Review request for Asterisk Developers. Repository: Asterisk Description