[asterisk-dev] [Code Review] 4305: pjsip cli: Fix sorting of contacts for 'pjsip list contacts'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4305/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4302/#review14062 --- /branches/13/main/bridge_basic.c

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:54 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14061 --- Ship it! Ship It! - Joshua Colp On Dec. 31, 2014, 6:06 p.m.

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- (Updated Dec. 31, 2014, 12:13 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

> On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: > > /trunk/main/rtp_engine.c, line 2193 > > > > > > Yeah, put this in the 96-127 rang instead. > > Scott Griepentrog wrote: > Wouldn't that cause ast_rtp_engin

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:06 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

> On Dec. 23, 2014, 9:41 a.m., Matt Jordan wrote: > > /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml, line 35 > > > > > > Minimum version should be the minimum expected Asterisk version that > > co

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/ --- (Updated Dec. 31, 2014, 12:01 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- (Updated Dec. 31, 2014, 9:10 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

> On Dec. 23, 2014, 9:18 a.m., Matt Jordan wrote: > > /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py, lines 334-335 > > > > > > This could be written as: > > > > res.extend([inc.get_sections(k

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

> On Dec. 23, 2014, 1:41 p.m., Joshua Colp wrote: > > /trunk/main/rtp_engine.c, line 2193 > > > > > > Yeah, put this in the 96-127 rang instead. > > Scott Griepentrog wrote: > Wouldn't that cause ast_rtp_engin

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

> On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: > > /trunk/main/rtp_engine.c, line 2193 > > > > > > Yeah, put this in the 96-127 rang instead. Wouldn't that cause ast_rtp_engine_load_format() to fail because no

[asterisk-dev] CDR: log? lib?

Following a bug report asking to rotate Master.csv in the asterisk package: https://bugs.debian.org/761985 Someone noted there that while those files are lined-based and comulative the same as log files, they should not be rotated by logrotate. Or at least not by default: they're databases. I