> On Jan. 2, 2015, 9:52 p.m., Kevin Harwell wrote: > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_aor/configs/ast1/extensions.conf, > > lines 9-11 > > <https://reviewboard.asterisk.org/r/4310/diff/1/?file=70103#file70103line9> > > > > Should you do a Hangup after the "fail" UserEvent, so execution will > > stop?
I prefer not to. Having it just continue means if more values don't match then it's easier to debug/understand what is going on. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4310/#review14066 ----------------------------------------------------------- On Jan. 2, 2015, 6:05 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4310/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2015, 6:05 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24341 > https://issues.asterisk.org/jira/browse/ASTERISK-24341 > > > Repository: testsuite > > > Description > ------- > > This adds tests for the PJSIP_AOR and PJSIP_CONTACT dialplan functions. AORs > with a registered contact and a permanent contact are tested. The various > fields of each thing (AOR and contact) are retrieved, compared against the > expected value, and if they match then all is well. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/tests.yaml 6163 > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_contact/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_contact/sipp/dynamic-contact.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_contact/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_contact/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_aor/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_aor/sipp/dynamic-contact.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_aor/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_aor/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4310/diff/ > > > Testing > ------- > > Ran... so far away. Er I mean they passed. Sabotaged some things and > confirmed they then failed. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
