Re: [asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4320/ --- (Updated Jan. 7, 2015, 7:25 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4320/#review14120 --- branches/11/res/res_fax.c

Re: [asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4320/ --- (Updated Jan. 7, 2015, 5:29 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4322: app_bridge: return to next dialplan priority

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4322/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24637 https://i

Re: [asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4320/#review14119 --- branches/11/include/asterisk/res_fax.h

Re: [asterisk-dev] [Code Review] 4271: ARI: Allow interoperation of ASYNCGOTO and channels originated to Stasis()

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4271/ --- (Updated Jan. 7, 2015, 3:26 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4321: Testsuite: Test T.38 negotiation timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4321/ --- (Updated Jan. 7, 2015, 3:21 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4321: Testsuite: Test T.38 negotiation timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4321/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

[asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4320/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4292: app_macro: Don't restore the calling location on a channel redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4292/#review14118 --- Ship it! Ship It! - Mark Michelson On Jan. 7, 2015, 6:52 p.

Re: [asterisk-dev] [Code Review] 4319: testsuite: app_macro tests for channel redirect while the macro is active.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4319/#review14117 --- /asterisk/trunk/tests/apps/macro/redirect_inside/test-config.y

Re: [asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4315/ --- (Updated Jan. 7, 2015, 1:36 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4284: Testsuite: Update ARI test for continuation and add new ARI test for origination to dialplan location

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4284/ --- (Updated Jan. 7, 2015, 1:32 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

> On Jan. 6, 2015, 10:13 a.m., Kevin Harwell wrote: > > Since we are bumping the API should this be mentioned in the UPGRADE file? I'll add a note in UPGRADE. > On Jan. 6, 2015, 10:13 a.m., Kevin Harwell wrote: > > /branches/13/include/asterisk/manager.h, lines 308-315 > >

[asterisk-dev] [Code Review] 4319: testsuite: app_macro tests for channel redirect while the macro is active.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4319/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23850 https://i

Re: [asterisk-dev] [Code Review] 4285: Bug fixes for ARI Originate/Continue with label support (Continuation of /r/4101)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4285/ --- (Updated Jan. 7, 2015, 12:53 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4292: app_macro: Don't restore the calling location on a channel redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4292/ --- (Updated Jan. 7, 2015, 12:52 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4292: app_macro: Don't restore the calling location on a channel redirect.

> On Dec. 22, 2014, 10:20 p.m., Matt Jordan wrote: > > You'll need to write a test that verifies this code change. > > > > Note that Kevin just wrote a number of single channel redirect tests > > (https://reviewboard.asterisk.org/r/4281/) - you can add one for a channel > > sitting in a Macro

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4318/ --- (Updated Jan. 7, 2015, 11:49 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4307: res_pjsip_exten_state: Change 'does not exist' warning to verb/4

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4307/ --- (Updated Jan. 7, 2015, 12:17 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4307: res_pjsip_exten_state: Change 'does not exist' warning to verb/4

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4307/#review14114 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 6:07 p.m.,

Re: [asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change "MWI Subscription failed" message from warning to verb/4.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4306/ --- (Updated Jan. 7, 2015, 12:14 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change "MWI Subscription failed" message from warning to verb/4.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4306/#review14113 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 6:09 p.m.,

Re: [asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change "MWI Subscription failed" message from warning to verb/4.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4306/ --- (Updated Jan. 7, 2015, 11:09 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4307: res_pjsip_exten_state: Change 'does not exist' warning to verb/4

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4307/ --- (Updated Jan. 7, 2015, 11:07 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313/ --- (Updated Jan. 7, 2015, 11:52 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4296: PJSIP: Fix bugs and improve documentation of remote attended transfers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4296/ --- (Updated Jan. 7, 2015, 11:36 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

> On Jan. 7, 2015, 10:22 a.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_registration.c, lines 1501-1502 > > > > > > Did you test this? It was a "should be fine" statement. I did. An auth-only cha

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

> On Jan. 7, 2015, 8:52 a.m., Mark Michelson wrote: > > The option flag you've introduced is unnecessary. There is an > > ast_shutting_down() function that you can call to determine if Asterisk is > > shutting down. > > > > I've been thinking about this a bit more since yesterday, and I think

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/#review14110 --- branches/13/res/res_pjsip_outbound_registration.c

Re: [asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313/#review14109 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 4:29 p.m.,

Re: [asterisk-dev] [Code Review] 4307: res_pjsip_exten_state: Change 'does not exist' warning to verb/4

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4307/#review14108 --- I'd opt for LOG_NOTICE based on the conclusion in the other rev

Re: [asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change "MWI Subscription failed" message from warning to verb/4.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4306/#review14107 --- I'd opt for LOG_NOTICE based on the conclusion in the other rev

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

> On Jan. 7, 2015, 3:52 p.m., Mark Michelson wrote: > > The option flag you've introduced is unnecessary. There is an > > ast_shutting_down() function that you can call to determine if Asterisk is > > shutting down. > > > > I've been thinking about this a bit more since yesterday, and I think

Re: [asterisk-dev] [Code Review] 4298: Testsuite: Tests for Manager/Config/NoPreserveEffectiveContext

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4298/ --- (Updated Jan. 7, 2015, 11 a.m.) Status -- This change has been marked

Re: [asterisk-dev] [Code Review] 4297: config: Add option to NOT preserve the effective context when changing a template.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4297/ --- (Updated Jan. 7, 2015, 10:56 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313/ --- (Updated Jan. 7, 2015, 9:29 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

On 07 Jan 2015, at 17:05, George Joseph wrote: > I'm open to other suggestions but you absolutely can't send a > NOTIFY/terminated to a subscriber and expect to pick up where you left off. > They'll respond with a 481. Also, testing for restart vs shutdown isn't > viable as you may perform

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

> On Jan. 7, 2015, 8:52 a.m., Mark Michelson wrote: > > The option flag you've introduced is unnecessary. There is an > > ast_shutting_down() function that you can call to determine if Asterisk is > > shutting down. > > > > I've been thinking about this a bit more since yesterday, and I think

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

On Wed, Jan 7, 2015 at 8:31 AM, Olle E. Johansson wrote: > > On 07 Jan 2015, at 16:24, George Joseph wrote: > > This patch suppresses the sending of 'NOTIFY/terminated' on shutdown for > persistent connections. To do this, I've had to add a new > AST_OPT_FLAG_SHUTTING DOWN to options so we kn

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/ --- (Updated Jan. 7, 2015, 8:52 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4318/#review14104 --- The option flag you've introduced is unnecessary. There is an

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

On 07 Jan 2015, at 16:24, George Joseph wrote: > This patch suppresses the sending of 'NOTIFY/terminated' on shutdown for > persistent connections. To do this, I've had to add a new > AST_OPT_FLAG_SHUTTING DOWN to options so we know that a shut down is in > progress. Just make sure that NOTI

[asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4318/ --- Review request for Asterisk Developers and Mark Michelson. Repository: Ast

Re: [asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313/#review14103 --- branches/13/funcs/func_config.c

Re: [asterisk-dev] [Code Review] 4310: pjsip :Add tests for PJSIP_AOR and PJSIP_CONTACT dialplan functions

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4310/ --- (Updated Jan. 7, 2015, 3:02 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/#review14102 --- branches/13/res/res_pjsip_outbound_registration.c

Re: [asterisk-dev] [Code Review] 4272: Testsuite: Verify that bridged channels originated into Stasis and AMI Redirect interoperate properly

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4272/#review14101 --- Ship it! Ship It! - Joshua Colp On Dec. 29, 2014, 4:17 p.m.

Re: [asterisk-dev] [Code Review] 4297: config: Add option to NOT preserve the effective context when changing a template.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4297/#review14100 --- Ship it! Ship It! - Joshua Colp On Dec. 30, 2014, 9:45 p.m.

Re: [asterisk-dev] [Code Review] 4284: Testsuite: Update ARI test for continuation and add new ARI test for origination to dialplan location

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4284/#review14099 --- Ship it! Nice naming of things. - Joshua Colp On Dec. 19, 2