[asterisk-dev] [Code Review] 4337: testsuite: Verify that bad MACRO_RESULT/GOSUB_RESULT values don't create multiple DialEnd events

2015-01-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4337/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24682 https://i

[asterisk-dev] [Code Review] 4336: app_dial: Don't publish DialEnd events twice if GOSUB_RESULT or MACRO_RESULT return an unexpected value

2015-01-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4336/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24682 https://i

Re: [asterisk-dev] [Code Review] 4327: Various fixes for OS X

2015-01-13 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4327/ --- (Updated Jan. 13, 2015, 8:14 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4319: testsuite: app_macro tests for channel redirect while the macro is active.

2015-01-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4319/ --- (Updated Jan. 13, 2015, 12:23 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4292: app_macro: Don't restore the calling location on a channel redirect.

2015-01-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4292/ --- (Updated Jan. 13, 2015, 12:06 p.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 4331: res_pjsip_multihomed: Account for when the transport on a message is already correct

2015-01-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4331/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24615 https://i

[asterisk-dev] [Code Review] 4335: res_pjsip_multihomed: Test to ensure correct message contents when multiple transports exist

2015-01-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4335/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24615 https://i

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread Joshua Colp
> On Jan. 13, 2015, 3:48 p.m., jbigelow wrote: > > * Under 'URI Parsing' it states: "For the purposes of transport selection > > the transport parameter is examined." I suggest clarifing that the > > transport parameter being spoke of is the 'transport' parameter for > > endpoint types in pjsi

Re: [asterisk-dev] [Code Review] 4317: Testsuite: PJSIP remote attended transfer test

2015-01-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4317/#review14170 --- Ship it! Ship It! - Matt Jordan On Jan. 12, 2015, 5:16 p.m.

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread Joshua Colp
> On Jan. 13, 2015, 3:48 p.m., jbigelow wrote: > > * Under 'URI Parsing' it states: "For the purposes of transport selection > > the transport parameter is examined." I suggest clarifing that the > > transport parameter being spoke of is the 'transport' parameter for > > endpoint types in pjsi

Re: [asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2015-01-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3707/#review14169 --- Ship it! Tested and verified that the patch properly formats t

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328/#review14168 --- * Under 'URI Parsing' it states: "For the purposes of transport

Re: [asterisk-dev] [Code Review] 4329: chan_pjsip: Add configure check for presence of 'pjsip_get_dest_info' function.

2015-01-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4329/ --- (Updated Jan. 13, 2015, 6:07 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread Joshua Colp
> On Jan. 12, 2015, 10:50 p.m., Mark Michelson wrote: > > * "The transport type from above is used to determine which SRV record to > > look up. This means that the original URI *must* include the transport type > > for TCP and TLS types." > > What if the URI is a SIPS URI? Does that have any b