Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

> On Jan. 30, 2015, 1:22 a.m., George Joseph wrote: > > If you run the Testsuite, you'll get a good indication of whether this is > > truly backwards compatible. I ran the test apps/queue/set_penalty which makes use of ami.command and it failed. However this appears to be a bug with starpy, i

Re: [asterisk-dev] Asterisk with socket.io

Thanks Dan. Do you have any example file to suggest how to use it. I am looking for code lines which I can use in our app to connect, send and receive from Nodejs applications. thanks in advance ! On Wed, Jan 21, 2015 at 11:23 PM, Dan Jenkins wrote: > > > On Wed, Jan 21, 2015 at 2:36 AM, Vipul

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4391/#review14384 --- If you run the Testsuite, you'll get a good indication of wheth

[asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4391/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24730 https://i

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/ --- (Updated Jan. 29, 2015, 5:02 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14383 --- Ship it! Ship It! - rmudgett On Jan. 29, 2015, 4:54 p.m., A

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- (Updated Jan. 29, 2015, 4:54 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- (Updated Jan. 29, 2015, 4:48 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 29, 2015, 3:29 p.m., Mark Michelson wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, lines > > 72-75 > > > > > > Heh, I have one more comment and it's a real nitpicky thing.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 29, 2015, 4:23 p.m., Mark Michelson wrote: > > /branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41 > > > > > > I'm curious why you elected to use MAC addresses as the endpoint names. > >

Re: [asterisk-dev] [Code Review] 4352: testsuite: Add tests for ARI redirect; PJSIP Transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4352/#review14380 --- Ship it! Ship It! - Kevin Harwell On Jan. 20, 2015, 10:06 p

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 29, 2015, 11:20 a.m., rmudgett wrote: > > ./branches/13/main/http.c, lines 80-81 > > > > > > Double this because SVN versions could get lengthy and server names can > > be larger as well. Okay. I will mak

[asterisk-dev] [Code Review] 4390: app_agent_pool: Fix initial module load agent device state reporting.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4390/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24737 https://i

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14378 --- /branches/13/configs/examples/super_awesome_company/extensions

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14377 --- /branches/13/configs/examples/super_awesome_company/extensions

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/pjsip.conf, lines 14-22 > > > > > > For the endpoint, I would also set: > > > > rtp_symmetric=yes > >

Re: [asterisk-dev] [Code Review] 4330: Testsuite: Add external bridging tests for Stasis bridge (one channel) interactions

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4330/ --- (Updated Jan. 29, 2015, 3:37 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/#review14374 --- Ship it! Ship It! - Mark Michelson On Jan. 29, 2015, 8:49 p

Re: [asterisk-dev] [Code Review] 4345: Use SIPS Contact headers as prescribed by RFC 3261 (res_pjsip)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4345/ --- (Updated Jan. 29, 2015, 2:58 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/ --- (Updated Jan. 29, 2015, 2:49 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4346: Use SIPS Contact headers as prescribed by RFC 3261 (chan_sip)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4346/ --- (Updated Jan. 29, 2015, 2:40 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 28, 2015, 6:21 a.m., Corey Farrell wrote: > > If we assume that there are always unknown security vulnerabilities, I > > think it is worth completely removing "Server: Asterisk/". > > Another option would be trimming to major version only - Server: > > Asterisk/13. Otherwise any sy

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/#review14372 --- I don't really like the idea of continually sending the same pu

Re: [asterisk-dev] [Code Review] 4388: Testsuite: Test for res_pjsip_config_wizard auto-create hints.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4388/#review14371 --- Ship it! Ship It! - Matt Jordan On Jan. 29, 2015, 11:36 a.m

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

> On Jan. 29, 2015, 10:14 a.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_publish.c, line 927 > > > > > > So... > > > > This may actually cause publish state to be reflected incorrectly on

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/#review14369 --- Ship it! Ship It! - Matt Jordan On Jan. 29, 2015, 12:52 p.m

Re: [asterisk-dev] [Code Review] 4389: Memory leak cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4389/#review14368 --- Ship it! Ship It! - Matt Jordan On Jan. 29, 2015, 1:24 p.m.

Re: [asterisk-dev] [Code Review] 4389: Memory leak cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4389/ --- (Updated Jan. 29, 2015, 7:24 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4377/#review14367 --- Ship it! Ship It! - Matt Jordan On Jan. 27, 2015, 11:02 p.m

Re: [asterisk-dev] [Code Review] 4389: Memory leak cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4389/ --- (Updated Jan. 29, 2015, 7:18 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

> On Jan. 28, 2015, 8:15 a.m., Matt Jordan wrote: > > /branches/13/res/stasis/stasis_bridge.c, lines 115-133 > > > > > > You may want to consider the usage of a goto here (gasp!) to reduce > > indentation: > >

Re: [asterisk-dev] [Code Review] 4389: Memory leak cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4389/#review14365 --- /branches/13/main/manager.c

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/ --- (Updated Jan. 29, 2015, 12:52 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14362 --- Ship it! ./branches/13/main/http.c

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/#review14364 --- Ship it! Ship It! - rmudgett On Jan. 29, 2015, 11:20 a.m.,

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

> On Jan. 28, 2015, 3:08 p.m., rmudgett wrote: > > /branches/13/include/asterisk/bridge.h, line 245 > > > > > > push_peek should not use push's typedef. It should use its own in case > > they need to diverge since

[asterisk-dev] [Code Review] 4389: Memory leak cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4389/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24736 https://i

Re: [asterisk-dev] [Code Review] 4362: chan_sip Invite: Replaces hangup bug fix

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4362/#review14363 --- Ship it! I'll go out on the limb and click the Ship It! button

[asterisk-dev] [Code Review] 4388: Testsuite: Test for res_pjsip_config_wizard auto-create hints.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4388/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/ --- (Updated Jan. 29, 2015, 11:20 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 28, 2015, 7:21 a.m., Corey Farrell wrote: > > If we assume that there are always unknown security vulnerabilities, I > > think it is worth completely removing "Server: Asterisk/". > > Another option would be trimming to major version only - Server: > > Asterisk/13. Otherwise any sy

Re: [asterisk-dev] [Code Review] 4387: res_pjsip_exten_state: Reduce log clutter... change a WARNING to a VERBOSE/2.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4387/ --- (Updated Jan. 29, 2015, 10:46 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

> On Jan. 29, 2015, 4:14 p.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_publish.c, line 927 > > > > > > So... > > > > This may actually cause publish state to be reflected incorrectly on >

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

> On Jan. 29, 2015, 10:14 a.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_publish.c, line 927 > > > > > > So... > > > > This may actually cause publish state to be reflected incorrectly on

Re: [asterisk-dev] [Code Review] 4362: chan_sip Invite: Replaces hangup bug fix

> On Jan. 23, 2015, 3:30 p.m., Matt Jordan wrote: > > After reading through the analysis on the underlying ASTERISK issue, I > > don't have any findings with the patch. I'm always a little concerned when > > we have to add a new state to keep track of on the sip_pvt, but right now I > > can't

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/#review14356 --- branches/13/res/res_pjsip_outbound_publish.c

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/ --- (Updated Jan. 29, 2015, 9:55 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 28, 2015, 6:21 a.m., Corey Farrell wrote: > > If we assume that there are always unknown security vulnerabilities, I > > think it is worth completely removing "Server: Asterisk/". > > Another option would be trimming to major version only - Server: > > Asterisk/13. Otherwise any sy

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4384/#review14354 --- branches/13/res/res_pjsip_outbound_publish.c

Re: [asterisk-dev] [Code Review] 4387: res_pjsip_exten_state: Reduce log clutter... change a WARNING to a VERBOSE/2.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4387/#review14353 --- Ship it! Ship It! - Joshua Colp On Jan. 29, 2015, 1:10 a.m.