Re: [asterisk-dev] [Code Review] 4108: Weak References

2015-02-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4108/ --- (Updated Feb. 5, 2015, 2:30 a.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4108: Weak References

2015-02-04 Thread Corey Farrell
> On Dec. 9, 2014, 7:36 p.m., rmudgett wrote: > > Summary of this weak ref implementation: > > weak_proxy_obj <-> obj > > > > * The weak_proxy_obj and the obj get refs to each other on the initial call > > to ao2_weaken(). > > * The weak_proxy_obj will then stick around for as long as obj lives

[asterisk-dev] chan_xxx for BSSAP interface at Ainterface of GSM

2015-02-04 Thread Treesa Fairy Joseph
Hi,   I am trying to use asterisk, for GSM calls. I am trying to route GSM calls from the A interface (interface between BSC and MSC) through asterisk server, so that later I can send it through soft switch. I want to know if  there is any chan_xxx module, in the channels directory of the aste

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-04 Thread rnewton
> On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > >

Re: [asterisk-dev] [Code Review] 4405: Fix ast_odbc_find_table function in res_odbc

2015-02-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4405/#review14411 --- I don't see anything wrong in this patch, but I'm a bit confuse

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/#review14410 --- "While a shutdown request is pending it is desirable to continu

[asterisk-dev] [Code Review] 4405: Fix ast_odbc_find_table function in res_odbc

2015-02-04 Thread ibercom
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4405/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24742 https://i

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/ --- (Updated Feb. 4, 2015, 10:31 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14408 --- /branches/11/configure.ac

Re: [asterisk-dev] [Code Review] 4365: Adding AMQP backend for CDR and CEL

2015-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4365/#review14407 --- /branches/13/cdr/cdr_amqp.c

Re: [asterisk-dev] how to get json body from client->ser

2015-02-04 Thread Matthew Jordan
On Tue, Feb 3, 2015 at 10:05 PM, Vipul Rastogi wrote: > I am trying to retrieve json body from http response (below code) but > ast_http_get_json method expects ast_variable which is probably list of > headers. so question is how to I get this from client (or client->ser). > Suggestions most welco

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14405 --- branches/13/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4400: Add no_answer to ARI hangup causes

2015-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4400/#review14404 --- Ship it! This can go into 13. It's backwards compatible. - Jo