Hi All,
I've managed to re-implement the basic functionality of app_dial using
ARI and PHPARI.
I've tested it and it supports handling of multiple calls at the same time.
Having said that,
I would highly appreciate some feedback in regards to the methodology, or
if anybody
can see something I
On Dec. 2, 2014, 9:30 a.m., opticron wrote:
/branches/11/include/asterisk/module.h, lines 272-278
https://reviewboard.asterisk.org/r/4141/diff/1/?file=68704#file68704line272
These could use a bit of documentation.
I've documented the macro's instead.
- Corey
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4141/
---
(Updated Feb. 5, 2015, 3:36 a.m.)
Review request for Asterisk Developers.
On Feb. 4, 2015, 8:24 p.m., Mark Michelson wrote:
I don't see anything wrong in this patch, but I'm a bit confused about what
this is fixing and how this is fixing it. Can you go into a bit more detail
about why this fixes the problem you were seeing?
wdoekes's explanation is better
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4407/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4399/
---
(Updated Feb. 5, 2015, 3:58 p.m.)
Review request for Asterisk Developers.
On Feb. 4, 2015, 2:17 p.m., Mark Michelson wrote:
While a shutdown request is pending it is desirable to continue to process
ARI HTTP requests for current calls
I'm curious what the justification behind this is. I would expect that for
a now or graceful shutdown, you would want
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4407/#review14419
---
Ship it!
If you haven't already I'd also run any relevant
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4407/#review14420
---
2) Util ast_join_delim: don't touch w[x] if x out of bounds of
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4408/
---
Review request for Asterisk Developers and Mark Michelson.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4405/#review14416
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 5, 2015, 3:35
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
On Feb. 4, 2015, 8:21 a.m., Joshua Colp wrote:
/branches/13/include/asterisk/cel.h, lines 37-38
https://reviewboard.asterisk.org/r/4365/diff/3/?file=71072#file71072line37
Why were these added here?
Both are used in this file. If you don't happen to #include them prior to cel.h
in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4365/
---
(Updated Feb. 5, 2015, 7:13 p.m.)
Review request for Asterisk Developers.
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, lines 24-30
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line24
I'd rename these to:
auth-basic
aor-basic
On Jan. 30, 2015, 1:13 p.m., Joshua Colp wrote:
/branches/13/configs/examples/super_awesome_company/modules.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71112#file71112line41
Add format_pcm. This covers ulaw and g722 as well. On installation it's
wise to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4405/#review14414
---
Ship it!
LGTM.
branches/11/res/res_odbc.c
On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote:
/branches/13/configs/examples/super_awesome_company/README, line 2
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71107#file71107line2
maybe shorten directory name to awesome, or sae?
Or, another option would be to
18 matches
Mail list logo
